starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Incorrect DECCRA behavior when copying from a double-width line #19561

New Issue
Open
opened 2026-01-31 06:47:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:47:17 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Mar 19, 2023).

Windows Terminal version

1.17.1023

Windows build number

10.0.19044.2364

Other Software

No response

Steps to reproduce

  1. Open a WSL bash shell in Windows Terminal.

  2. Make sure the viewport width is around 80 columns.

  3. Execute the following command:

     printf "\e#8\e[8H\e[J\e[4H\e[41m\e#6\e[m\e[H\e[3;20;5;60;1;10;20;1\$v"

Expected Behavior

That test case is copying a block of text spanning a double-width row from the top to the bottom half of the screen. The copied block should look something like this (the gap is from the section of the double-width row that is off screen).

image

Actual Behavior

The copied block ends up looking like this:

image

This is a regression that was introduced in PR #14650 when I was trying to fix horizontal scrolling of DBCS characters. The copy operation reads two characters in advance, and the code that checks whether the source is off screen ends up using the cursor position from the wrong character.

This can be fixed by saving the current srcPos at the same time as we save the current OutputCell in the loop here:

b9248fa903/src/terminal/adapter/adaptDispatch.cpp (L1155-L1163)

Originally created by @j4james on GitHub (Mar 19, 2023). ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19044.2364 ### Other Software _No response_ ### Steps to reproduce 1. Open a WSL bash shell in Windows Terminal. 2. Make sure the viewport width is around 80 columns. 3. Execute the following command: printf "\e#8\e[8H\e[J\e[4H\e[41m\e#6\e[m\e[H\e[3;20;5;60;1;10;20;1\$v" ### Expected Behavior That test case is copying a block of text spanning a double-width row from the top to the bottom half of the screen. The copied block should look something like this (the gap is from the section of the double-width row that is off screen). ![image](https://user-images.githubusercontent.com/4181424/226184467-91e4efb4-29be-4faf-9c75-26f398d44f22.png) ### Actual Behavior The copied block ends up looking like this: ![image](https://user-images.githubusercontent.com/4181424/226184696-f162812b-91b1-4164-b1a0-022947276e65.png) This is a regression that was introduced in PR #14650 when I was trying to fix horizontal scrolling of DBCS characters. The copy operation reads two characters in advance, and the code that checks whether the source is off screen ends up using the cursor position from the wrong character. This can be fixed by saving the current `srcPos` at the same time as we save the current `OutputCell` in the loop here: https://github.com/microsoft/terminal/blob/b9248fa903eaa8d187c72bf08f8aa17b25f9d6bb/src/terminal/adapter/adaptDispatch.cpp#L1155-L1163
claunia added the Help WantedProduct-ConhostIssue-BugIn-PRArea-VTNeeds-Tag-Fix labels 2026-01-31 06:47:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted In-PR Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?