starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Use AlignAfterOpenBracket BlockIndent for clang-format #19632

New Issue
Open
opened 2026-01-31 06:49:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:49:16 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Apr 4, 2023).

This makes you wonder if you scared your code, because it's trying to flee from your screen:

bool ControlCore::SendMouseEvent(const til::point viewportPos,
                                 const unsigned int uiButton,
                                 const ControlKeyStates states,
                                 const short wheelDelta,
                                 const TerminalInput::MouseButtonState state)
{
    return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state);
}

This on the other hand is the one true way, no exceptions (sample size = 1, myself):

bool ControlCore::SendMouseEvent(
    const til::point viewportPos,
    const unsigned int uiButton,
    const ControlKeyStates states,
    const short wheelDelta,
    const TerminalInput::MouseButtonState state
) {
    return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state);
}

We can get this behavior by setting AlignAfterOpenBracket: BlockIndent in .clang-format. The problems:

  • Code like the former example, will not be formatted like the latter example even if we set that option, because the former isn't actually block indented to begin with! It's just line breaks after the first argument and so clang-format turns it into: 
    bool ControlCore::SendMouseEvent(const til::point viewportPos, const unsigned int uiButton, const ControlKeyStates states, const short wheelDelta, const TerminalInput::MouseButtonState state)
{
    return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state);
}
    Most of our code looks like that unfortunately. This would be correct from the POV of clang-format: 
    bool ControlCore::SendMouseEvent(
    const til::point viewportPos,
    const unsigned int uiButton,
    const ControlKeyStates states,
    const short wheelDelta,
    const TerminalInput::MouseButtonState state)
{
    return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state);
}
    This can be mostly fixed with this regex replacement: ((?!\s|::)\w+\()([^{}()]+,$) -> $1\n$2
  • Oww: 
    523 files changed, 15819 insertions(+), 13065 deletions(-)
Originally created by @lhecker on GitHub (Apr 4, 2023). This makes you wonder if you scared your code, because it's trying to flee from your screen: ```cpp bool ControlCore::SendMouseEvent(const til::point viewportPos, const unsigned int uiButton, const ControlKeyStates states, const short wheelDelta, const TerminalInput::MouseButtonState state) { return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state); } ``` This on the other hand is the one true way, no exceptions (sample size = 1, myself): ```cpp bool ControlCore::SendMouseEvent( const til::point viewportPos, const unsigned int uiButton, const ControlKeyStates states, const short wheelDelta, const TerminalInput::MouseButtonState state ) { return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state); } ``` We can get this behavior by setting `AlignAfterOpenBracket: BlockIndent` in `.clang-format`. The problems: * Code like the former example, will not be formatted like the latter example even if we set that option, because the former isn't actually block indented to begin with! It's just line breaks after the first argument and so clang-format turns it into: ```cpp bool ControlCore::SendMouseEvent(const til::point viewportPos, const unsigned int uiButton, const ControlKeyStates states, const short wheelDelta, const TerminalInput::MouseButtonState state) { return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state); } ``` Most of our code looks like that unfortunately. This would be correct from the POV of clang-format: ```cpp bool ControlCore::SendMouseEvent( const til::point viewportPos, const unsigned int uiButton, const ControlKeyStates states, const short wheelDelta, const TerminalInput::MouseButtonState state) { return _terminal->SendMouseEvent(viewportPos, uiButton, states, wheelDelta, state); } ``` This can be mostly fixed with this regex replacement: `((?!\s|::)\w+\()([^{}()]+,$)` -> `$1\n$2` * Oww: ``` 523 files changed, 15819 insertions(+), 13065 deletions(-) ```
claunia added the Issue-TaskProduct-TerminalArea-CodeHealth labels 2026-01-31 06:49:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?