starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Reordering tabs messes up relation between tabs and panes #19643

New Issue
Closed
opened 2026-01-31 06:49:32 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:49:32 +00:00
Owner
Copy Link

Originally created by @djdv on GitHub (Apr 5, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

62448969b3

Windows build number

10.0.25330.0

Other Software

No response

Steps to reproduce

Open multiple tabs. Reorder them.

Expected Behavior

No response

Actual Behavior

The relation/index between tabs and panes is now broken.
Selecting a tab will select a pane which does not belong to that tab. Closing panes will close the wrong tab.
See: https://www.youtube.com/watch?v=Qa9jxFnvI8U

Originally created by @djdv on GitHub (Apr 5, 2023). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 62448969b30325a75f35201427a052de0e4dbb7d ### Windows build number 10.0.25330.0 ### Other Software _No response_ ### Steps to reproduce Open multiple tabs. Reorder them. ### Expected Behavior _No response_ ### Actual Behavior The relation/index between tabs and panes is now broken. Selecting a tab will select a pane which does not belong to that tab. Closing panes will close the wrong tab. See: https://www.youtube.com/watch?v=Qa9jxFnvI8U
claunia commented 2026-01-31 06:49:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 13, 2023):

More concrete repro steps:

  • Open two windows
  • In one window, open two tabs. Pwsh and CMD are good, so they're clearly separate.
  • Reorder those two.
  • Drag the inactive one to the other window.
  • Experience having the active term core in both windows!

It's so obvious:

Wait but no, _onTabStripDrop doesn't ever cause a _MoveTab. It triggers a _RequestReceiveContentHandlers, which is bubbled to the sender, which does a SendContentToOther, which does a _MoveContent on the dragged tab. Hmm.

@zadjii-msft commented on GitHub (Apr 13, 2023): More concrete repro steps: * Open two windows * In one window, open two tabs. Pwsh and CMD are good, so they're clearly separate. * Reorder those two. * Drag the inactive one to the other window. * Experience having the active term core in both windows! <hr> ~It's so obvious:~ ![](https://user-images.githubusercontent.com/18356694/231828087-7a191811-9248-4ef7-970e-5575801c6b84.png) Wait but no, `_onTabStripDrop` doesn't ever cause a `_MoveTab`. It triggers a `_RequestReceiveContentHandlers`, which is bubbled to the sender, which does a `SendContentToOther`, which does a `_MoveContent` on the dragged tab. Hmm.
claunia commented 2026-01-31 06:49:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 13, 2023):

oh its so bad

Just reordering tabs, no tearout, just breaks the entire relationship of it. I wonder if adding these drag/drop handlers somehow broke the reorder events we get...

It sure did. We don't get TabView.TabItemsChanged anymore now that we get TabDragStarting & TabStripDrop. WELP. Let's see what we can do.

@zadjii-msft commented on GitHub (Apr 13, 2023): oh its so bad Just reordering tabs, no tearout, just breaks the entire relationship of it. I wonder if adding these drag/drop handlers somehow broke the reorder events we get... It sure did. We don't get `TabView.TabItemsChanged` anymore now that we get `TabDragStarting` & `TabStripDrop`. WELP. Let's see what we can do.
claunia commented 2026-01-31 06:49:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 13, 2023):

Upstream: https://github.com/microsoft/microsoft-ui-xaml/issues/8388

@zadjii-msft commented on GitHub (Apr 13, 2023): Upstream: https://github.com/microsoft/microsoft-ui-xaml/issues/8388
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface In-PR Issue-Bug Priority-1 Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?