starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

{Freeway-Bug}[Settings]: Contrast ratio for 'Selected' list-item is '1.37:1' with it's background, on activating 'Save' or 'Discard changes' buttons. #19683

New Issue
Closed
opened 2026-01-31 06:50:41 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:50:41 +00:00
Owner
Copy Link

Originally created by @Saiteja341 on GitHub (Apr 10, 2023).

Windows Terminal version

1.18.902.0

Windows build number

23031.1000

Other Software

Test environment:
OS: Version 22H2 (OS build 23031.1000)
Application: Windows Terminal
Tool: accessibility insights for windows

Steps to reproduce

Repro steps:

  1. Open the 'windows terminal' application.
  2. Log in with valid credentials.
  3. Now open the 'Settings' using 'Ctrl+,' (Key may varies from user to user).
  4. Navigate to any of the list-item excluding profiles & select it.
  5. Change the settings & activate 'Save' or 'Discard changes' buttons.
  6. Open accessibility insights for windows & verify the contrast ratio of the selected list-item with the background.

Observation: Issue repro only on activating 'Save' or 'Discard changes' buttons.

User experience:
Users with low vision will feel difficulty in recognizing the text, if contrast ratio is less than '4.5:1' with the background.

Guideline reference:
https://www.w3.org/TR/WCAG21/#contrast-minimum

Attachment:
Contrast ratio fails for the selected list item, on activating 'Save' or 'discard changes' buttons..zip

Expected Behavior

Contrast ratio for 'Selected' list-item should be greater than or equal to '4.5:1' with it's background, on activating 'Save' or 'Discard changes' buttons.

Actual Behavior

On activating 'Save' or 'Discard changes' buttons, contrast ratio for 'Selected' list-item is '1.37:1' with it's background which is less than '4.5:1' (Required).

Originally created by @Saiteja341 on GitHub (Apr 10, 2023). ### Windows Terminal version 1.18.902.0 ### Windows build number 23031.1000 ### Other Software Test environment: OS: Version 22H2 (OS build 23031.1000) Application: Windows Terminal Tool: accessibility insights for windows ### Steps to reproduce Repro steps: 1. Open the 'windows terminal' application. 2. Log in with valid credentials. 3. Now open the 'Settings' using 'Ctrl+,' (Key may varies from user to user). 4. Navigate to any of the list-item excluding profiles & select it. 5. Change the settings & activate 'Save' or 'Discard changes' buttons. 6. Open accessibility insights for windows & verify the contrast ratio of the selected list-item with the background. Observation: Issue repro only on activating 'Save' or 'Discard changes' buttons. User experience: Users with low vision will feel difficulty in recognizing the text, if contrast ratio is less than '4.5:1' with the background. Guideline reference: https://www.w3.org/TR/WCAG21/#contrast-minimum Attachment: [Contrast ratio fails for the selected list item, on activating 'Save' or 'discard changes' buttons..zip](https://github.com/microsoft/terminal/files/11189978/Contrast.ratio.fails.for.the.selected.list.item.on.activating.Save.or.discard.changes.buttons.zip) ### Expected Behavior Contrast ratio for 'Selected' list-item should be greater than or equal to '4.5:1' with it's background, on activating 'Save' or 'Discard changes' buttons. ### Actual Behavior On activating 'Save' or 'Discard changes' buttons, contrast ratio for 'Selected' list-item is '1.37:1' with it's background which is less than '4.5:1' (Required).
claunia commented 2026-01-31 06:50:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 18, 2023):

Contrast ratio fails for the selected list item, on activating 'Save' or 'discard changes' buttons
@zadjii-msft commented on GitHub (Apr 18, 2023): <img width="964" alt="Contrast ratio fails for the selected list item, on activating 'Save' or 'discard changes' buttons" src="https://user-images.githubusercontent.com/18356694/232844517-c993e806-14b8-4d2a-b29e-6697c60a5373.png">
claunia commented 2026-01-31 06:50:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 18, 2023):

classic XAML.

  • OS in light theme
  • app in dark theme
  • hit discard

Guess I'll just go plaster more RequestedTheme calls everywhere.

@zadjii-msft commented on GitHub (Apr 18, 2023): _classic_ XAML. * OS in light theme * app in dark theme * hit discard Guess I'll just go plaster more `RequestedTheme` calls everywhere.
claunia commented 2026-01-31 06:50:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 20, 2023):

@zadjii-msft commented on GitHub (Apr 20, 2023): * ffda8c4 ✅ * 1825ca1 ✅ * e106c09 ❌
claunia commented 2026-01-31 06:50:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 20, 2023):

Looks like this was happily accidentally fixed in #15162, and I believe that's in 1.18.1041

@zadjii-msft commented on GitHub (Apr 20, 2023): Looks like this was happily accidentally fixed in #15162, and I believe that's in 1.18.1041
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev1 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?