starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Selected block is copied as one line into clipboard #19686

New Issue
Open
opened 2026-01-31 06:50:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:50:48 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Apr 10, 2023).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.17.1023

Windows build number

10.0.19045.2728

Other Software

Far or any other TUI (mc, gdb etc.)

Steps to reproduce

  • Get the latest OpenConsole, either from the latest published WT package (1.17.2301.23004) or the latest source (e.g. ea44375f6d)
  • Get Far, any version will do.
  • Run OpenConsole, run Far in it
  • Alt-Space, Properties, uncheck "Enable line wrapping selection", OK
  • Alt-Space, Edit, Mark
  • Select an arbitrary part of the buffer, Enter
  • Paste the copied text somewhere, e.g. into Notepad.

Expected Behavior

The block shape is preserved: clipboard contains text split into multiple lines

Actual Behavior

The block shape is lost, clipboard contains text as one huge line without any line breaks

More

  • It works as expected in Windows 10 conhost (10.0.19041.2546).
  • It works as expected in cmd.exe, so, supposedly, it has something to do with how the app writes the output.
  • Commenting this line "fixes" it:
    ea44375f6d/src/buffer/out/textBuffer.cpp (L1854)
  • Taking into account "wrapping state" etc. probably makes sense when the whole rows are selected:
    image
    but if the user selects and copies an obvious "block", not even connected to the edges:
    image
    it probably should be copied as a block unconditionally.
Originally created by @alabuzhev on GitHub (Apr 10, 2023). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19045.2728 ### Other Software Far or any other TUI (mc, gdb etc.) ### Steps to reproduce - Get the latest OpenConsole, either from the latest published WT package (1.17.2301.23004) or the latest source (e.g. ea44375f6dcdfb3c8bdf05b2f02e38a72d2dde09) - Get [Far](https://farmanager.com/download.php?l=en), any version will do. - Run OpenConsole, run Far in it - Alt-Space, Properties, uncheck "Enable line wrapping selection", OK - Alt-Space, Edit, Mark - Select an arbitrary part of the buffer, Enter - Paste the copied text somewhere, e.g. into Notepad. ### Expected Behavior The block shape is preserved: clipboard contains text split into multiple lines ### Actual Behavior The block shape is lost, clipboard contains text as one huge line without any line breaks ### More - It works as expected in Windows 10 conhost (10.0.19041.2546). - It works as expected in cmd.exe, so, supposedly, it has something to do with how the app writes the output. - Commenting this line "fixes" it: https://github.com/microsoft/terminal/blob/ea44375f6dcdfb3c8bdf05b2f02e38a72d2dde09/src/buffer/out/textBuffer.cpp#L1854 - Taking into account "wrapping state" etc. probably makes sense when the whole rows are selected: ![image](https://user-images.githubusercontent.com/11453922/230973149-2270d7f9-5983-4f40-bd4d-ab601b1bceeb.png) but if the user selects and copies an obvious "block", not even connected to the edges: ![image](https://user-images.githubusercontent.com/11453922/230973181-f1539b32-eb33-4152-9f8d-98c144df18e3.png) it probably should be copied as a block unconditionally.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?