starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Selected block is copied as one line into clipboard #19689

New Issue
Closed
opened 2026-01-31 06:50:51 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 06:50:51 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Apr 10, 2023).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.17.1023

Windows build number

10.0.19045.2728

Other Software

Far or any other TUI (mc, gdb etc.)

Steps to reproduce

  • Get the latest OpenConsole, either from the latest published WT package (1.17.2301.23004) or the latest source (e.g. ea44375f6d)
  • Get Far, any version will do.
  • Run OpenConsole, run Far in it
  • Alt-Space, Properties, uncheck "Enable line wrapping selection", OK
  • Alt-Space, Edit, Mark
  • Select an arbitrary part of the buffer, Enter
  • Paste the copied text somewhere, e.g. into Notepad.

Expected Behavior

The block shape is preserved: clipboard contains text split into multiple lines

Actual Behavior

The block shape is lost, clipboard contains text as one huge line without any line breaks

More

  • It works as expected in Windows 10 conhost (10.0.19041.2546).
  • It works as expected in cmd.exe, so, supposedly, it has something to do with how the app writes the output.
  • Commenting this line "fixes" it:
    ea44375f6d/src/buffer/out/textBuffer.cpp (L1854)
  • Taking into account "wrapping state" etc. probably makes sense when the whole rows are selected:
    image
    but if the user selects and copies an obvious "block", not even connected to the edges:
    image
    it probably should be copied as a block unconditionally.
Originally created by @alabuzhev on GitHub (Apr 10, 2023). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19045.2728 ### Other Software Far or any other TUI (mc, gdb etc.) ### Steps to reproduce - Get the latest OpenConsole, either from the latest published WT package (1.17.2301.23004) or the latest source (e.g. ea44375f6dcdfb3c8bdf05b2f02e38a72d2dde09) - Get [Far](https://farmanager.com/download.php?l=en), any version will do. - Run OpenConsole, run Far in it - Alt-Space, Properties, uncheck "Enable line wrapping selection", OK - Alt-Space, Edit, Mark - Select an arbitrary part of the buffer, Enter - Paste the copied text somewhere, e.g. into Notepad. ### Expected Behavior The block shape is preserved: clipboard contains text split into multiple lines ### Actual Behavior The block shape is lost, clipboard contains text as one huge line without any line breaks ### More - It works as expected in Windows 10 conhost (10.0.19041.2546). - It works as expected in cmd.exe, so, supposedly, it has something to do with how the app writes the output. - Commenting this line "fixes" it: https://github.com/microsoft/terminal/blob/ea44375f6dcdfb3c8bdf05b2f02e38a72d2dde09/src/buffer/out/textBuffer.cpp#L1854 - Taking into account "wrapping state" etc. probably makes sense when the whole rows are selected: ![image](https://user-images.githubusercontent.com/11453922/230973149-2270d7f9-5983-4f40-bd4d-ab601b1bceeb.png) but if the user selects and copies an obvious "block", not even connected to the edges: ![image](https://user-images.githubusercontent.com/11453922/230973181-f1539b32-eb33-4152-9f8d-98c144df18e3.png) it probably should be copied as a block unconditionally.
claunia commented 2026-01-31 06:50:54 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 26, 2023):

@lhecker wanted to rewrite this area using the GetText() API. So he'll handle it as a part of that.

@carlos-zamora commented on GitHub (Apr 26, 2023): @lhecker wanted to rewrite this area using the `GetText()` API. So he'll handle it as a part of that.
claunia commented 2026-01-31 06:50:55 +00:00
Author
Owner
Copy Link

@michalnpl commented on GitHub (May 15, 2023):

I also noticed FAR renders incredibly slow when run inside OpenConsole.

@michalnpl commented on GitHub (May 15, 2023): I also noticed FAR renders incredibly slow when run inside OpenConsole.
claunia commented 2026-01-31 06:50:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 15, 2023):

That's news to us!

@DHowett commented on GitHub (May 15, 2023): That's news to us!
claunia commented 2026-01-31 06:50:55 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 15, 2023):

@michalnpl Have you set UseDx to DWORD 2 under HKEY_CURRENT_USER\Console yet? This would enable AtlasEngine inside OpenConsole. But even with the standard GDI renderer it shouldn't run that slow... 🤔

@lhecker commented on GitHub (May 15, 2023): @michalnpl Have you set `UseDx` to `DWORD` 2 under `HKEY_CURRENT_USER\Console` yet? This would enable AtlasEngine inside OpenConsole. But even with the standard GDI renderer it shouldn't run _that_ slow... 🤔
claunia commented 2026-01-31 06:50:56 +00:00
Author
Owner
Copy Link

@michalnpl commented on GitHub (May 16, 2023):

@DHowett and @lhecker, no, I have not been messing around with the registry. On vanilla main and the latest Windows 10, I get like a ~100 ms delay between pressing a key and a render when using CascadiaPackage, and sometimes you can see incomplete frames (like VSYNC is off). I've been using FAR for ages and have never seen something like this. I'll try to capture it in some format where it is visible.

@michalnpl commented on GitHub (May 16, 2023): @DHowett and @lhecker, no, I have not been messing around with the registry. On vanilla main and the latest Windows 10, I get like a ~100 ms delay between pressing a key and a render when using CascadiaPackage, and sometimes you can see incomplete frames (like VSYNC is off). I've been using FAR for ages and have never seen something like this. I'll try to capture it in some format where it is visible.
claunia commented 2026-01-31 06:50:56 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 16, 2023):

Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁

@DHowett commented on GitHub (May 16, 2023): Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁
claunia commented 2026-01-31 06:50:56 +00:00
Author
Owner
Copy Link

@michalnpl commented on GitHub (May 16, 2023):

Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁

Debug :) Lety me try Release...

@michalnpl commented on GitHub (May 16, 2023): > Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁 Debug :) Lety me try Release...
claunia commented 2026-01-31 06:50:56 +00:00
Author
Owner
Copy Link

@michalnpl commented on GitHub (May 16, 2023):

Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁

Debug :) Let me try Release...

Mystery solved. The release runs with no visible delay. Apologies for the false alarm ;)

============================================

On a separate note. I understand how Release is so much faster, but I was wondering why Debug renders incomplete frames anyway. Is VSYNC off by default on DWM (Desktop Window Manager)? Or am I having no idea what I am talking about? For reference, on Debug, on OpenConsole running Far, I can see this effect with the naked eye:

image

image

@michalnpl commented on GitHub (May 16, 2023): > > Apologies if this is a stupid question--or rude; I don't intend it to be--but are you running a Debug or Release build? 😁 > > Debug :) Let me try Release... Mystery solved. The release runs with no visible delay. Apologies for the false alarm ;) ============================================ On a separate note. I understand how Release is so much faster, but I was wondering why Debug renders incomplete frames anyway. Is VSYNC off by default on DWM (Desktop Window Manager)? Or am I having no idea what I am talking about? For reference, on Debug, on OpenConsole running Far, I can see this effect with the naked eye: ![image](https://github.com/microsoft/terminal/assets/25628581/11fbe3ce-7d48-41c5-85c9-9af973efa36f) ![image](https://github.com/microsoft/terminal/assets/25628581/91747bbe-5dfc-4196-9450-6723136284ba)
claunia commented 2026-01-31 06:50:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 17, 2023):

@michalnpl mind starting a new Discussion about that? This thread probably isn't the right place for that. Could be a couple reasons, but I don't want to cross-pollute the thread too much ☺️

@zadjii-msft commented on GitHub (May 17, 2023): @michalnpl mind starting a [new Discussion](https://github.com/microsoft/terminal/discussions/new/choose) about that? This thread probably isn't the right place for that. Could be a couple reasons, but I don't want to cross-pollute the thread too much ☺️
claunia commented 2026-01-31 06:50:57 +00:00
Author
Owner
Copy Link

@michalnpl commented on GitHub (May 18, 2023):

@zadjii-msft @lhecker @DHowett Sure, sorry for that.

@michalnpl commented on GitHub (May 18, 2023): @zadjii-msft @lhecker @DHowett Sure, sorry for that.
claunia commented 2026-01-31 06:50:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 18, 2023):

@michalnpl no worries! I want to make sure your thought about FAR perf & VSYNC doesn't get lost whenever we get around to fixing this bug ☺️

@zadjii-msft commented on GitHub (May 18, 2023): @michalnpl no worries! I want to make sure your thought about FAR perf & VSYNC doesn't get lost whenever we get around to fixing this bug ☺️
claunia commented 2026-01-31 06:50:57 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 24, 2023):

Frankly, the TextBuffer::GetText function is pretty gnarly. 😄 It has sort of "infected" a dozen functions with its peculiar way of doing things so making any progressive improvements is difficult. 1 On the other hand, the immediate bug fix is quite trivial, so I'll make a separate PR for that. This regressed in a1f42e87a8 btw.

  1. It uses a vector of vectors to represent text, and a pair of vectors of vectors to represent foreground/background colors. When copying plain text, it'll then concatenate the text vector-vectors. It'd be better to just do that right away. Was it done because one might need RTF/HTML text too? The functions that format the vector-vectors are also in TextBuffer and now need to parse the vector-vectors to figure out color changes anyways. Creating those vector-vectors is not cheap either. Just iterating over the buffer directly in GenHTML/RTF would be simpler. The redundant logic for handling block vs. line selection can be abstracted away via templates instead. ↩︎

@lhecker commented on GitHub (May 24, 2023): Frankly, the `TextBuffer::GetText` function is pretty gnarly. 😄 It has sort of "infected" a dozen functions with its peculiar way of doing things so making any progressive improvements is difficult. [^1] On the other hand, the immediate bug fix is quite trivial, so I'll make a separate PR for that. This regressed in a1f42e87a8f7670a405f9df38ee1803db76fc516 btw. [^1]: It uses a vector of vectors to represent text, and a pair of vectors of vectors to represent foreground/background colors. When copying plain text, it'll then concatenate the text vector-vectors. It'd be better to just do that right away. Was it done because one might need RTF/HTML text too? The functions that format the vector-vectors are also in `TextBuffer` and now need to parse the vector-vectors to figure out color changes anyways. Creating those vector-vectors is not cheap either. Just iterating over the buffer directly in GenHTML/RTF would be simpler. The redundant logic for handling block vs. line selection can be abstracted away via templates instead.
claunia commented 2026-01-31 06:50:58 +00:00
Author
Owner
Copy Link

@alabuzhev commented on GitHub (Oct 13, 2023):

@lhecker I can still reproduce it with OpenConsole 1.19.2310.10001 from terminal-1.19.2831.0.
Did it regress again or somehow didn't make it to the releases yet?

@alabuzhev commented on GitHub (Oct 13, 2023): @lhecker I can still reproduce it with OpenConsole 1.19.2310.10001 from terminal-1.19.2831.0. Did it regress again or somehow didn't make it to the releases yet?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?