starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Per-theme-mode profile icons #19782

New Issue
Open
opened 2026-01-31 06:53:27 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 06:53:27 +00:00
Owner
Copy Link

Originally created by @Nantris on GitHub (Apr 29, 2023).

Description of the new feature/enhancement

It would be great to be able to set icons per theme-mode (ie dark/light) - as it stands now a monochromatic icon can look very out of place in the opposite mode. Or maybe this is already possible somehow?

Proposed technical implementation details (optional)

Allow setting dark/light profile icons individually in settings.json

Originally created by @Nantris on GitHub (Apr 29, 2023). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement It would be great to be able to set icons per theme-mode (ie dark/light) - as it stands now a monochromatic icon can look very out of place in the opposite mode. Or maybe this is already possible somehow? # Proposed technical implementation details (optional) Allow setting dark/light profile icons individually in `settings.json`
claunia added the Help WantedArea-SettingsIssue-TaskIn-PRProduct-Terminal labels 2026-01-31 06:53:28 +00:00
claunia commented 2026-01-31 06:53:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 3, 2023):

<sidebar>

FINALLY

A concrete example for the combinatorial explosion of "appearance" states:

We've only ever been using hypotheticals for this discussion, but could never come up with a concrete third variable. This is a pretty solid case for "theme" as a third variable, and why we can't just have four appearance states.

https://github.com/microsoft/terminal/issues/17780#issuecomment-2330197495 also relevant

@zadjii-msft commented on GitHub (May 3, 2023): \<sidebar> FINALLY A concrete example for the combinatorial explosion of "appearance" states: * focused / unfocused * normal / elevated: #3246 * light / dark: #15264 * connection alive / dead: #17780 We've only ever been using hypotheticals for this discussion, but could never come up with a concrete third variable. This is a pretty solid case for "theme" as a third variable, and why we can't just have four appearance states. https://github.com/microsoft/terminal/issues/17780#issuecomment-2330197495 also relevant
claunia commented 2026-01-31 06:53:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 3, 2023):

A bad idea that didn't work

<conjecture>
we believe there's a theme-dominant resource qualifier that you might be able to stealth name the file today and have it secretly work:

"icon": "whatever.png"

and then name the files whatever.theme-dark.png and whatever.theme-light.png.
</conjecture>

That did not work.

If that doesn't work, then we'll probably need something like "icon": { "light": "foo.png", "dark": "bar.png" }, the same as colorscheme

We may also want to consider what it means to make the icon a part of the "appearance", and what the matrix of options that entails.

@zadjii-msft commented on GitHub (May 3, 2023): <details> <summary>A bad idea that didn't work</summary> ~\<conjecture>~ ~we believe there's a theme-dominant resource qualifier that you might be able to stealth name the file _today_ and have it secretly work:~ ``` "icon": "whatever.png" ``` ~and then name the files `whatever.theme-dark.png` and `whatever.theme-light.png`.~ ~\</conjecture>~ That did not work. </details> <hr> If that doesn't work, then we'll probably need something like `"icon": { "light": "foo.png", "dark": "bar.png" }`, the same as colorscheme We may also want to consider what it means to make the icon a part of the "appearance", and what the matrix of options that entails.
claunia commented 2026-01-31 06:53:29 +00:00
Author
Owner
Copy Link

@Nantris commented on GitHub (May 6, 2023):

I'm not sure if this is already supported but it would also be nice to have per-profile color schemes light vs dark. That would probably constitute the last thing I'd suggest should definitely be configurable per OS-theme mode.

@Nantris commented on GitHub (May 6, 2023): I'm not sure if this is already supported but it would also be nice to have per-profile color schemes light vs dark. That would probably constitute the last thing I'd suggest should definitely be configurable per OS-theme mode.
claunia commented 2026-01-31 06:53:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 11, 2023):

@Slapbox That is something already supported in 1.17 https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#color-scheme 😄

@zadjii-msft commented on GitHub (May 11, 2023): @Slapbox That is something already supported in 1.17 https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#color-scheme 😄
claunia commented 2026-01-31 06:53:30 +00:00
Author
Owner
Copy Link

@Nantris commented on GitHub (May 12, 2023):

@zadjii-msft thanks for the tip! Looking forward to the possibility of icons as well!

@Nantris commented on GitHub (May 12, 2023): @zadjii-msft thanks for the tip! Looking forward to the possibility of icons as well!
claunia commented 2026-01-31 06:53:31 +00:00
Author
Owner
Copy Link

@Nantris commented on GitHub (May 12, 2023):

@zadjii-msft sorry for the follow-up notification; I was wondering how long new versions usually remain in preview before they're pushed via Windows Update? I noticed the latest preview version has been out since January but it's still in preview now.

@Nantris commented on GitHub (May 12, 2023): @zadjii-msft sorry for the follow-up notification; I was wondering how long new versions usually remain in preview before they're pushed via Windows Update? I noticed the latest preview version has been out since January but it's still in preview now.
claunia commented 2026-01-31 06:53:31 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 12, 2023):

@zadjii-msft sorry for the follow-up notification; I was wondering how long new versions usually remain in preview before they're pushed via Windows Update? I noticed the latest preview version has been out since January but it's still in preview now.

Ah! We switched to a quarterly release cycle for both Preview and Stable this year, but we're still evaluating whether to speed up Preview releases or offer another channel (like "Canary" or "Nightly"). We're timing the coming preview release to line up with one of Microsoft's famed developer conferences, so it's delayed a bit more than usual. That said, it's also bigger than usual... so 🤷🏻

@DHowett commented on GitHub (May 12, 2023): > @zadjii-msft sorry for the follow-up notification; I was wondering how long new versions usually remain in preview before they're pushed via Windows Update? I noticed the latest preview version has been out since January but it's still in preview now. Ah! We switched to a _quarterly_ release cycle for both Preview and Stable this year, but we're still evaluating whether to speed up Preview releases or offer another channel (like "Canary" or "Nightly"). We're timing the coming preview release to line up with one of Microsoft's famed developer conferences, so it's delayed a bit more than usual. That said, it's also bigger than usual... so 🤷🏻
claunia commented 2026-01-31 06:53:32 +00:00
Author
Owner
Copy Link

@Nantris commented on GitHub (Nov 15, 2024):

I wonder if per-mode icons are a possibility now. Based on the docs I think no?

@Nantris commented on GitHub (Nov 15, 2024): I wonder if per-mode icons are a possibility now. Based on the docs I think no?
claunia commented 2026-01-31 06:53:32 +00:00
Author
Owner
Copy Link

@Nantris commented on GitHub (Nov 21, 2024):

Friendly bump. This would be a really nice polish feature!

@Nantris commented on GitHub (Nov 21, 2024): Friendly bump. This would be a really nice polish feature!
claunia commented 2026-01-31 06:53:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 21, 2024):

FWIW this is probably pretty far down the team's own backlog, considering there aren't any 👍's.

I think I'd be fine accepting a contribution that allows an object with a pair of light & dark icons, ala https://github.com/microsoft/terminal/issues/15264#issuecomment-1533786192. I can give pointers if anyone's interested.

@zadjii-msft commented on GitHub (Nov 21, 2024): FWIW this is probably pretty far down the team's own backlog, considering there aren't any 👍's. I think I'd be fine accepting a contribution that allows an object with a pair of `light` & `dark` icons, ala https://github.com/microsoft/terminal/issues/15264#issuecomment-1533786192. I can give pointers if anyone's interested.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19782
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?