starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

. #19836

New Issue
Closed
opened 2026-01-31 06:54:55 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:54:55 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (May 8, 2023).

Originally created by @ghost on GitHub (May 8, 2023).
claunia commented 2026-01-31 06:54:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2023):

Which line of code exactly/?

10c6206bfe/src/cascadia/TerminalControl/TermControl.cpp (L859)
10c6206bfe/src/cascadia/TerminalControl/TermControl.cpp (L864)
10c6206bfe/src/cascadia/TerminalControl/TermControl.cpp (L868)

None of those have hstrings on them, and I can't repro this on main, at least, not in a VS build

@zadjii-msft commented on GitHub (May 8, 2023): Which line of code exactly/? https://github.com/microsoft/terminal/blob/10c6206bfef7d045347327687266832931f47eb6/src/cascadia/TerminalControl/TermControl.cpp#L859 https://github.com/microsoft/terminal/blob/10c6206bfef7d045347327687266832931f47eb6/src/cascadia/TerminalControl/TermControl.cpp#L864 https://github.com/microsoft/terminal/blob/10c6206bfef7d045347327687266832931f47eb6/src/cascadia/TerminalControl/TermControl.cpp#L868 None of those have `hstring`s on them, and I can't repro this on `main`, at least, not in a VS build
claunia commented 2026-01-31 06:54:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 9, 2023):

Ah, I missed an important bit that this is on the latest compiler version. This is also tracked internally at devdiv:1810844, though it's by design. Looks like we basically need to convert these to

message = winrt::hstring{ fmt::format(std::wstring_view{ RS_(L"PixelShaderCompileFailed") }) };
@zadjii-msft commented on GitHub (May 9, 2023): Ah, I missed an important bit that this is on the latest compiler version. This is also tracked internally at [devdiv:1810844](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1810844), though it's by design. Looks like we basically need to convert these to ```c++ message = winrt::hstring{ fmt::format(std::wstring_view{ RS_(L"PixelShaderCompileFailed") }) }; ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted In-PR Issue-Bug Needs-Tag-Fix Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19836
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?