starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

persistedWindowLayout does not preserve tab titles #19877

New Issue
Closed
opened 2026-01-31 06:56:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:56:07 +00:00
Owner
Copy Link

Originally created by @Vampire on GitHub (May 15, 2023).

Windows Terminal version

1.16.10261.0

Windows build number

10.0.19045 Build 19045

Other Software

No response

Steps to reproduce

  • have firstWindowPreference set to persistedWindowLayout
  • have a state.json with some tabs defined that have custom manually set tab titles
  • start terminal, the tabs get properly restored
  • use the terminal for some time
  • have a look at state.json

Things that might maybe be relevant additionally:

  • the restored window is in quake-mode and after terminal restart I once disable focus mode manually
  • the profile I use for all those tabs is "Git Bash", but with tabTitle set to bash

Expected Behavior

The custom tab titles are preserved

Actual Behavior

All tab titles are reset to bash.

Originally created by @Vampire on GitHub (May 15, 2023). ### Windows Terminal version 1.16.10261.0 ### Windows build number 10.0.19045 Build 19045 ### Other Software _No response_ ### Steps to reproduce - have `firstWindowPreference` set to `persistedWindowLayout` - have a `state.json` with some tabs defined that have custom manually set tab titles - start terminal, the tabs get properly restored - use the terminal for some time - have a look at `state.json` Things that might maybe be relevant additionally: - the restored window is in quake-mode and after terminal restart I once disable focus mode manually - the profile I use for all those tabs is "Git Bash", but with `tabTitle` set to `bash` ### Expected Behavior The custom tab titles are preserved ### Actual Behavior All tab titles are reset to `bash`.
claunia commented 2026-01-31 06:56:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 17, 2023):

Could you share your settings.json file, and the state.json/?

My theory was that:

  • there's a profile.tabTitle,
  • but we for some reason preserve "tabTitle": "", like, because the runtime title is empty
  • when we go build the NewTerminalArgs for the state restore, use the tabTitle with the empty string from the state.json
  • we evaluate the NewTerminalArgs.TabTitle as an empty string then go use the profile.name instead of the profile.tabTitle

but looking at my state.json, I do have some tabTitles that match the profile's. Maybe your raw jsons will help figure this out.

@zadjii-msft commented on GitHub (May 17, 2023): Could you share your [settings.json file](https://github.com/microsoft/terminal/wiki/Frequently-Asked-Questions-(FAQ)#where-can-i-find-the-settings-file), and the `state.json`/? My theory was that: * there's a `profile.tabTitle`, * but we for some reason preserve `"tabTitle": ""`, like, because the _runtime_ title is empty * when we go build the `NewTerminalArgs` for the state restore, use the `tabTitle` with the empty string from the state.json * we evaluate the `NewTerminalArgs.TabTitle` as an empty string then go use the profile.name instead of the `profile.tabTitle` but looking at my `state.json`, I do have some `tabTitle`s that match the profile's. Maybe your raw jsons will help figure this out.
claunia commented 2026-01-31 06:56:09 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:56:09 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:56:09 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:56:10 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (May 22, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Author-Feedback No-Recent-Activity Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?