starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Copy text without dismissing the selection #19892

New Issue
Closed
opened 2026-01-31 06:56:33 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 06:56:33 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 17, 2023).

In Notepad, if there is a selection, pressing Ctrl+C, the text will be copied to the clipboard, otherwise nothing happens. This is the same in other edit boxes and controls
...
I would like Terminal/PowerShell to behave exactly like Notepad

This seems like a reasonable property to add to the copy action.

class CopyActionArgs {
  singleLine: bool = false;
  copyFormatting = false;
  dismissSelection: bool = false;
}

Originally suggested by @gaberiel44 in https://github.com/microsoft/terminal/discussions/15349

Note

Walkthrough

  • Add a Boolean DismissSelection to CopyTextArgs in src\cascadia\TerminalSettingsModel\ActionArgs.idl
  • Add DismissSelection to COPY_TEXT_ARGS in ActionArgs.h
  • The actual copy args are retrieved in TerminalPage::_HandleCopyText (in AppActionHandlers.cpp), and passed to TerminalPage::_CopyText, which calls down to TermControl::CopySelectionToClipboard.
    • In CopySelectionToClipboard, just don't ClearSelection.
  • This arg will also need localization, in ActionArgs.cpp, CopyTextArgs::GenerateName, and src\cascadia\TerminalSettingsModel\Resources\en-US\Resources.resw
Originally created by @zadjii-msft on GitHub (May 17, 2023). > In Notepad, if there is a selection, pressing Ctrl+C, the text will be copied to the clipboard, otherwise nothing happens. This is the same in other edit boxes and controls > ... > I would like Terminal/PowerShell to behave exactly like Notepad This seems like a reasonable property to add to the `copy` action. ```ts class CopyActionArgs { singleLine: bool = false; copyFormatting = false; dismissSelection: bool = false; } ``` _Originally suggested by @gaberiel44 in https://github.com/microsoft/terminal/discussions/15349_ > **Note** > ## Walkthrough * Add a `Boolean DismissSelection` to `CopyTextArgs` in `src\cascadia\TerminalSettingsModel\ActionArgs.idl` * Add `DismissSelection` to `COPY_TEXT_ARGS` in `ActionArgs.h` * The actual copy args are retrieved in `TerminalPage::_HandleCopyText` (in `AppActionHandlers.cpp`), and passed to `TerminalPage::_CopyText`, which calls down to `TermControl::CopySelectionToClipboard`. * In `CopySelectionToClipboard`, just don't `ClearSelection`. * This arg will also need localization, in `ActionArgs.cpp`, `CopyTextArgs::GenerateName`, and `src\cascadia\TerminalSettingsModel\Resources\en-US\Resources.resw`
claunia commented 2026-01-31 06:56:36 +00:00
Author
Owner
Copy Link

@horrificCoder commented on GitHub (May 18, 2023):

@zadjii-msft Can I work on this?

@horrificCoder commented on GitHub (May 18, 2023): @zadjii-msft Can I work on this?
claunia commented 2026-01-31 06:56:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 18, 2023):

Absolutely!

@zadjii-msft commented on GitHub (May 18, 2023): Absolutely!
claunia commented 2026-01-31 06:56:36 +00:00
Author
Owner
Copy Link

@Sayan505 commented on GitHub (May 18, 2023):

I've got a fix working. I've removed _core.ClearSelection(); from TermControl.cpp which leads to the intended behaviour. Is this correct?
Looking for feedback on my first ever PR on GitHub. https://github.com/microsoft/terminal/pull/15383

@Sayan505 commented on GitHub (May 18, 2023): I've got a fix working. I've removed `_core.ClearSelection();` from `TermControl.cpp` which leads to the intended behaviour. Is this correct? Looking for feedback on my first ever PR on GitHub. https://github.com/microsoft/terminal/pull/15383
claunia commented 2026-01-31 06:56:37 +00:00
Author
Owner
Copy Link

@Sayan505 commented on GitHub (May 20, 2023):

@zadjii-msft Hi, could you please explain me the point of bool dismissSelection?

@Sayan505 commented on GitHub (May 20, 2023): @zadjii-msft Hi, could you please explain me the point of `bool dismissSelection`?
claunia commented 2026-01-31 06:56:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 23, 2023):

could you please explain me the point of bool dismissSelection?

Sure - by making this a setting, then users can choose which behavior they want. They could even have both! Like, a user could have the following settings:

"actions":
[
    { "keys": "ctrl+c", "command": { "action": "copy", "dismissSelection": "true" }, },
    { "keys": "ctrl+d", "command": { "action": "copy", "dismissSelection": "false" }, },
]

And then

  • ctrl+c would copy and dismiss the selection (as it currently does)
  • ctrl+d would copy and leave the selection unchanged (as in Notepad et al.)

Or a user could just rebind ctrl+c to "action": "copy", "dismissSelection": "false", or whatever!

Does that make sense?

@zadjii-msft commented on GitHub (May 23, 2023): > could you please explain me the point of `bool dismissSelection`? Sure - by making this a setting, then users can choose which behavior they want. They could even have both! Like, a user could have the following settings: ```json "actions": [ { "keys": "ctrl+c", "command": { "action": "copy", "dismissSelection": "true" }, }, { "keys": "ctrl+d", "command": { "action": "copy", "dismissSelection": "false" }, }, ] ``` And then * <kbd>ctrl+c</kbd> would copy and dismiss the selection (as it currently does) * <kbd>ctrl+d</kbd> would copy and leave the selection unchanged (as in Notepad et al.) Or a user could just rebind <kbd>ctrl+c</kbd> to `"action": "copy", "dismissSelection": "false"`, or whatever! Does that make sense?
claunia commented 2026-01-31 06:56:37 +00:00
Author
Owner
Copy Link

@code-krishna commented on GitHub (May 28, 2023):

@zadjii-msft can I kindly work on this issue?

@code-krishna commented on GitHub (May 28, 2023): @zadjii-msft can I kindly work on this issue?
claunia commented 2026-01-31 06:56:37 +00:00
Author
Owner
Copy Link

@Delano5000 commented on GitHub (Jun 16, 2023):

@/class CopyActionArgs {
singleLine: bool = false;
copyFormatting = false;
dismissSelection: bool = false;
}

@Delano5000 commented on GitHub (Jun 16, 2023): @/class CopyActionArgs { singleLine: bool = false; copyFormatting = false; dismissSelection: bool = false; }
claunia commented 2026-01-31 06:56:38 +00:00
Author
Owner
Copy Link

@rifat01mahmud commented on GitHub (Jun 19, 2023):

function copyText() {
var selectedText = window.getSelection().toString();
var tempInput = document.createElement("textarea");
tempInput.value = selectedText;
document.body.appendChild(tempInput);
tempInput.select();
document.execCommand("copy");
document.body.removeChild(tempInput);
}

// Call the function when the copy button or any trigger event is activated
copyText();

Rifat Mahmud (Ovronormal)

@rifat01mahmud commented on GitHub (Jun 19, 2023): function copyText() { var selectedText = window.getSelection().toString(); var tempInput = document.createElement("textarea"); tempInput.value = selectedText; document.body.appendChild(tempInput); tempInput.select(); document.execCommand("copy"); document.body.removeChild(tempInput); } // Call the function when the copy button or any trigger event is activated copyText(); Rifat Mahmud (Ovronormal)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-TerminalControl good first issue Help Wanted In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?