starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Using a soft font causes the Atlas engine to crash #19933

New Issue
Closed
opened 2026-01-31 06:57:51 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:57:51 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 23, 2023).

Windows Terminal version

1.18.1421.0

Windows build number

10.0.19045.2913

Other Software

No response

Steps to reproduce

  1. Make sure the Atlas engine is activated in the Advanced profile settings.
  2. Open a bash shell.
  3. Execute printf "\eP0;1;1;4;2;1{B~~~~~~~~/~~~~~~~~\e\\"

Expected Behavior

Most characters output at this point should be reverse question marks, except for ! which should map to a solid block.

Actual Behavior

The terminal crashes. This is caused by a null pointer reference when accessing the fontFaceEntry.fontFace field in BackendD3D::_initializeFontFaceEntry.

c589784b54/src/renderer/atlas/BackendD3D.cpp (L1158)

Just based on a brief scan of the code, I got the impression that it's expected for the fontFace to be null when you have a soft font, so it may just be that this method hasn't allowed for that case. This appears to be a regression introduced in PR #15343.

Originally created by @j4james on GitHub (May 23, 2023). ### Windows Terminal version 1.18.1421.0 ### Windows build number 10.0.19045.2913 ### Other Software _No response_ ### Steps to reproduce 1. Make sure the Atlas engine is activated in the Advanced profile settings. 2. Open a bash shell. 3. Execute `printf "\eP0;1;1;4;2;1{B~~~~~~~~/~~~~~~~~\e\\"` ### Expected Behavior Most characters output at this point should be reverse question marks, except for `!` which should map to a solid block. ### Actual Behavior The terminal crashes. This is caused by a null pointer reference when accessing the `fontFaceEntry.fontFace` field in `BackendD3D::_initializeFontFaceEntry`. https://github.com/microsoft/terminal/blob/c589784b54d46187289651fa6c04c49fe05826aa/src/renderer/atlas/BackendD3D.cpp#L1158 Just based on a brief scan of the code, I got the impression that it's expected for the `fontFace` to be null when you have a soft font, so it may just be that this method hasn't allowed for that case. This appears to be a regression introduced in PR #15343.
claunia commented 2026-01-31 06:57:54 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 23, 2023):

Ah dang I didn't test it again after the PR. 😟 Sorry for breaking it, and thank you so much for noticing it!
(#15343 was written in a bit... a lot of a hurry. 😅)

@lhecker commented on GitHub (May 23, 2023): Ah dang I didn't test it again after the PR. 😟 Sorry for breaking it, and thank you so much for noticing it! (#15343 was written in a bit... a lot of a hurry. 😅)
claunia commented 2026-01-31 06:57:55 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 25, 2023):

FYI the link I distributed in some other comments (click) is a build that also contains the PR that fixes this. If you're eager to test it out, you could consider installing that build. 🙂

@lhecker commented on GitHub (May 25, 2023): FYI the link I distributed in some other comments ([click](https://blob.hecker.io/sharex/Microsoft.WindowsTerminalPreview_1.18.1443.0_8wekyb3d8bbwe.msixbundle)) is a build that also contains the PR that fixes this. If you're eager to test it out, you could consider installing that build. 🙂
claunia commented 2026-01-31 06:57:55 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 25, 2023):

I've patched my local build with the changes in your PR and it's working great now. Thanks!

@j4james commented on GitHub (May 25, 2023): I've patched my local build with the changes in your PR and it's working great now. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-AtlasEngine In-PR Issue-Bug Needs-Triage Priority-1 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19933
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?