starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Something wrong with colors #19942

New Issue
Closed
opened 2026-01-31 06:58:08 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:58:08 +00:00
Owner
Copy Link

Originally created by @237dmitry on GitHub (May 24, 2023).

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621

Other Software

pwsh, far

Steps to reproduce

Look at screenshots. On the left WT, on the right conhost. In the previous preview all worked as expected.

in Far.exe:
Screenshot 2023-05-24 095709

In pwsh.exe

"`n`e[48;5;23;38;5;208m  `u{e0b6}`e[48;5;208m     `e[48;5;23;38;5;208m`u{e0b4}  `e[0m`n"

Screenshot 2023-05-24 101222

Screenshot 2023-05-24 103143

Expected Behavior

The colors should be identical.

Actual Behavior

The colors in some applications started wrong after last preview update (up to 1.18.1421.0)

Originally created by @237dmitry on GitHub (May 24, 2023). ### Windows Terminal version 1.18.1421.0 ### Windows build number 10.0.22621 ### Other Software pwsh, far ### Steps to reproduce Look at screenshots. On the left WT, on the right conhost. In the previous preview all worked as expected. in Far.exe: ![Screenshot 2023-05-24 095709](https://github.com/microsoft/terminal/assets/78153320/54b7a646-c5bd-421b-bc14-9cca0f21b02c) In pwsh.exe ``` "`n`e[48;5;23;38;5;208m `u{e0b6}`e[48;5;208m `e[48;5;23;38;5;208m`u{e0b4} `e[0m`n" ``` ![Screenshot 2023-05-24 101222](https://github.com/microsoft/terminal/assets/78153320/dae9f0ae-8f41-4741-8090-08fa071990dc) ![Screenshot 2023-05-24 103143](https://github.com/microsoft/terminal/assets/78153320/dfa33349-0c7f-4aa6-a54f-654d05f3ecc3) ### Expected Behavior The colors should be identical. ### Actual Behavior The colors in some applications started wrong after last preview update (up to 1.18.1421.0)
claunia commented 2026-01-31 06:58:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2023):

I'd guess that this is the "automatically adjust colors" setting - Could you share your settings.json file/?

@zadjii-msft commented on GitHub (May 24, 2023): I'd guess that this is the "automatically adjust colors" setting - Could you share your [settings.json file](https://github.com/microsoft/terminal/wiki/Frequently-Asked-Questions-(FAQ)#where-can-i-find-the-settings-file)/?
claunia commented 2026-01-31 06:58:10 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 24, 2023):

If it is the color adjustment (it probably is), it's because the new color contrasting function is more aggressive than the old one. You can see why in this comment for instance: https://github.com/microsoft/terminal/pull/15283#issuecomment-1533598464

It's mostly a coincidence that the old code didn't change the color of your powerline glyphs, because we lack a fix to avoid adjusting them, similar to how VS Code avoids it: 7a7f4f0add/src/browser/renderer/shared/RendererUtils.ts (L30-L32)

The menu in the far manager screenshot has a background color of #2a838a which is oklab(0.56 -0.1 0) and a foreground color of #ffffff which is oklab(1 0 0). The distance between the two is sqrt(0.44^2 + 0.1^2 + 0^2) which is 0.45. We currently set a minimum distance of 0.5 here: c589784b54/src/renderer/base/RenderSettings.cpp (L185)

It would be nice to make that configurable.

@lhecker commented on GitHub (May 24, 2023): If it is the color adjustment (it probably is), it's because the new color contrasting function is more aggressive than the old one. You can see why in this comment for instance: https://github.com/microsoft/terminal/pull/15283#issuecomment-1533598464 It's mostly a coincidence that the old code didn't change the color of your powerline glyphs, because we lack a fix to avoid adjusting them, similar to how VS Code avoids it: https://github.com/xtermjs/xterm.js/blob/7a7f4f0add397075e31505e3c3fc237856604cb3/src/browser/renderer/shared/RendererUtils.ts#L30-L32 The menu in the far manager screenshot has a background color of `#2a838a` which is `oklab(0.56 -0.1 0)` and a foreground color of `#ffffff` which is `oklab(1 0 0)`. The distance between the two is `sqrt(0.44^2 + 0.1^2 + 0^2)` which is 0.45. We currently set a minimum distance of 0.5 here: https://github.com/microsoft/terminal/blob/c589784b54d46187289651fa6c04c49fe05826aa/src/renderer/base/RenderSettings.cpp#L185 It would be nice to make that configurable.
claunia commented 2026-01-31 06:58:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2023):

It would be nice to make that configurable

which we're tracking in #14940

@zadjii-msft commented on GitHub (May 24, 2023): > It would be nice to make that configurable which we're tracking in #14940
claunia commented 2026-01-31 06:58:11 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (May 24, 2023):

Thank you for advice, I changed: "adjustIndistinguishableColors": "never", and colors was returned to normal.

@237dmitry commented on GitHub (May 24, 2023): Thank you for advice, I changed: `"adjustIndistinguishableColors": "never",` and colors was returned to normal.
claunia commented 2026-01-31 06:58:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2023):

Right on. That answers that!

@zadjii-msft commented on GitHub (May 24, 2023): Right on. That answers that!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Issue-Question Needs-Attention Needs-Triage Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19942
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?