starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Drop-down options in Settings always follow system theme #19953

New Issue
Open
opened 2026-01-31 06:58:29 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:58:29 +00:00
Owner
Copy Link

Originally created by @bzzrak on GitHub (May 25, 2023).

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621.1702

Other Software

No response

Steps to reproduce

  1. set the WT theme to be the opposite of your system theme. In my case, system theme is light but Terminal is set to dark.
  2. open Settings
  3. click any option that has a drop-down.

Expected Behavior

The application theme is followed, in my case dark.

Actual Behavior

The system theme is followed, in my case light
(on the right is the Settings app showing that my system theme is light.)
image
image

Originally created by @bzzrak on GitHub (May 25, 2023). ### Windows Terminal version 1.18.1421.0 ### Windows build number 10.0.22621.1702 ### Other Software _No response_ ### Steps to reproduce 1. set the WT theme to be the opposite of your system theme. In my case, system theme is light but Terminal is set to dark. 2. open Settings 3. click any option that has a drop-down. ### Expected Behavior The application theme is followed, in my case dark. ### Actual Behavior The system theme is followed, in my case light (on the right is the Settings app showing that my system theme is light.) <img width="700" alt="image" src="https://github.com/microsoft/terminal/assets/77467869/b5837f22-a80a-4b09-b469-a715abb9c1b8"> <img width="400" alt="image" src="https://github.com/microsoft/terminal/assets/77467869/9419d25d-cef7-41d8-b937-65be9c4ac073">
claunia added the Help WantedIssue-BugProduct-TerminalArea-SettingsUI labels 2026-01-31 06:58:30 +00:00
claunia commented 2026-01-31 06:58:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 31, 2023):

I'm sure this is one of the many "we need to iterate through the XAML tree and the popup root to set the theme too" bugs we've dealt with for... basically forever. There's other similar issues scattered across the repo.

@zadjii-msft commented on GitHub (May 31, 2023): I'm sure this is one of the many "we need to iterate through the XAML tree and the popup root to set the theme too" bugs we've dealt with for... basically forever. There's other similar issues scattered across the repo.
claunia commented 2026-01-31 06:58:31 +00:00
Author
Owner
Copy Link

@RickleAndMortimer commented on GitHub (Aug 13, 2023):

May I take a look into this issue?

@RickleAndMortimer commented on GitHub (Aug 13, 2023): May I take a look into this issue?
claunia commented 2026-01-31 06:58:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 6, 2024):

@RickleAndMortimer Sorry about that! I must've missed that comment before. Please, always feel free to start on whatever ☺️

https://github.com/microsoft/terminal/pull/9732 might have some pointers of the right direction to investigate. Basically, anything that's a Popup doesn't share the same XAML root as the rest of the app, so we need to apply the RequestedTheme to popups manually 🙃

@zadjii-msft commented on GitHub (Feb 6, 2024): @RickleAndMortimer Sorry about that! I must've missed that comment before. Please, always feel free to start on whatever ☺️ https://github.com/microsoft/terminal/pull/9732 might have some pointers of the right direction to investigate. Basically, anything that's a `Popup` doesn't share the same XAML root as the rest of the app, so we need to apply the `RequestedTheme` to popups manually 🙃
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?