starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Can we drop the telemetry for VT sequences? #20011

New Issue
Closed
opened 2026-01-31 07:00:30 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:00:30 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 30, 2023).

Originally assigned to: @j4james on GitHub.

Description of the new feature/enhancement

We've now reached the point that if we add another VT sequence to the telemetry tracker, the TraceLoggingWriteActivity call will fail to compile. I'm not exactly sure what the problem is, but the initial warning/error is: pasting '_tlg_FOR_imp' and '(' does not result in a valid preprocessing token, after which there are another 20 or so lines of errors.

It's possible there is a way to work around that, but if we don't really need this telemetry, it would be nicer if we could just drop it altogether. And maybe that will save a bit of parsing overhead in the process.

Proposed technical implementation details (optional)

Drop the TermTelemetry class, and then remove all code that was making calls to it.

Originally created by @j4james on GitHub (May 30, 2023). Originally assigned to: @j4james on GitHub. # Description of the new feature/enhancement We've now reached the point that if we add another VT sequence to the telemetry tracker, the `TraceLoggingWriteActivity` call will fail to compile. I'm not exactly sure what the problem is, but the initial warning/error is: `pasting '_tlg_FOR_imp' and '(' does not result in a valid preprocessing token`, after which there are another 20 or so lines of errors. It's possible there is a way to work around that, but if we don't really need this telemetry, it would be nicer if we could just drop it altogether. And maybe that will save a bit of parsing overhead in the process. # Proposed technical implementation details (optional) Drop the `TermTelemetry` class, and then remove all code that was making calls to it.
claunia added the Help WantedIssue-TaskIn-PRNeeds-Tag-FixProduct-MetaPriority-2 labels 2026-01-31 07:00:31 +00:00
claunia commented 2026-01-31 07:00:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 30, 2023):

I'm all for it. This was more valuable when we like, hardly implemented any sequences. I don't think this is even hooked up to anything at this point.

@zadjii-msft commented on GitHub (May 30, 2023): I'm all for it. This was more valuable when we like, hardly implemented any sequences. I don't think this is even hooked up to anything at this point.
claunia commented 2026-01-31 07:00:33 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 30, 2023):

YES. PLEASE. Thank you!

@DHowett commented on GitHub (May 30, 2023): YES. PLEASE. Thank you!
claunia commented 2026-01-31 07:00:33 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 30, 2023):

The way we implemented this telemetry is wrong, anyway - TraceLogging is supposed to be zero-cost if it is not enabled, so every time we put the log behind a function call we're wasting a branch and likely cache fault to determine we aren't supposed to be doing anything.

@DHowett commented on GitHub (May 30, 2023): The way we implemented this telemetry is wrong, anyway - `TraceLogging` is supposed to be zero-cost if it is not enabled, so every time we put the log behind a function call we're wasting a branch and likely cache fault to determine we aren't supposed to be doing anything.
claunia commented 2026-01-31 07:00:33 +00:00
Author
Owner
Copy Link

@bishalkar10 commented on GitHub (May 30, 2023):

I am very new to programming. I am confused how can I contribute to open source. I am proficient in html, css, javascript and learning react now. Can I contribute somehow?

@bishalkar10 commented on GitHub (May 30, 2023): I am very new to programming. I am confused how can I contribute to open source. I am proficient in html, css, javascript and learning react now. Can I contribute somehow?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Help Wanted In-PR Issue-Task Needs-Tag-Fix Priority-2 Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20011
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?