starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Black powerline / nerd font glyphs #20014

New Issue
Closed
opened 2026-01-31 07:00:42 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 07:00:42 +00:00
Owner
Copy Link

Originally created by @withinboredom on GitHub (May 31, 2023).

Originally assigned to: @DHowett on GitHub.

Windows Terminal version

1.18.1462.0

Windows build number

10.0.22621.0

Other Software

Zsh -- powerlevel10k theme (WSL): https://github.com/romkatv/powerlevel10k

Font: MesloLGS NF

Steps to reproduce

Between 1.16.10262.0 and the reported version, something changed in the renderer causing fonts to render differently. This appears to be minor, though perhaps could make other languages (with non-latin alphabets) harder to read.

Previous:

image

Current:

image

Note the cutoff on the slashed characters.

The best way to reproduce this is to start the p10k configure command to have it present many different renderings with a strange font.

Expected Behavior

For characters to be rendered as expected.

Actual Behavior

Some characters appear to be rendered incorrectly.

Originally created by @withinboredom on GitHub (May 31, 2023). Originally assigned to: @DHowett on GitHub. ### Windows Terminal version 1.18.1462.0 ### Windows build number 10.0.22621.0 ### Other Software Zsh -- powerlevel10k theme (WSL): https://github.com/romkatv/powerlevel10k Font: MesloLGS NF ### Steps to reproduce Between 1.16.10262.0 and the reported version, something changed in the renderer causing fonts to render differently. This appears to be minor, though perhaps could make other languages (with non-latin alphabets) harder to read. Previous: <img width="841" alt="image" src="https://github.com/microsoft/terminal/assets/1883296/bd325456-344d-4367-884f-bb02d26ecdba"> Current: <img width="860" alt="image" src="https://github.com/microsoft/terminal/assets/1883296/6b474900-4f75-47e8-91dc-625f8f287341"> Note the cutoff on the slashed characters. The best way to reproduce this is to start the `p10k configure` command to have it present many different renderings with a strange font. ### Expected Behavior For characters to be rendered as expected. ### Actual Behavior Some characters appear to be rendered incorrectly.
claunia added the Needs-TriageIssue-BugNeeds-Attention labels 2026-01-31 07:00:43 +00:00
claunia commented 2026-01-31 07:00:44 +00:00
Author
Owner
Copy Link

@withinboredom commented on GitHub (May 31, 2023):

Originally reported in a comment: https://github.com/microsoft/terminal/issues/15416#issuecomment-1570783205

@withinboredom commented on GitHub (May 31, 2023): Originally reported in a comment: https://github.com/microsoft/terminal/issues/15416#issuecomment-1570783205
claunia commented 2026-01-31 07:00:44 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 31, 2023):

Like this?
image

That doesn't seem wrong to me. Can you please describe what font family and what order of 1234/y/n presses I have to use to arrive at a prompt in p10k configure that reproduces the issue?

@lhecker commented on GitHub (May 31, 2023): Like this? ![image](https://github.com/microsoft/terminal/assets/2256941/f37903e5-cfca-4127-8eb8-0a91b457b48e) That doesn't seem wrong to me. Can you please describe what font family and what order of 1234/y/n presses I have to use to arrive at a prompt in `p10k configure` that reproduces the issue?
claunia commented 2026-01-31 07:00:45 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 31, 2023):

I think it's this:
image

Can you try turning off "Adjust lightness of indistinguishable text"?

@DHowett commented on GitHub (May 31, 2023): I think it's this: <img width="38" alt="image" src="https://github.com/microsoft/terminal/assets/189190/ae94fca3-6070-4484-9a24-c9d57b763854"> Can you try turning off "Adjust lightness of indistinguishable text"?
claunia commented 2026-01-31 07:00:45 +00:00
Author
Owner
Copy Link

@thijsputman commented on GitHub (Jun 2, 2023):

It appears I'm running into a related issue (either to this, or #15416) when rendering this character in the terminal:

▔ (U+2594)

When trying to display this character, nothing is shown. Worked fine in the past; noticed the issue a couple days ago.

When I disable the AtlasEngine, the character shows up as intended.

The issue only occurs when using Cascadia Code PL, not with (for example) Consolas. Not sure if it matters, but my font size is set to 10 and line height to 1.2.

Running the latest preview build (v1.18.1462.0).

@thijsputman commented on GitHub (Jun 2, 2023): It appears I'm running into a related issue (either to this, or #15416) when rendering this character in the terminal: ``` ▔ (U+2594) ``` When trying to display this character, nothing is shown. Worked fine in the past; noticed the issue a couple days ago. When I _disable_ the `AtlasEngine`, the character shows up as intended. The issue only occurs when using `Cascadia Code PL`, _not_ with (for example) `Consolas`. Not sure if it matters, but my font size is set to 10 and line height to 1.2. Running the latest preview build ([v1.18.1462.0](https://github.com/microsoft/terminal/releases/tag/v1.18.1462.0)).
claunia commented 2026-01-31 07:00:45 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 2, 2023):

That is definitely not the same issue, but I do know what it is.

@lhecker U+2594 is completely outside the cell in Cascadia Code.

This could be argued to be a font bug.

image

The lighted cell is a selection (1x cell height); U+2594 is to the left of it.

We're clipping all box drawing glyphs to keep them inside the cell. . . and deleting the glyph completely in so doing.

@DHowett commented on GitHub (Jun 2, 2023): That is definitely not the same issue, but I do know what it is. @lhecker `U+2594` is completely outside the cell _in Cascadia Code_. This could be argued to be a font bug. <img width="51" alt="image" src="https://github.com/microsoft/terminal/assets/189190/f679638c-f200-4b73-bcd6-e20cc8abaeb0"> The lighted cell is a selection (1x cell height); `U+2594` is to the left of it. We're clipping all box drawing glyphs to keep them inside the cell. . . and deleting the glyph completely in so doing.
claunia commented 2026-01-31 07:00:45 +00:00
Author
Owner
Copy Link

@withinboredom commented on GitHub (Jun 2, 2023):

Turns out it is a relatively easy fix, @DHowett suggested:

image

Things still look a little off, but iff it isn't on the first line:

image

If it is on the very first line of the terminal, the prompt looks correct.

@withinboredom commented on GitHub (Jun 2, 2023): Turns out it is a relatively easy fix, @DHowett suggested: <img width="747" alt="image" src="https://github.com/microsoft/terminal/assets/1883296/5bd9d374-cbcf-4eef-8b32-5792c5bebe27"> Things still look a little off, but iff it isn't on the first line: <img width="110" alt="image" src="https://github.com/microsoft/terminal/assets/1883296/c58ac29c-133a-4d0e-8bfb-38030141ae5b"> If it is on the very first line of the terminal, the prompt looks correct.
claunia commented 2026-01-31 07:00:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 12, 2023):

Hey, to go clean up this thread:

  • The issue in the OP was solved by turning off "Adjust lightness of indistinguishable text", yea?
  • There's a related issue about "clipping box drawing characters" which we may or may not want to keep doing. But that we should track in #15359 (et al)

So, I think we can close this now? Sound good?

@zadjii-msft commented on GitHub (Jul 12, 2023): Hey, to go clean up this thread: * The issue in the OP was solved by turning off "Adjust lightness of indistinguishable text", yea? * There's a related issue about "clipping box drawing characters" which we may or may not want to keep doing. But that we should track in #15359 (et al) So, I _think_ we can close this now? Sound good?
claunia commented 2026-01-31 07:00:46 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 12, 2023):

Yep, I think we can close this now. 🙂
The small inconsistency in the glyph height (https://github.com/microsoft/terminal/issues/15489#issuecomment-1574353691) is most certainly due to rounding errors, etc., caused by the font and font size and not something we have any big influence over.

@lhecker commented on GitHub (Jul 12, 2023): Yep, I think we can close this now. 🙂 The small inconsistency in the glyph height (https://github.com/microsoft/terminal/issues/15489#issuecomment-1574353691) is most certainly due to rounding errors, etc., caused by the font and font size and not something we have any big influence over.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20014
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?