Ignores IF statements in batch #20016

claunia commented

@237dmitry commented on GitHub (Jun 1, 2023):

Your batch file is incorrect. Use setlocal enabledelayedexpansion to set and echo vsriable in one script block.

@Echo off
setlocal enabledelayedexpansion

set "c=%~1%"
IF NOT "%c%"=="" (
  set "c=%c:$=;%"
  echo !c!
)
pause

@237dmitry commented on GitHub (Jun 1, 2023): Your batch file is incorrect. Use `setlocal enabledelayedexpansion` to set and echo vsriable in one script block. ``` @Echo off setlocal enabledelayedexpansion set "c=%~1%" IF NOT "%c%"=="" ( set "c=%c:$=;%" echo !c! ) pause ```

claunia commented

@DHowett commented on GitHub (Jun 2, 2023):

This is really curious! Thanks for filing it!

The issue is pretty clear. WT ignores statements inside of IF statements.

Just to level-set, WT does not change the behavior of CMD.exe. It is not parsing batch files or processing user input or spawning subshells or reading scripts--it only provides a new UI for CLI applications.

I am also unable to reproduce this!

Top - terminal; bottom - conhost; right (for verification) - your batch file.

@DHowett commented on GitHub (Jun 2, 2023): This is really curious! Thanks for filing it! > The issue is pretty clear. WT ignores statements inside of IF statements. Just to level-set, _WT does not change the behavior of CMD.exe_. It is not parsing batch files or processing user input or spawning subshells or reading scripts--it only provides a new UI for CLI applications. I am also unable to reproduce this! ![image](https://github.com/microsoft/terminal/assets/189190/e53349ae-553a-4f67-a47e-9b910b0683a8) Top - terminal; bottom - conhost; right (for verification) - your batch file.

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 6, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented

@jredfox commented on GitHub (Jun 17, 2023):

This is really curious! Thanks for filing it!

The issue is pretty clear. WT ignores statements inside of IF statements.

Just to level-set, WT does not change the behavior of CMD.exe. It is not parsing batch files or processing user input or spawning subshells or reading scripts--it only provides a new UI for CLI applications.

I am also unable to reproduce this!

Top - terminal; bottom - conhost; right (for verification) - your batch file.

$ never got replaced to ; in the output it says 55$23 and not 55;23 aka it never ran inside the if statement.

@jredfox commented on GitHub (Jun 17, 2023): > This is really curious! Thanks for filing it! > > > The issue is pretty clear. WT ignores statements inside of IF statements. > > Just to level-set, _WT does not change the behavior of CMD.exe_. It is not parsing batch files or processing user input or spawning subshells or reading scripts--it only provides a new UI for CLI applications. > > I am also unable to reproduce this! > > ![image](https://user-images.githubusercontent.com/189190/242985609-e53349ae-553a-4f67-a47e-9b910b0683a8.png) > > Top - terminal; bottom - conhost; right (for verification) - your batch file. **$** never got replaced to **`;`** in the output it says `55$23` and not `55;23` aka it never ran inside the if statement.

claunia commented

@jredfox commented on GitHub (Jun 17, 2023):

Edit: the bug now also happens with just cmd.exe. as you can see the value of c doesn't change until after the if statement has executed. Could you report this to cmd.exe people then as it's related to windows terminal?

@Echo off
set c=%~1%
IF NOT "%c%" == "" (
  set c=%c:$=;%
  echo=%c%
)
echo=%c%

@jredfox commented on GitHub (Jun 17, 2023): Edit: the bug now also happens with just `cmd.exe`. as you can see the value of c doesn't change until after the if statement has executed. Could you report this to `cmd.exe` people then as it's related to windows terminal? ``` @Echo off set c=%~1% IF NOT "%c%" == "" ( set c=%c:$=;% echo=%c% ) echo=%c% ```

claunia commented

@237dmitry commented on GitHub (Jun 17, 2023):

as you can see the value of c doesn't change until after the if statement has executed.

You tried to set and view variable changes inside the same script-block (...). This is not working in this way (and never worked).

set /?
setlocal /?

Or if you do not want to use setlocal (disliked my answer) you have to use call instead.

@Echo off
set c=%~1%
IF NOT "%c%" == "" (
  set c=%c:$=;%
  call echo %%c%%
)
echo %c%

@237dmitry commented on GitHub (Jun 17, 2023): > as you can see the value of c doesn't change until after the if statement has executed. You tried to set and view variable changes inside the same script-block `(...)`. This is not working in this way (and never worked). ``` set /? setlocal /? ``` Or if you do not want to use `setlocal` (disliked my answer) you have to use `call` instead. ``` @Echo off set c=%~1% IF NOT "%c%" == "" ( set c=%c:$=;% call echo %%c%% ) echo %c% ```

claunia commented

@DHowett commented on GitHub (Jun 19, 2023):

We're also the cmd.exe people! I can definitely assure you that Terminal cannot change the behavior of cmd outside of interactive mode 😄

It is worth noting that it absolutely did run the code inside the IF block, because that is where it is echoing the contents of %c%.

If it was not running the code inside the IF block, there would be no output.

The code as you've written it requires delayed expansion to be turned on.

Can you share the output of reg query "HKLM\Software\Microsoft\Command Processor"?

@DHowett commented on GitHub (Jun 19, 2023): We're also the cmd.exe people! I can definitely assure you that Terminal cannot change the behavior of cmd outside of interactive mode :smile: It is worth noting that it _absolutely did_ run the code inside the `IF` block, because that is where it is echoing the contents of `%c%`. If it was not running the code inside the `IF` block, there would be no output. The code as you've written it requires delayed expansion to be turned on. Can you share the output of `reg query "HKLM\Software\Microsoft\Command Processor"`?

claunia commented

@DHowett commented on GitHub (Jun 19, 2023):

I would also like to see reg query "HKCU\Software\Microsoft\Command Processor" (the distinction being of course that one is systemwide and one is user-local)

@DHowett commented on GitHub (Jun 19, 2023): I would also like to see `reg query "HKCU\Software\Microsoft\Command Processor"` (the distinction being of course that one is systemwide and one is user-local)

claunia commented

@microsoft-github-policy-service[bot] commented on GitHub (Jun 23, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Jun 23, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.

claunia commented