starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal Preview returns ERROR_FILE_NOT_FOUND when launching relative path #20017

New Issue
Closed
opened 2026-01-31 07:00:50 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:00:50 +00:00
Owner
Copy Link

Originally created by @ChrisKnue-MSFT on GitHub (May 31, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

Attempt to launch a terminal from command line with a relative path for a file to launch. (ex: "wt .\test.ps1")

Expected Behavior

In 1.16.10262.0 this would launch the file

Actual Behavior

[error 2147942402 (0x80070002) when launching .\test.ps1]
is printed in the console.

Originally created by @ChrisKnue-MSFT on GitHub (May 31, 2023). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 1.18.1421.0 ### Windows build number 10.0.22631.0 ### Other Software _No response_ ### Steps to reproduce Attempt to launch a terminal from command line with a relative path for a file to launch. (ex: "wt .\test.ps1") ### Expected Behavior In 1.16.10262.0 this would launch the file ### Actual Behavior [error 2147942402 (0x80070002) when launching `.\test.ps1`] is printed in the console.
claunia added the Issue-BugIn-PRNeeds-Tag-FixProduct-TerminalSeverity-Blocking labels 2026-01-31 07:00:50 +00:00
claunia commented 2026-01-31 07:00:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 31, 2023):

Undoubtably, I broke this in #15280. Or at least, forgot about this scenario 🤦

@zadjii-msft commented on GitHub (May 31, 2023): Undoubtably, I broke this in #15280. Or at least, forgot about this scenario 🤦
claunia commented 2026-01-31 07:00:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 31, 2023):

Hmmmmmm. This is tricky. So we've got a virtual CWD now, and our real CWD is system32.

As an example, cd to d:\dev\tmp, and try to launch foo.exe. In this scenario:

  • when we get to _evaluatePathForCwd in TerminalPage::_CreateConnectionFromSettings, we evaluate (_WindowProperties.VirtualWorkingDirectory(), path) == ("d:\dev\tmp", "") -> `"d:\dev\tmp"'. That's right.
  • But the problem is that we don't CreateProcess then. We CreateProcess in ConptyConnection::Start, which straight up isn't till the TermControl is initialized with XAML.
  • At that point, we CreateProcess("foo.exe",..... "d:\dev\tmp"). But that gives a ERROR_FILE_NOT_FOUND, cause there's no foo.exe in system32.

I wonder if there's a trivial flag to try to load the process from the startingDirectory. Or like, as a fail-safe, fall back to trying the startingDirectory, like, by appending the commandline to that? idk. needs more brainstorming.

@zadjii-msft commented on GitHub (May 31, 2023): Hmmmmmm. This is tricky. So we've got a virtual CWD now, and our real CWD is `system32`. As an example, `cd` to `d:\dev\tmp`, and try to launch `foo.exe`. In this scenario: * when we get to `_evaluatePathForCwd` in `TerminalPage::_CreateConnectionFromSettings`, we evaluate (`_WindowProperties.VirtualWorkingDirectory()`, `path`) == (`"d:\dev\tmp"`, `""`) -> `"d:\dev\tmp"'. That's right. * But the problem is that we don't `CreateProcess` then. We `CreateProcess` in `ConptyConnection::Start`, which straight up isn't till the `TermControl` is initialized with XAML. * At that point, we `CreateProcess("foo.exe",..... "d:\dev\tmp")`. But that gives a `ERROR_FILE_NOT_FOUND`, cause there's no `foo.exe` in `system32`. I wonder if there's a trivial flag to try to load the process from the `startingDirectory`. Or like, as a fail-safe, fall back to trying the `startingDirectory`, like, by appending the `commandline` to that? idk. needs more brainstorming.
claunia commented 2026-01-31 07:00:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 31, 2023):

But it's not just {{startingDirectory}}/{{commandline}}. It's more like the search path has to be {{terminal's vCWD when that connection was created}}/{{commandline}}.

Ew this is hard. Cause we don't know the application that we're calling CreateProcess on. We're just passing the whole commandline, and letting CreateProcess figure it out. We could theoretically, temporarily attempt to have the Terminal cd into the vCwd, and try again. That also feels hacky but hey, that's kinda this whole project

@zadjii-msft commented on GitHub (May 31, 2023): But it's not just `{{startingDirectory}}/{{commandline}}`. It's more like the search path has to be `{{terminal's vCWD when that connection was created}}/{{commandline}}`. Ew this is hard. Cause we don't know the `application` that we're calling `CreateProcess` on. We're just passing the whole commandline, and letting CreateProcess figure it out. We could _theoretically_, temporarily attempt to have the Terminal `cd` into the `vCwd`, and try again. That also feels hacky but hey, that's kinda this whole project
claunia commented 2026-01-31 07:00:52 +00:00
Author
Owner
Copy Link

@ChrisKnue-MSFT commented on GitHub (Jun 1, 2023):

@zadjii-msft We were trying some work arounds (absolute path) and it seems like environment variables are not being passed to the child wt process either. Is there already a bug about that?

@ChrisKnue-MSFT commented on GitHub (Jun 1, 2023): @zadjii-msft We were trying some work arounds (absolute path) and it seems like environment variables are not being passed to the child wt process either. Is there already a bug about that?
claunia commented 2026-01-31 07:00:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 5, 2023):

Talked this over internally - The fix (as in #16028) for this bug is.... unbelievably gross, and probably even incorrect. This is just gonna have to remain a breaking change post-1.18. The workaround being to always pass absolute paths to the wt commandline (which will work on old versions as well as new).

@zadjii-msft commented on GitHub (Dec 5, 2023): Talked this over internally - The fix (as in #16028) for this bug is.... unbelievably gross, and probably even incorrect. This is just gonna have to remain a breaking change post-1.18. The workaround being to always pass absolute paths to the `wt` commandline (which will work on old versions as well as new).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label In-PR Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?