starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

FreeConsole() doesn't work past 5s during CTRL_CLOSE_EVENT #20105

New Issue
Open
opened 2026-01-31 07:03:44 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:03:44 +00:00
Owner
Copy Link

Originally created by @jredfox on GitHub (Jun 17, 2023).

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.3086

Other Software

c++
mingwx64
an ide of your choice
cpu arch: x64

Steps to reproduce

compile this code in c++ and run it.
go to task manager --> open terminal group processes --> program.exe --> go to details
click the x button on windows terminal.
the process of program.exe is no longer running and if you insert a while loop in the handler it closes 5 seconds later. This bug is reproducible with cmd powershell and conhost and windows terminal. I don't know which program issue or issues its on so I am reporting it here

BOOL WINAPI controlHandler(DWORD sig)
{
	if(sig == CTRL_CLOSE_EVENT)
	{
		Beep(800, 500);
		FreeConsole();
		return TRUE;
	}
}
int main()
{
   SetConsoleCtrlHandler(&controlHandler, TRUE);
   while(true);
}

Expected Behavior

the process to stay open

Actual Behavior

process closes

Related Note:

FreeConsole() api doesn't have a parameter of PID and doesn't free all child processes another bug

Originally created by @jredfox on GitHub (Jun 17, 2023). ### Windows Terminal version 1.17.11461.0 ### Windows build number 10.0.19045.3086 ### Other Software c++ mingwx64 an ide of your choice cpu arch: x64 ### Steps to reproduce compile this code in c++ and run it. go to task manager --> open terminal group processes --> program.exe --> go to details click the x button on windows terminal. the process of program.exe is no longer running and if you insert a while loop in the handler it closes 5 seconds later. This bug is reproducible with cmd powershell and conhost and windows terminal. I don't know which program issue or issues its on so I am reporting it here ```c++ BOOL WINAPI controlHandler(DWORD sig) { if(sig == CTRL_CLOSE_EVENT) { Beep(800, 500); FreeConsole(); return TRUE; } } int main() { SetConsoleCtrlHandler(&controlHandler, TRUE); while(true); } ``` ### Expected Behavior the process to stay open ### Actual Behavior process closes ### Related Note: FreeConsole() api doesn't have a parameter of PID and doesn't free all child processes another bug
claunia commented 2026-01-31 07:03:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 19, 2023):

The 5s timeout stems from SPI_GETHUNGAPPTIMEOUT and you cannot prevent the console from killing your process by calling FreeConsole in the SetConsoleCtrlHandler callback. Personally speaking, I'm actively not wishing to fix this right now. It'd be weird if a previously visible console application could keep running indefinitely even after the user closed the window explicitly. It's like the window vanishing on its own when FreeConsole is called, but even worse in a way?

If you ever choose to do hacks like this one I need to point out that they can (and honestly probably will, given enough time) break in the future if we ever choose to not inject threads anymore.

@lhecker commented on GitHub (Jun 19, 2023): The 5s timeout stems from `SPI_GETHUNGAPPTIMEOUT` and you cannot prevent the console from killing your process by calling `FreeConsole` in the `SetConsoleCtrlHandler` callback. Personally speaking, I'm actively not wishing to fix this right now. It'd be weird if a previously visible console application could keep running indefinitely even after the user closed the window explicitly. It's like the window vanishing on its own when `FreeConsole` is called, but even worse in a way? If you ever choose to do hacks like [this one](https://stackoverflow.com/a/18445043) I need to point out that they can (and honestly probably will, given enough time) break in the future if we ever choose to not inject threads anymore.
claunia commented 2026-01-31 07:03:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 21, 2023):

I think we should investigate whether we should support this. If it's easy to implement: Let's just do it! (We'd also accept a PR if it's a simple change.) But we don't really believe that this is an important aspect to fix and implement right now, unless more people request this or if any other circumstances change.

@lhecker commented on GitHub (Jun 21, 2023): I think we should investigate whether we should support this. If it's easy to implement: Let's just do it! (We'd also accept a PR if it's a simple change.) But we don't really believe that this is an important aspect to fix and implement right now, unless more people request this or if any other circumstances change.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Impact-Correctness Issue-Bug Issue-Task Priority-3 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20105
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?