starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Building] settings.json also hides packages from intellisense's includePath #20114

New Issue
Closed
opened 2026-01-31 07:03:54 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:03:54 +00:00
Owner
Copy Link

Originally created by @tusharsnx on GitHub (Jun 20, 2023).

Windows Terminal version

Dev

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

  1. Clone repo.
  2. Install all dependencies. (Ensure nuget packages/ is populated)
  3. Open project dir in VScode

image

Expected Behavior

All packages' headers are included automatically.

image

reopen VSCode after making the changes for settings to take effect

Actual Behavior

Includes/headers under packages/ are ignored by VSCode LSP.

Originally created by @tusharsnx on GitHub (Jun 20, 2023). ### Windows Terminal version Dev ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce 1) Clone repo. 2) Install all dependencies. (*Ensure nuget `packages/` is populated*) 2) Open project dir in VScode ![image](https://github.com/microsoft/terminal/assets/55626797/782d341b-f3b8-4e43-83d7-639ed6a12497) ### Expected Behavior All packages' headers are included automatically. ![image](https://github.com/microsoft/terminal/assets/55626797/e76c032e-b6c9-4057-a407-75ca64519e3e) *reopen VSCode after making the changes for settings to take effect* ### Actual Behavior Includes/headers under `packages/` are ignored by VSCode LSP.
claunia added the Needs-TriageIssue-BugIn-PR labels 2026-01-31 07:03:55 +00:00
claunia commented 2026-01-31 07:03:56 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Jun 20, 2023):

settings.json is the one that comes with the source here.

Spend an hour figuring out why it couldn't find headers even though packages were installed correctly.

@tusharsnx commented on GitHub (Jun 20, 2023): *`settings.json` is the one that comes with the source [here](https://github.com/microsoft/terminal/blob/b8f402f64bf50e75148da84e9c42404ad3bdbb87/.vscode/settings.json#L106).* Spend an hour figuring out why it couldn't find headers even though packages were installed correctly.
claunia commented 2026-01-31 07:03:56 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 20, 2023):

If you'd like to submit a PR that improves the excludes, I'd be happy to merge it asap! 🙂

@lhecker commented on GitHub (Jun 20, 2023): If you'd like to submit a PR that improves the excludes, I'd be happy to merge it asap! 🙂
claunia commented 2026-01-31 07:03:57 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Jun 20, 2023):

If you'd like to submit a PR that improves the excludes, I'd be happy to merge it asap! 🙂

sure, I'll do that.

Is there any problem if we just remove packages/ from excludes or what was the motivation behind excluding it (other than hiding it from the vscode file list)?

@tusharsnx commented on GitHub (Jun 20, 2023): > If you'd like to submit a PR that improves the excludes, I'd be happy to merge it asap! 🙂 sure, I'll do that. Is there any problem if we just remove `packages/` from excludes or what was the motivation behind excluding it (other than hiding it from the vscode file list)?
claunia commented 2026-01-31 07:03:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 20, 2023):

Maybe we put it there when we had boost in our packages and didn't want that all getting parsed? I don't entirely remember.

IIRC @Jaswir was also looking at this, so this might be of interest to them. Dunno if they ever figured that out.

@zadjii-msft commented on GitHub (Jun 20, 2023): Maybe we put it there when we had boost in our packages and didn't want that all getting parsed? I don't entirely remember. IIRC @Jaswir was also looking at this, so this might be of interest to them. Dunno if they ever figured that out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label In-PR Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?