starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal might use i18n strings from multiple languages, if the preferred lang is not one WT is fully localized into #20135

New Issue
Open
opened 2026-01-31 07:04:42 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:04:42 +00:00
Owner
Copy Link

Originally created by @mataha on GitHub (Jun 23, 2023).

Important

📌 Plan of record: https://github.com/microsoft/terminal/issues/15596#issuecomment-1612163250
We should try to avoid using resources from languages we're only partially localized into (if that's even possible)

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.3086

Other Software

N/A

Steps to reproduce

Open Windows Terminal. That's it.

System languages installed (in order of preference):

  • Polish (display)
  • Japanese
  • Korean
  • Russian

Expected Behavior

Windows Terminal opens in my preferred system language (Polish), falling back to English (as it is the de facto lingua franca) if that's not possible.

Actual Behavior

I'd like to provide more details, but I can't stop laughing.

image

Originally created by @mataha on GitHub (Jun 23, 2023). <hr> > [!IMPORTANT] > 📌 Plan of record: **https://github.com/microsoft/terminal/issues/15596#issuecomment-1612163250** > We should try to avoid using resources from languages we're only partially localized into (if that's even possible) <hr> ### Windows Terminal version 1.17.11461.0 ### Windows build number 10.0.19045.3086 ### Other Software N/A ### Steps to reproduce Open Windows Terminal. That's it. System languages installed (in order of preference): - Polish (display) - Japanese - Korean - Russian ### Expected Behavior Windows Terminal opens in my preferred system language (Polish), falling back to English (as it is the *de facto* lingua franca) if that's not possible. ### Actual Behavior I'd like to provide more details, but I can't stop laughing. ![image](https://github.com/microsoft/terminal/assets/7210216/3f8c6d05-0b96-40e9-8c2a-9e4f5ec1a063)
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalArea-i18n labels 2026-01-31 07:04:42 +00:00
claunia commented 2026-01-31 07:04:43 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 26, 2023):

I honestly don't even know how to begin working on this. 😄
We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml.

@lhecker commented on GitHub (Jun 26, 2023): I honestly don't even know how to begin working on this. 😄 We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml.
claunia commented 2026-01-31 07:04:44 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 26, 2023):

LOL. Thanks for filing! I think I know how to approach this one.

If your list of preferred languages is:

  • Polish (display)
  • Japanese
  • Korean
  • Russian

We are not going to choose English under those circumstances. English is not one of your preferred languages!

For a quick fix, you can override the display language of Windows Terminal's UI with a setting on the Appearance page. 😄

The main issue is that Terminal isn't localized in Polish... but some of its components are, Ugh.

The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection.

The tertiary issue is that we do mark our package as supporting Polish, for this darn thing:

image

(That menu item gets localized into 88 languages, where the rest of Terminal only gets 13. Yeah. Not great.)

I'd like to provide more details, but I can't stop laughing.

(Do you mind if I share this with the i18n team? They'll get a kick out of it :D)

@DHowett commented on GitHub (Jun 26, 2023): LOL. Thanks for filing! I think I know how to approach this one. If your list of preferred languages is: > - Polish (display) > - Japanese > - Korean > - Russian We are not going to choose English under those circumstances. English is not one of your preferred languages! For a quick fix, you can override the display language of Windows Terminal's UI with a setting on the Appearance page. :smile: The main issue is that Terminal isn't localized in Polish... but some of its components _are_, Ugh. The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection. The _tertiary_ issue is that we do mark our package as supporting Polish, for this darn thing: <img width="184" alt="image" src="https://github.com/microsoft/terminal/assets/189190/fb2eeacc-3213-44a6-a1c7-93781d9f23f4"> (That menu item gets localized into 88 languages, where the rest of Terminal only gets 13. Yeah. Not great.) > I'd like to provide more details, but I can't stop laughing. (Do you mind if I share this with the i18n team? They'll get a kick out of it :D)
claunia commented 2026-01-31 07:04:44 +00:00
Author
Owner
Copy Link

@zadjii commented on GitHub (Jun 26, 2023):

This is a good sign that partial localizations work though, for #10667

@zadjii commented on GitHub (Jun 26, 2023): This is a good sign that partial localizations work though, for #10667
claunia commented 2026-01-31 07:04:45 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jun 28, 2023):

We should see if we can configure language fallback with MRT

@carlos-zamora commented on GitHub (Jun 28, 2023): We should see if we can configure language fallback with MRT
claunia commented 2026-01-31 07:04:45 +00:00
Author
Owner
Copy Link

@mataha commented on GitHub (Jul 1, 2023):

I honestly don't even know how to begin working on this. 😄 We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml.

I don't think there are many users with three - or even two - preferred system languages. Even less that would file a bug report here.

The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection.

That's what I thought - buttons are in Polish, most of the translated resources are in Japanese (with leftovers in Korean) and the rest is in English...

(Do you mind if I share this with the i18n team? They'll get a kick out of it :D)

Feel free to do so, by all means!

@mataha commented on GitHub (Jul 1, 2023): > I honestly don't even know how to begin working on this. 😄 We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml. I don't think there are many users with three - or even two - preferred system languages. Even less that would file a bug report here. > The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection. That's what I thought - buttons are in Polish, most of the translated resources are in Japanese (with leftovers in Korean) and the rest is in English... > (Do you mind if I share this with the i18n team? They'll get a kick out of it :D) Feel free to do so, by all means!
claunia commented 2026-01-31 07:04:45 +00:00
Author
Owner
Copy Link

@VectorBCO commented on GitHub (Nov 29, 2023):

i have a similar issue when terminal chose russian for some reason
https://github.com/microsoft/terminal/issues/16395

@VectorBCO commented on GitHub (Nov 29, 2023): i have a similar issue when terminal chose russian for some reason https://github.com/microsoft/terminal/issues/16395
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-i18n Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?