starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Position the experimental, optional right-click context menu so a left click will paste #20272

New Issue
Open
opened 2026-01-31 07:08:42 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:08:42 +00:00
Owner
Copy Link

Originally created by @Jaykul on GitHub (Jul 22, 2023).

Description of the new feature/enhancement

As a terminal user
When I right-click and get a menu
I want "Paste" to be the default option that appears directly where my mouse is

Proposed technical implementation details (optional)

The menu should always open such that the paste icon is directly below the cursor, instead of sometimes slightly above and to the right, and sometimes slightty above and to the left.

Do you realize the behavior is inconsistent?

  • The first time I right click, it opens with the cursor just to the left of the the line between the buttons and the text menu items.
  • If you right-click elsewhere while the menu is open, it moves to be horizontally centered on the mouse
  • If you right-click on the menu (and then move your mouse off the menu), you get the window's title-bar context menu
Originally created by @Jaykul on GitHub (Jul 22, 2023). # Description of the new feature/enhancement As a terminal user When I right-click and get a menu I want "Paste" to be the default option that appears directly where my mouse is # Proposed technical implementation details (optional) The menu should always open such that the paste icon is directly below the cursor, instead of sometimes slightly above and to the right, and sometimes slightty above and to the left. ## Do you realize the behavior is inconsistent? - The first time I right click, it opens with the cursor just to the _left_ of the the line between the buttons and the text menu items. - If you right-click **elsewhere** _while the menu is open_, it moves to be horizontally centered on the mouse - If you right-click **on** the menu (and then move your mouse off the menu), you get the window's title-bar context menu
claunia added the Help WantedIssue-TaskProduct-TerminalArea-TerminalControl labels 2026-01-31 07:08:43 +00:00
claunia commented 2026-01-31 07:08:43 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 24, 2023):

This isn't a bad idea at all. Though, I'll say that we should try and position it so that the first Primary button is under the cursor. That way, opening the menu with a selection would start with "copy" under the mouse.

Note

Walkthrough

I'd take a look at TermControl::_contextMenuHandler and TermControl::_showContextMenuAt. Those are what's responsible for opening our context menu. We should be able to slightly shift it.

Though, the direction we shift it might have to change based on the bounds of the control itself... Hmm. Right now we just ask WinUI to open the flyout at the point of the cursor, and let it adjust the positioning to account for the boundaries of the monitors.

I'm actually not gonna tag this up as a walkthrough after all, because this seems hard to get right.

If you maximize, then click near the bottom of the window (so that the menu needs to open
upwards, well, WinUI just gives up and doesn't bother with the centering anymore. Even if there's space for the primary commands between the cursor and the bottom of the display.

If you right-click on the menu (and then move your mouse off the menu), you get the window's title-bar context menu

lmao that's actually this hilarious XAML bug. If you right click on the shadow of any flyout, you get a system context menu. Literally makes no sense 🤣

@zadjii-msft commented on GitHub (Jul 24, 2023): This isn't a bad idea at all. Though, I'll say that we should try and position it so that the _first_ Primary button is under the cursor. That way, opening the menu with a selection would start with "copy" under the mouse. > **Note** > ## ~Walkthrough~ I'd take a look at `TermControl::_contextMenuHandler` and `TermControl::_showContextMenuAt`. Those are what's responsible for opening our context menu. We should be able to slightly shift it. Though, the direction we shift it might have to change based on the bounds of the control itself... Hmm. Right now we just ask WinUI to open the flyout at the point of the cursor, and let it adjust the positioning to account for the boundaries of the monitors. I'm actually _not_ gonna tag this up as a walkthrough after all, because this seems hard to get right. > If you maximize, then click near the bottom of the window (so that the menu needs to open upwards, well, WinUI just gives up and doesn't bother with the centering anymore. Even if there's space for the primary commands between the cursor and the bottom of the display. --- > If you right-click on the menu (and then move your mouse off the menu), you get the window's title-bar context menu lmao that's actually this _hilarious_ XAML bug. If you right click on the _shadow_ of any flyout, you get a system context menu. Literally makes no sense 🤣
claunia commented 2026-01-31 07:08:44 +00:00
Author
Owner
Copy Link

@Jaykul commented on GitHub (Jul 25, 2023):

This isn't a bad idea at all. Though, I'll say that we should try and position it so that the first Primary button is under the cursor. That way, opening the menu with a selection would start with "copy" under the mouse.

You're absolutely right. This is the way.

Though, the direction we shift it might have to change based on the bounds of the control itself... Hmm. Right now we just ask WinUI to open the flyout at the point of the cursor, and let it adjust the positioning to account for the boundaries of the monitors.

It's true that if someone clicks too close to the edge, the menu might not fit entirely on screen if you blindly positioned it as I was suggesting. Personally, I'd still like it there (as long as that first item is on screen, it'll be fine 😉), but I can see that's not an ideal default.

@Jaykul commented on GitHub (Jul 25, 2023): > This isn't a bad idea at all. Though, I'll say that we should try and position it so that the _first_ Primary button is under the cursor. That way, opening the menu with a selection would start with "copy" under the mouse. You're absolutely right. This is the way. > Though, the direction we shift it might have to change based on the bounds of the control itself... Hmm. Right now we just ask WinUI to open the flyout at the point of the cursor, and let it adjust the positioning to account for the boundaries of the monitors. It's true that if someone clicks _too_ close to the edge, the menu might not fit entirely on screen if you blindly positioned it as I was suggesting. Personally, I'd still like it there (as long as that first item is on screen, it'll be _fine_ 😉), but I can see that's not an ideal default.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?