starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Windows Terminal may not open if profiles.json is corrupted #2031

New Issue
Closed
opened 2026-01-30 22:45:00 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 22:45:00 +00:00
Owner
Copy Link

Originally created by @Karl-WE on GitHub (Jun 24, 2019).

Environment

Windows build number: Windows 10 1903

Windows Terminal version (if applicable): 0.2.1715.0

Any other software?

Steps to reproduce

edit profiles.json e.g. I tried to copy and paste some schemas from this templated
https://gist.github.com/mehulmpt/16826be279bb9bf70310b465ca9c5de3

After saving everything was fine and I really took care about not doing a mistake in the json formatting. However after closing and reopening Windows terminal

copy line 63 to 131 at the appropriate spot in profiles.json
https://gist.github.com/fcharlie/7530d36175bc5249f1ae92be536238cd

Expected behavior

The file should be checked for errors on startup of Windows Terminal. If there is an error it should fallback to a default config
also see #1404

Actual behavior

Windows Terminal does not start. no error message.

workaround

fully reset the app in app and features

Originally created by @Karl-WE on GitHub (Jun 24, 2019). <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Windows build number: Windows 10 1903 Windows Terminal version (if applicable): 0.2.1715.0 Any other software? # Steps to reproduce edit profiles.json e.g. I tried to copy and paste some schemas from this templated https://gist.github.com/mehulmpt/16826be279bb9bf70310b465ca9c5de3 After saving everything was fine and I really took care about not doing a mistake in the json formatting. However after closing and reopening Windows terminal <!-- A description of how to trigger this bug. --> copy line 63 to 131 at the appropriate spot in profiles.json https://gist.github.com/fcharlie/7530d36175bc5249f1ae92be536238cd # Expected behavior The file should be checked for errors on startup of Windows Terminal. If there is an error it should fallback to a default config also see #1404 # Actual behavior Windows Terminal does not start. no error message. # workaround fully reset the app in app and features
claunia added the Resolution-Fix-AvailableArea-SettingsIssue-BugProduct-Terminal labels 2026-01-30 22:45:00 +00:00
claunia commented 2026-01-30 22:45:01 +00:00
Author
Owner
Copy Link

@celsojr commented on GitHub (Jun 24, 2019):

IHMO an option like "restore defaults" would be great as well

@celsojr commented on GitHub (Jun 24, 2019): IHMO an option like "restore defaults" would be great as well
claunia commented 2026-01-30 22:45:02 +00:00
Author
Owner
Copy Link

@Shorotshishir commented on GitHub (Jun 24, 2019):

As of now, I couldn't find the fallback values implemented in the source. I believe it is directly dependent on the profile.json, which is really a good thing for testing,
UPDATE : they are in the DefaultSettings.h,
There should be a file that keeps the default values as it comes. the profile.json should be the file that overrides the default.json so that, while the user goes full-on experimental on the profile the functionality doesn't hamper. Just warn them that which part is falling back to default. thus giving a regular user quite a good range of customizability without fear and a power user the ultimate access.

@Shorotshishir commented on GitHub (Jun 24, 2019): ~~**As of now, I couldn't find the fallback values implemented in the source.**~~ I believe it is **directly dependent** on the profile.json, which is really a **good thing for testing**, **UPDATE** : they are in the DefaultSettings.h, There should be a file that keeps the default values as it comes. the `profile.json` should be the file that overrides the `default.json` so that, while the user goes full-on experimental on the profile the functionality doesn't hamper. Just warn them that which part is falling back to default. thus giving a regular user quite a good range of customizability without fear and a power user the ultimate access.
claunia commented 2026-01-30 22:45:02 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 24, 2019):

We are fairly sure we added a dialog for this... if you’re not seeing it, that’s pretty surprising.

We have an issue tracking having a defaults file. #754

@DHowett-MSFT commented on GitHub (Jun 24, 2019): We are fairly sure we added a dialog for this... if you’re not seeing it, that’s pretty surprising. We have an issue tracking having a defaults file. #754
claunia commented 2026-01-30 22:45:02 +00:00
Author
Owner
Copy Link

@Shorotshishir commented on GitHub (Jun 24, 2019):

@DHowett what I really wanted to point out is to have a separate file with default values like we now have a profile.json.

@Shorotshishir commented on GitHub (Jun 24, 2019): @DHowett what I really wanted to point out is to have a separate file with default values like we now have a `profile.json`.
claunia commented 2026-01-30 22:45:02 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (Jun 25, 2019):

We are fairly sure we added a dialog for this... if you’re not seeing it, that’s pretty surprising.

We have an issue tracking having a defaults file. #754

Hi @DHowett I can confirm the dialog is popping up in some certain conditions.
see this image:
image

example:
prerequisited: Windows Terminal is opened
user edits xml e.g. Notepad++ or code write uwp app
proflle.json gets edited and contains a parsing error
hit the save button in your editor > terminal will make a popup

possible problems:
editors with no code highlighting might be an issue - user problem
the error message will popup as a modal window, however if a user has terminal in the background he might not be aware about this
additionally the modal window will NOT prevent to close the Terminal from the taskbar (right click > close)

current situation:
there seems to be a fix since my report. Terminal will open with default settings
image

suggestion:
prevent closing the terminal app with an active modal window that is warning you about a json parsing error.

implement a button to reset the profile.json. in case it is corrupted there is no other way than Windows apps reset at the moment

@Karl-WE commented on GitHub (Jun 25, 2019): > We are fairly sure we added a dialog for this... if you’re not seeing it, that’s pretty surprising. > > We have an issue tracking having a defaults file. #754 Hi @DHowett I can confirm the dialog is popping up in some certain conditions. see this image: ![image](https://user-images.githubusercontent.com/45657752/60122745-27c2cb00-9786-11e9-950c-91fe33007b63.png) example: prerequisited: Windows Terminal is opened user edits xml e.g. Notepad++ or code write uwp app proflle.json gets edited and contains a parsing error hit the save button in your editor > terminal will make a popup possible problems: editors with no code highlighting might be an issue - user problem the error message will popup as a modal window, however if a user has terminal in the background he might not be aware about this additionally the modal window will NOT prevent to close the Terminal from the taskbar (right click > close) current situation: there seems to be a fix since my report. Terminal will open with default settings ![image](https://user-images.githubusercontent.com/45657752/60123288-63aa6000-9787-11e9-9ec6-7d91d6bc647d.png) suggestion: prevent closing the terminal app with an active modal window that is warning you about a json parsing error. implement a button to reset the profile.json. in case it is corrupted there is no other way than Windows apps reset at the moment
claunia commented 2026-01-30 22:45:03 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 27, 2019):

This'll be helped in part by #1348. The dialog should be working in all cases. Feel free to open a new issue if the dialog really isn't working.

@DHowett-MSFT commented on GitHub (Jun 27, 2019): This'll be helped in part by #1348. The dialog should be working in all cases. Feel free to open a new issue if the dialog really isn't working.
claunia commented 2026-01-30 22:45:03 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (Jun 29, 2019):

Agreed.

@Karl-WE commented on GitHub (Jun 29, 2019): Agreed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?