starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ultradefrag displays output differently on conhost and windows terminal. #20333

New Issue
Closed
opened 2026-01-31 07:10:38 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:10:38 +00:00
Owner
Copy Link

Originally created by @kotenok2000 on GitHub (Aug 4, 2023).

Windows Terminal version

1.17.11461.0

Windows build number

[Version 10.0.22621.1992]

Other Software

Ultradefrag https://sourceforge.net/projects/ultradefrag/files/stable-release/7.1.4

Steps to reproduce

Install Ultradefrag.
Run udefrag -a --all -v -m in windows terminal

Expected Behavior

https://github.com/microsoft/terminal/assets/8822292/fd62f580-67dd-4b13-a96c-58cf75350476

Actual Behavior

https://github.com/microsoft/terminal/assets/8822292/ac2a9c7c-aade-467d-9137-05c2cbafa6f9

Originally created by @kotenok2000 on GitHub (Aug 4, 2023). ### Windows Terminal version 1.17.11461.0 ### Windows build number [Version 10.0.22621.1992] ### Other Software Ultradefrag https://sourceforge.net/projects/ultradefrag/files/stable-release/7.1.4 ### Steps to reproduce Install Ultradefrag. Run udefrag -a --all -v -m in windows terminal ### Expected Behavior https://github.com/microsoft/terminal/assets/8822292/fd62f580-67dd-4b13-a96c-58cf75350476 ### Actual Behavior https://github.com/microsoft/terminal/assets/8822292/ac2a9c7c-aade-467d-9137-05c2cbafa6f9
claunia commented 2026-01-31 07:10:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 4, 2023):

1.11??? That's a super old version. Can you try a newer Terminal version/?

@zadjii-msft commented on GitHub (Aug 4, 2023): **1.11**??? That's a super old version. Can you try a newer Terminal version/?
claunia commented 2026-01-31 07:10:40 +00:00
Author
Owner
Copy Link

@kotenok2000 commented on GitHub (Aug 4, 2023):

I mistyped. It is actually 1.17

@kotenok2000 commented on GitHub (Aug 4, 2023): I mistyped. It is actually 1.17
claunia commented 2026-01-31 07:10:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2023):

Theories:

  • Maybe this is busted because of Terminal defaulting to ENABLE_VIRTUAL_TERMINAL_PROCESSING?
  • Maybe this is busted because of SetConsoleScreenBufferInfo wackiness in conpty mode
@zadjii-msft commented on GitHub (Aug 23, 2023): Theories: * Maybe this is busted because of Terminal defaulting to ENABLE_VIRTUAL_TERMINAL_PROCESSING? * Maybe this is busted because of `SetConsoleScreenBufferInfo` wackiness in conpty mode
claunia commented 2026-01-31 07:10:40 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Aug 24, 2023):

Maybe this is busted because of Terminal defaulting to ENABLE_VIRTUAL_TERMINAL_PROCESSING?

I believe it's this. ☝️

When redrawing the progress line, they clear it first with a function that looks like this:

void clear_line(void)
{
    CONSOLE_SCREEN_BUFFER_INFO csbi;
    if(!GetConsoleScreenBufferInfo(g_out,&csbi))
        return; /* impossible to determine the screen width */
    int n = (int)csbi.dwSize.X;

    char *line = new char[n + 1];
    memset(line,0x20,n);
    line[n] = 0;
    fprintf(stdout,"\r%s",line);
    delete [] line;

    /* move cursor back to the previous line */
    if(GetConsoleScreenBufferInfo(g_out,&csbi)){
        COORD pos; pos.X = 0;
        pos.Y = csbi.dwCursorPosition.Y - 1;
        (void)SetConsoleCursorPosition(g_out,pos);
    }
}

What that's doing is writing out a bunch of spaces to cover the width of the buffer. On the legacy console that would end up with the cursor position wrapping onto the next line. So they follow that up with a call to SetConsoleCursorPosition to move the cursor back up a line.

When in VT mode, though, we have "delayed EOL wrap", so writing out something the exact with of the buffer does not wrap onto the next line. So their attempt to correct the cursor position actually ends up placing it a line higher than it was intended to be.

@j4james commented on GitHub (Aug 24, 2023): > Maybe this is busted because of Terminal defaulting to ENABLE_VIRTUAL_TERMINAL_PROCESSING? I believe it's this. ☝️ When redrawing the progress line, they clear it first with a function that looks like this: ```c void clear_line(void) { CONSOLE_SCREEN_BUFFER_INFO csbi; if(!GetConsoleScreenBufferInfo(g_out,&csbi)) return; /* impossible to determine the screen width */ int n = (int)csbi.dwSize.X; char *line = new char[n + 1]; memset(line,0x20,n); line[n] = 0; fprintf(stdout,"\r%s",line); delete [] line; /* move cursor back to the previous line */ if(GetConsoleScreenBufferInfo(g_out,&csbi)){ COORD pos; pos.X = 0; pos.Y = csbi.dwCursorPosition.Y - 1; (void)SetConsoleCursorPosition(g_out,pos); } } ``` What that's doing is writing out a bunch of spaces to cover the width of the buffer. On the legacy console that would end up with the cursor position wrapping onto the next line. So they follow that up with a call to `SetConsoleCursorPosition` to move the cursor back up a line. When in VT mode, though, we have "delayed EOL wrap", so writing out something the exact with of the buffer does _not_ wrap onto the next line. So their attempt to correct the cursor position actually ends up placing it a line higher than it was intended to be.
claunia commented 2026-01-31 07:10:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 24, 2023):

Well, that's a fantastic investigation! I guess this is something that's different between Terminal and conhost, sure. I'd make the call though that this is a bug in ultradefrag - they should make sure to set the console modes to exactly what they expect to work.

@kotenok2000 You should probably file this upstream at https://sourceforge.net/p/ultradefrag/bugs/

Thanks!

@zadjii-msft commented on GitHub (Aug 24, 2023): Well, that's a fantastic investigation! I guess this is something that's different between Terminal and conhost, sure. I'd make the call though that this is a bug in ultradefrag - they should make sure to set the console modes to exactly what they expect to work. @kotenok2000 You should probably file this upstream at https://sourceforge.net/p/ultradefrag/bugs/ Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Help Wanted Issue-Bug Product-Conpty Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20333
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?