starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal window closes on right-click, when connection is closed and waiting for keypress #20343

New Issue
Closed
opened 2026-01-31 07:10:54 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:10:54 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 7, 2023).

Originally assigned to: @zadjii-msft on GitHub.

from MSFT:45731977

When you run an application from Visual Studio, and use Windows Terminal, at the end of the application run it will display "press any key to close the window". This is as expected. However, it doesn't only close on keyboard input, but also when you right-click the Terminal window. This is NOT desirable, since right click is also used for copying text.
It should ONLY close on keyboard input.

I noticed that this only happens when you have a small amount of text in the clipboard that doesn't trigger any messagebox (ie. warnings about pasting a lot of text).

I guess what happens is that the right click actually pastes text into the console, and this is then seen as keyboard input and closes the terminal.

I have lost a lot of time running long apps that print debug information to the console by accidentally right clicking INTO the console window, when I wanted to right click on its tab to select "Export Text". It would be very useful, if pasting text was disabled in case the terminal would close on input.

Originally created by @zadjii-msft on GitHub (Aug 7, 2023). Originally assigned to: @zadjii-msft on GitHub. _from MSFT:45731977_ > When you run an application from Visual Studio, and use Windows Terminal, at the end of the application run it will display "press any key to close the window". This is as expected. However, it doesn't only close on keyboard input, but also when you right-click the Terminal window. This is NOT desirable, since right click is also used for copying text. It should ONLY close on keyboard input. > I noticed that this only happens when you have a small amount of text in the clipboard that doesn't trigger any messagebox (ie. warnings about pasting a lot of text). > > I guess what happens is that the right click actually pastes text into the console, and this is then seen as keyboard input and closes the terminal. > > I have lost a lot of time running long apps that print debug information to the console by accidentally right clicking INTO the console window, when I wanted to right click on its tab to select "Export Text". It would be very useful, if pasting text was disabled in case the terminal would close on input.
claunia commented 2026-01-31 07:10:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 7, 2023):

I coulda swore that we didn't paste on a right-click if the right click was causing the window to be focused. Maybe that got lost? Or I'm mistaken?

@zadjii-msft commented on GitHub (Aug 7, 2023): I coulda swore that we _didn't_ paste on a right-click if the right click was causing the window to be focused. Maybe that got lost? Or I'm mistaken?
claunia commented 2026-01-31 07:10:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 1, 2024):

Hmm, even if you go back to 8910a16fd0 (diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697), I suspect this was broken. (that's 3 years old now).

Even in that one, if the TermControl was unfocused, we'd focus it, but then we'd power along and eventually just copy anyways. Weird. Whatever. Easy enough to fix.

@zadjii-msft commented on GitHub (Apr 1, 2024): Hmm, even if you go back to https://github.com/microsoft/terminal/commit/8910a16fd0d0ebf0feaa7b182a5f812a0b28f2d4#diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697, I suspect this was broken. (that's 3 years old now). Even in that one, if the TermControl was unfocused, we'd focus it, but then we'd power along and eventually just copy anyways. Weird. Whatever. Easy enough to fix.
claunia commented 2026-01-31 07:10:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 2, 2024):

Meh, we decided that this is perfectly reasonable behavior as-is.

@zadjii-msft commented on GitHub (Apr 2, 2024): Meh, we decided that this is perfectly reasonable behavior as-is.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Area-TerminalControl In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20343
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?