starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Pasting a multiline block of text does not autoMarkPrompts #20354

New Issue
Closed
opened 2026-01-31 07:11:14 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:11:14 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 9, 2023).

Originally assigned to: @zadjii-msft on GitHub.

  1. Turn on "experimental.autoMarkPrompts": true, and "experimental.rightClickContextMenu": true,
  2. turn on shell integration too. Just in general always, it's goodness.
  3. Copy the following
command-one
dir
command-two
command-three
  1. Paste it. Accept the warning.
  2. Try to right-click "select output" or command.
  3. Observe that it no worky.

Surely, when we paste text, we're not going through the same path in Terminal.cpp that marks enter

Originally created by @zadjii-msft on GitHub (Aug 9, 2023). Originally assigned to: @zadjii-msft on GitHub. 1. Turn on `"experimental.autoMarkPrompts": true,` and `"experimental.rightClickContextMenu": true,` 2. turn on shell integration too. Just in general always, it's goodness. 3. Copy the following ``` command-one dir command-two command-three ``` 4. Paste it. Accept the warning. 5. Try to right-click "select output" or command. 6. Observe that it no worky. Surely, when we paste text, we're not going through the same path in `Terminal.cpp` that marks <kbd>enter</kbd>
claunia commented 2026-01-31 07:11:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 9, 2023):

Note: don't do this for

  • the alt buffer
  • bracketed paste
@zadjii-msft commented on GitHub (Aug 9, 2023): Note: don't do this for * the alt buffer * bracketed paste
claunia commented 2026-01-31 07:11:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 10, 2024):

Similarly, this doesn't work if you sendInput(foo\rbar\nbaz). None of them seem to work to mark.

I'm guessing it's because sendInput comes in through the paste handler. Might be able to fix

@zadjii-msft commented on GitHub (May 10, 2024): Similarly, this doesn't work if you `sendInput(foo\rbar\nbaz)`. None of them seem to work to mark. I'm guessing it's because sendInput comes in through the paste handler. Might be able to fix
claunia commented 2026-01-31 07:11:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 10, 2024):

I am somewhat anti-this. Most multi-line pastes are into things that aren't shells probably...

@DHowett commented on GitHub (May 10, 2024): I am somewhat anti-this. Most multi-line pastes are into _things that aren't shells_ probably...
claunia commented 2026-01-31 07:11:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 10, 2024):

The alt buffer doesn't have marks at all, so there's that to mitigate some concerns.

FWIW I even tried doing sendInput with \u001b[13;28;13;1;32;1_\u001b[13;28;13;0;32;1_ (enter) and even that didn't mark the commands ended.

(I may be able to fake this better with powershell)

@zadjii-msft commented on GitHub (May 10, 2024): The alt buffer doesn't have marks at all, so there's that to mitigate some concerns. FWIW I even tried doing `sendInput` with `\u001b[13;28;13;1;32;1_\u001b[13;28;13;0;32;1_` (enter) and even that didn't mark the commands ended. (I may be able to fake this better with powershell)
claunia commented 2026-01-31 07:11:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 13, 2024):

Okay, well, this actually will just never work (for probably obvious reasons). I'm focusing narrowly on the sendInput scenario here, but it's equally obvious for paste.

When we call ControlCore::SendInput, we write the text directly to the connection. We could split that on each \r, and then try to automark on each of those newlines, BUT: we don't know when the output of each of those will be. We'd write a block, mark the line, write a block, mark, etc, probably multiple times before we got the first bit back out of the first command. When we get that block, nothing will actually get emitted before we write the whole block.

uhg.

Goddard, options:

  • COOKED_READ emits a 133;C when it processes an enter
    • dangerous, certainly too dangerous for Build)
  • add some sort of commands param to sendInput, and that will wait to the next prompt between sending elements in the commands array
    • deeply underspec'd
  • definitely just cut this from the demo? Or at least blow past the fact that the command also gets selected
  • add a sleep action that literally just Sleeps for that timeout, so that I can then multipleActions([sendInput, sleep, ]) ah fuck see that still doesn't work. Still doesn't mark the command
  • Maybe see if I can bodge PWSH into supporting 133;C without automarking
@zadjii-msft commented on GitHub (May 13, 2024): Okay, well, this actually will just never work (for probably obvious reasons). I'm focusing narrowly on the sendInput scenario here, but it's equally obvious for paste. When we call `ControlCore::SendInput`, we write the text directly to the connection. We _could_ split that on each `\r`, and then try to automark on each of those newlines, BUT: we don't know when the output of each of those will be. We'd write a block, mark the line, write a block, mark, etc, probably multiple times before we got the first bit back out of the first command. When we get that block, nothing will actually get emitted before we write the whole block. uhg. Goddard, options: * COOKED_READ emits a 133;C when it processes an enter * dangerous, certainly too dangerous for Build) * add some sort of `commands` param to sendInput, and that will wait to the next prompt between sending elements in the commands array * deeply underspec'd * definitely just cut this from the demo? Or at least blow past the fact that the command also gets selected * add a `sleep` action that literally just `Sleep`s for that timeout, so that I can then `multipleActions([sendInput, sleep, ])` ah fuck see that still doesn't work. Still doesn't mark the command * Maybe see if I can bodge PWSH into supporting 133;C without automarking
claunia commented 2026-01-31 07:11:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 14, 2024):

You know what, in light of how painful some of the proposed fixes are, and how specifically automarkPrompts==="mark when you press enter", then I'm gonna close this out as "by design". Kinda unexpected, and I could be convinced the other way, but only if there was a good solution proposed.

@zadjii-msft commented on GitHub (May 14, 2024): You know what, in light of how painful some of the proposed fixes are, and how specifically `automarkPrompts`==="mark when you press enter", then I'm gonna close this out as "by design". Kinda unexpected, and I could be convinced the other way, but only if there was a good solution proposed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Product-Terminal Resolution-By-Design
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?