Suggestions UI ship list #20378

Open
opened 2026-01-31 07:11:55 +00:00 by claunia · 1 comment
Owner

Originally created by @zadjii-msft on GitHub (Aug 17, 2023).

Originally assigned to: @zadjii-msft on GitHub.

first PR: #14938

1.21 Ship list

1.22

1.23

  • When filtering the suggestions UI, also allow matches to the raw input to successfully match (see dev/migrie/f/filter-weight-input-too dev/migrie/f/snippet-weighting-commandline)
  • When filtering the SXNUI, disable all nesting for things at this level. (see dev/migrie/b/no-nesting-when-searching )
  • Action in newTabMenu -> openSuggestions immediately tosses focus to the control when the menu dismisses
  • Cross compilation to Linux (#17419)
  • We don't account for the InfoBar when positioning the suggestions UI
  • The padding on the description tooltip is a little tight - it should have a little more
  • in CMD: enter foo. Open SXNUI. Dismiss it. resize up from bottom. Open SXNUI: it's cut off (from 1.22 bug bash 2)

Other notes:

are you looking for me?

Originally created by @zadjii-msft on GitHub (Aug 17, 2023). Originally assigned to: @zadjii-msft on GitHub. first PR: #14938 ### 1.21 Ship list - [x] Accessibility tags all have `CommandPalette_` strings 🤣 - [x] useCommandline should leave the cursor at the _end_ of the input, not at the start - [x] https://github.com/microsoft/terminal/issues/16577 - [x] https://github.com/microsoft/terminal/issues/16578 - [x] https://github.com/microsoft/terminal/issues/17243 - [x] https://github.com/microsoft/terminal/issues/17241 - [x] It animates in as you filter and that's so gross ### 1.22 - [x] ~#17418 Add support for nesting:false in openSuggestions action~ - [x] #12861 - [x] #17376 - [ ] https://github.com/microsoft/terminal/issues/17772 - [x] https://github.com/microsoft/terminal/pull/17533 - [ ] https://github.com/microsoft/terminal/issues/17773 - [x] #17632 - [x] useCommandline, when bottom-up, should leave the _last_ list item selected, not the first. (fixed in #17794) - [x] ^ Probably applies to any changes to the filter text when bottom up. ### 1.23 - [ ] When filtering the suggestions UI, also allow matches to the raw input to successfully match (see ~`dev/migrie/f/filter-weight-input-too`~ `dev/migrie/f/snippet-weighting-commandline`) - [ ] When filtering the SXNUI, disable all nesting for things at this level. (see `dev/migrie/b/no-nesting-when-searching` ) - [ ] Action in newTabMenu -> openSuggestions immediately tosses focus to the _control_ when the menu dismisses - [ ] #17419 - [ ] We don't account for the InfoBar when positioning the suggestions UI - [ ] The padding on the description tooltip is a little tight - it should have a little more - [ ] in CMD: enter `foo`. Open SXNUI. Dismiss it. resize up from bottom. Open SXNUI: it's cut off (from 1.22 bug bash 2) ### Related - [ ] #16063 - [ ] https://github.com/microsoft/terminal/issues/12927 - [ ] Follow up from #16513: make sure everything is localized - [ ] From #16513: `wt save` should like, always happen in the current terminal window (if that's possible) - [ ] https://github.com/microsoft/terminal/issues/15813 - [ ] #17344 - [ ] #19061 Other notes: * Tried to make the font size match the active control. That's... incredibly wacky. See https://github.com/microsoft/terminal/compare/dev/migrie/f/sxnui-font-size-change * Re: _"When filtering the suggestions UI, also allow matches to the raw input to successfully match"_ I started that in `dev/migrie/f/filter-weight-input-too`. That branches off of the snippets pane, #17330. See delta here: https://github.com/microsoft/terminal/compare/dev/migrie/f/snippets-pane...dev/migrie/f/filter-weight-input-too. That works super well, but needs a lot of polish. * ... _are you looking for me?_ * #13000 * #11000 * #13445
claunia added the Issue-BugProduct-TerminalArea-UserInterface labels 2026-01-31 07:11:55 +00:00
Author
Owner

@DHowett commented on GitHub (Aug 22, 2024):

@zadjii-msft can you punt the 1.21 and 1.22 things to the appropriate milestone and move this issue out?

@DHowett commented on GitHub (Aug 22, 2024): @zadjii-msft can you punt the 1.21 and 1.22 things to the appropriate milestone and move this issue out?
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20378