starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Support exe/dll paths in the 'icon' setting #2039

New Issue
Closed
opened 2026-01-30 22:45:14 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 22:45:14 +00:00
Owner
Copy Link

Originally created by @fpintos on GitHub (Jun 24, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Support exe/icon paths in the 'icon' setting of a profile

The icon setting of a profile should allow the path to an EXE or DLL to be specified, along with an optional ID for an icon resource in the file.

For example, I should be able to create a profile using icons from SHELL32:

    ...
    "icon": "c:\Windows\System32\SHELL32.dll,210",
    ...

Optionally, if the icon is missing and the executable from the command line has icons, pick the default icon, much like how the shell does.

Originally created by @fpintos on GitHub (Jun 24, 2019). Originally assigned to: @zadjii-msft on GitHub. # Support exe/icon paths in the 'icon' setting of a profile The icon setting of a profile should allow the path to an EXE or DLL to be specified, along with an optional ID for an icon resource in the file. For example, I should be able to create a profile using icons from SHELL32: ``` ... "icon": "c:\Windows\System32\SHELL32.dll,210", ... ``` Optionally, if the icon is missing and the executable from the command line has icons, pick the default icon, much like how the shell does.
claunia commented 2026-01-30 22:45:15 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (Jun 25, 2019):

I agree. or things like "icon": "C:\Program Files\PowerShell\6-preview\pwsh.exe",

@Karl-WE commented on GitHub (Jun 25, 2019): I agree. or things like "icon": "C:\Program Files\PowerShell\6-preview\pwsh.exe",
claunia commented 2026-01-30 22:45:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 27, 2019):

Yeah, it would be pretty cool if we did this.

@DHowett-MSFT commented on GitHub (Jun 27, 2019): Yeah, it would be pretty cool if we did this.
claunia commented 2026-01-30 22:45:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 27, 2019):

Notes: Right now we're using the XAML resource loader to get at our icons. If we want to support EXE/other PE resources we'll need to fall back to a more win32-like resource loader. There are real benefits to the XAML one, such as it choosing the right icon scale and supporting vector graphics and stuff like that. I've tagged it help-wanted.

@DHowett-MSFT commented on GitHub (Jun 27, 2019): Notes: Right now we're using the XAML resource loader to get at our icons. If we want to support EXE/other PE resources we'll need to fall back to a more win32-like resource loader. There are real benefits to the XAML one, such as _it choosing the right icon scale_ and supporting vector graphics and stuff like that. I've tagged it `help-wanted`.
claunia commented 2026-01-30 22:45:16 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (Jun 29, 2019):

@DHowett-MSFT afaik not even the settings app in Windows uses SVG graphics but PNGs. I stumbled across them once. I see the point of having this more modern and getting rid of old ico restrictions.

@Karl-WE commented on GitHub (Jun 29, 2019): @DHowett-MSFT afaik not even the settings app in Windows uses SVG graphics but PNGs. I stumbled across them once. I see the point of having this more modern and getting rid of old ico restrictions.
claunia commented 2026-01-30 22:45:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 12, 2021):

This is highly related to #705 (but definitely different)

@zadjii-msft commented on GitHub (Feb 12, 2021): This is highly related to #705 (but definitely different)
claunia commented 2026-01-30 22:45:16 +00:00
Author
Owner
Copy Link

@gim913 commented on GitHub (Apr 20, 2021):

Notes: (…) There are real benefits to the XAML one, such as it choosing the right icon scale and supporting vector graphics and stuff like that. I've tagged it help-wanted.

Just FYI: technically single icon inside PE resources can contain multiple icons (with various color depths, sizes - up to 256x256 etc.), that is how you could have same but actually different icon for title bar and for application itself. (that is, smaller one was used for title bar).

ofc, afaik vector graphics is/was not an option.

@gim913 commented on GitHub (Apr 20, 2021): > Notes: (…) There are real benefits to the XAML one, such as _it choosing the right icon scale_ and supporting vector graphics and stuff like that. I've tagged it `help-wanted`. Just FYI: technically single icon inside PE resources can contain multiple icons (with various color depths, sizes - up to 256x256 etc.), that is how you could have same but actually different icon for title bar and for application itself. (that is, smaller one was used for title bar). ofc, afaik vector graphics is/was not an option.
claunia commented 2026-01-30 22:45:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2022):

Notes from some tabs I had open for the last few weeks:

Still not sure if that connects up to a BitmapImage. Maybe I should look in the BitmapImage source itself - it can apparently read from .ico files, so there's probably some overlap between reading an .ico and reading an HICON.

More notes:

  • Window::s_RegisterWindowClass is where we set the HICON for the console window.
  • This is unpacked in Icon::GetIcons, after a call to:
  • Icon::LoadIconsFromPath, in win32/SystemConfigurationProvider::GetSettingsFromLink (see also #11759)
    • first check: ShortcutSerialization::s_GetLinkValues
      • ShortcutSerialization::s_GetLoadedShellLinkForShortcut to load the IShellLink for the lnk
      • psl->GetIconLocation to load the icon from the IShellLink.
    • Then, we fall back to the title?
    • SystemConfigurationProvider::GetSettingsFromLink sets the icon GLOBALLY. It probably initializes other state. If we want to reuse that to pull the icon out of an lnk before handoff, the we should be SURE it's not setting any other magic global state. We can use a dummy console Settings to hold data if need be.
  • see 1dd6e9934
@zadjii-msft commented on GitHub (May 24, 2022): Notes from some tabs I had open for the last few weeks: * dotnet uses `System.Windows.Interop.Imaging.CreateBitmapSourceFromHIcon`, which obv we can't use. * https://github.com/dotnet/wpf/blob/89d172db0b7a192de720c6cfba5e28a1e7d46123/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/InterOp/Imaging.cs#L77 * https://github.com/dotnet/wpf/blob/89d172db0b7a192de720c6cfba5e28a1e7d46123/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Imaging/InteropBitmapSource.cs#L91-L96 * [`IWICImagingFactory_CreateBitmapFromHICON_Proxy`](https://docs.microsoft.com/en-us/windows/win32/wic/-wic-codec-iwicimagingfactory-createbitmapfromhicon-proxy) * Data from that is accessed as in [`IWICBitmapLock::GetDataPointer`](https://docs.microsoft.com/en-us/windows/win32/api/wincodec/nf-wincodec-iwicbitmaplock-getdatapointer) Still not sure if that connects up to a `BitmapImage`. Maybe I should look in the BitmapImage source itself - it can apparently read from `.ico` files, so there's probably some overlap between reading an `.ico` and reading an `HICON`. More notes: * `Window::s_RegisterWindowClass` is where we set the HICON for the console window. * This is unpacked in `Icon::GetIcons`, after a call to: * `Icon::LoadIconsFromPath`, in `win32/SystemConfigurationProvider::GetSettingsFromLink` (see also #11759) * first check: `ShortcutSerialization::s_GetLinkValues` * `ShortcutSerialization::s_GetLoadedShellLinkForShortcut` to load the `IShellLink` for the lnk * `psl->GetIconLocation` to load the icon from the `IShellLink`. * Then, we fall back to the title? * `SystemConfigurationProvider::GetSettingsFromLink` sets the icon GLOBALLY. It probably initializes other state. If we want to reuse that to pull the icon out of an lnk before handoff, the we should be SURE it's not setting any other magic global state. We can use a dummy console `Settings` to hold data if need be. * see 1dd6e9934
claunia commented 2026-01-30 22:45:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 9, 2022):

Note to self: dev/migrie/1504-prototype-2

@zadjii-msft commented on GitHub (Sep 9, 2022): Note to self: [`dev/migrie/1504-prototype-2`](https://github.com/microsoft/terminal/compare/dev/migrie/1504-prototype-2)
claunia commented 2026-01-30 22:45:17 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14107, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14107, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?