starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Incorrect cursor position on full lines #20414

New Issue
Closed
opened 2026-01-31 07:13:02 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 07:13:02 +00:00
Owner
Copy Link

Originally created by @zamadatix on GitHub (Aug 28, 2023).

Windows Terminal version

1.7.11461.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Create a character string which is one character short of the full line width:

image

Add the final character and note the cursor appears one character left of where it should:

image

Expected Behavior

Cursor should appear at the end of the line when the line is full.

Actual Behavior

Cursor appears one character before the end of the line. Operationally the cursor functions according to the correct position ("delete" does nothing and "backspace" removes the "L"). This is an off-by-one error on just the display side.

Originally created by @zamadatix on GitHub (Aug 28, 2023). ### Windows Terminal version 1.7.11461.0 ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce Create a character string which is one character short of the full line width: ![image](https://github.com/microsoft/terminal/assets/343550/29484546-cca6-41e7-baca-694a238649a9) Add the final character and note the cursor appears one character left of where it should: ![image](https://github.com/microsoft/terminal/assets/343550/084cc7b9-91e3-4212-982d-0a528ab36028) ### Expected Behavior Cursor should appear at the end of the line when the line is full. ### Actual Behavior Cursor appears one character before the end of the line. Operationally the cursor functions according to the correct position ("delete" does nothing and "backspace" removes the "L"). This is an off-by-one error on just the display side.
claunia commented 2026-01-31 07:13:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 29, 2023):

Thanks for reporting this!

You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space.

Different terminal emulators handle this differently:
image

It looks funny when the default cursor is set to the vertical bar... but the cursor technically occupies a cell, and not a place between cells.

/cc @j4james, as I am probably getting some details wrong 😄

@DHowett commented on GitHub (Aug 29, 2023): Thanks for reporting this! You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space. Different terminal emulators handle this differently: <img width="374" alt="image" src="https://github.com/microsoft/terminal/assets/189190/ec80e008-9e5a-4344-86c4-bad676b8af69"> It looks funny when the default cursor is set to the vertical bar... but the cursor technically occupies a cell, and not a place between cells. /cc @j4james, as I am probably getting some details wrong 😄
claunia commented 2026-01-31 07:13:05 +00:00
Author
Owner
Copy Link

@pere3 commented on GitHub (Aug 29, 2023):

Hi, i wonder if this is the same issue i'm having with vim on windows terminal, where cursor always appears one character to the left from the end of the line?
2023-08-29_20-13-04

@pere3 commented on GitHub (Aug 29, 2023): Hi, i wonder if this is the same issue i'm having with vim on windows terminal, where cursor always appears one character to the left from the end of the line? ![2023-08-29_20-13-04](https://github.com/microsoft/terminal/assets/548405/26b1b04e-b1cb-43bf-a419-d1e6dbdbc04a)
claunia commented 2026-01-31 07:13:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 29, 2023):

In your case (@pere3), the position of the cursor is controlled by vim. 😄

@DHowett commented on GitHub (Aug 29, 2023): In your case (@pere3), the position of the cursor is controlled by vim. :smile:
claunia commented 2026-01-31 07:13:05 +00:00
Author
Owner
Copy Link

@zamadatix commented on GitHub (Aug 29, 2023):

Hey DHowett, thanks for taking the time to respond and spread some knowledge 😊:

You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space.

Different terminal emulators handle this differently: image

It looks funny when the default cursor is set to the vertical bar... but the cursor technically occupies a cell, and not a place between cells.

Hmm that's fair. I guess I was just used to the behavior of the original console where even the full sized cursor would wrap:

image

If I remember the console APIs correctly this is a behavior the app can choose to override but idk, to me it makes more sense for the cursor to always display where it is but maybe there is nothing saying that's how it's supposed to be.

There is another inconsistency I've noticed with the way the end of line is handled. If you type to the end of a line like this:

image

You can press the right arrow and nothing happens, as would be expected given the current positioning logic. If you instead press left then right (i.e., leave the position and return back to it) the cursor follows the "move to next line" behavior even though the position is the same as before when it followed the "stay at end of line" behavior:

image

I'm not sure if this behavior is inherent to the way the line wrapping logic is supposed to work in this method but it certainly feels inconsistent to someone unfamiliar.

@DHowett I'll leave it up to you to divine if this second behavior would be categorized as a bug or not. In either scenario, I'd like to make the case that it (feels) more consistent to just wrap the cursor to the next line as the default behavior, if both are valid, but agree that may not fit under the "bug" tag.

@zamadatix commented on GitHub (Aug 29, 2023): Hey DHowett, thanks for taking the time to respond and spread some knowledge 😊: > You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space. > > Different terminal emulators handle this differently: <img alt="image" width="374" src="https://user-images.githubusercontent.com/189190/264094054-ec80e008-9e5a-4344-86c4-bad676b8af69.png"> > > It looks funny when the default cursor is set to the vertical bar... but the cursor technically occupies a cell, and not a place between cells. Hmm that's fair. I guess I was just used to the behavior of the original console where even the full sized cursor would wrap: ![image](https://github.com/microsoft/terminal/assets/343550/6b76035c-7e78-4d89-b264-008370a14a2e) If I remember the console APIs correctly this is a behavior the app can choose to override but idk, to me it makes more sense for the cursor to always display where it is but maybe there is nothing saying that's how it's supposed to be. There is another inconsistency I've noticed with the way the end of line is handled. If you type to the end of a line like this: ![image](https://github.com/microsoft/terminal/assets/343550/5a7994ac-02f4-443d-8f18-62a390616078) You can press the right arrow and nothing happens, as would be expected given the current positioning logic. If you instead press left then right (i.e., leave the position and return back to it) the cursor follows the "move to next line" behavior even though the position is the same as before when it followed the "stay at end of line" behavior: ![image](https://github.com/microsoft/terminal/assets/343550/a709583d-07c5-48d4-92ad-6fc1ff3f1338) I'm not sure if this behavior is inherent to the way the line wrapping logic is supposed to work in this method but it certainly feels inconsistent to someone unfamiliar. @DHowett I'll leave it up to you to divine if this second behavior would be categorized as a bug or not. In either scenario, I'd like to make the case that it (feels) more consistent to just wrap the cursor to the next line as the default behavior, if both are valid, but agree that may not fit under the "bug" tag.
claunia commented 2026-01-31 07:13:06 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Aug 29, 2023):

You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space.

@DHowett I think there's more to this, though, because it works differently in conhost. I had a brief look at what was going on and it appears that pwsh is using a mix of VT and legacy APIs. When you type a character at the end of the line, it redraws the line in VT mode, leaving the cursor in the last column. But it also then calls SetConsoleCursorPosition to manually reposition the cursor on the next line. That final cursor position doesn't seem to be forwarded over conpty. So I think there is likely a genuine bug here.

@j4james commented on GitHub (Aug 29, 2023): > You'd be surprised -- this is actually working as intended! Applications are allowed to write text all the way to the edge of the screen without incurring line wrapping. However, the cursor cannot go off the edge of the screen to indicate that the next character will go into outer space. @DHowett I think there's more to this, though, because it works differently in conhost. I had a brief look at what was going on and it appears that pwsh is using a mix of VT and legacy APIs. When you type a character at the end of the line, it redraws the line in VT mode, leaving the cursor in the last column. But it also then calls `SetConsoleCursorPosition` to manually reposition the cursor on the next line. That final cursor position doesn't seem to be forwarded over conpty. So I think there is likely a genuine bug here.
claunia commented 2026-01-31 07:13:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 29, 2023):

Huh! I get to be the one who is surprised! Thanks for looking, James. 😄

@DHowett commented on GitHub (Aug 29, 2023): _Huh!_ I get to be the one who is surprised! Thanks for looking, James. :smile:
claunia commented 2026-01-31 07:13:06 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 30, 2023):

I was looking through other issues and couldn't find an answer to that, so...
If we ever move the rendering of the viewport margins into the renderers, could we perhaps draw the cursor inside the margin (if the margin is >0)? That would be different to other terminals, but would pretty cool.

BTW while writing this I just noticed that our margins aren't quite uniform...
Edit: Opened #15903

@lhecker commented on GitHub (Aug 30, 2023): I was looking through other issues and couldn't find an answer to that, so... If we ever move the rendering of the viewport margins into the renderers, could we perhaps draw the cursor inside the margin (if the margin is >0)? That would be different to other terminals, but would pretty cool. BTW while writing this I just noticed that our margins aren't quite uniform... Edit: Opened #15903
claunia commented 2026-01-31 07:13:06 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Aug 31, 2023):

could we perhaps draw the cursor inside the margin (if the margin is >0)?

If we do, it should definitely be an option, preferably off by default, because from a standards point of view that's just wrong. When the terminal is in this state, the cursor position is explicitly defined as the last column. The reported position is going to be the last column. Any movement operation is going to be relative to the last column. If you're rendering the cursor somewhere else, it's going to appear broken. Maybe it's a personal preference, but if I saw a terminal doing this I'd assume it was a bug.

@j4james commented on GitHub (Aug 31, 2023): > could we perhaps draw the cursor inside the margin (if the margin is >0)? If we do, it should definitely be an option, preferably off by default, because from a standards point of view that's just wrong. When the terminal is in this state, the cursor position is explicitly defined as the last column. The reported position is going to be the last column. Any movement operation is going to be relative to the last column. If you're rendering the cursor somewhere else, it's going to appear broken. Maybe it's a personal preference, but if I saw a terminal doing this I'd assume it was a bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?