starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.19 selfhost] URL autodetection is broken #20417

New Issue
Open
opened 2026-01-31 07:13:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 07:13:10 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 28, 2023).

Originally assigned to: @lhecker on GitHub.

Version 1.19.2371.0, which I believe has #15858 in it.

Don't have a narrow repro yet - writing down before I forget.

I wrote a few screenfuls of text. Then did a git push. It gave me the handy:

Enumerating objects: 68, done.
Counting objects: 100% (68/68), done.
Delta compression using up to 8 threads
Compressing objects: 100% (41/41), done.
Writing objects: 100% (41/41), 4.62 KiB | 2.31 MiB/s, done.
Total 41 (delta 38), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (38/38), completed with 27 local objects.
remote:
remote: Create a pull request for 'dev/migrie/f/--inherit-env-vars' on GitHub by visiting:
remote:      https://github.com/microsoft/terminal/pull/new/dev/migrie/f/--inherit-env-vars
remote:
To https://github.com/microsoft/terminal
 * [new branch]          dev/migrie/f/--inherit-env-vars -> dev/migrie/f/--inherit-env-vars
Branch 'dev/migrie/f/--inherit-env-vars' set up to track remote branch 'dev/migrie/f/--inherit-env-vars' from 'origin'.

But alas, a ctrl+shift+m, shift+tab did not highlight the URL. Instead, it higlighted some text that was way up near the start of the buffer (but not like, as the same viewport-relative position or anything like that). The selected text was very much not a URL:

image

Originally created by @zadjii-msft on GitHub (Aug 28, 2023). Originally assigned to: @lhecker on GitHub. Version `1.19.2371.0`, which I believe has #15858 in it. Don't have a narrow repro yet - writing down before I forget. I wrote a few screenfuls of text. Then did a git push. It gave me the handy: ``` Enumerating objects: 68, done. Counting objects: 100% (68/68), done. Delta compression using up to 8 threads Compressing objects: 100% (41/41), done. Writing objects: 100% (41/41), 4.62 KiB | 2.31 MiB/s, done. Total 41 (delta 38), reused 0 (delta 0), pack-reused 0 remote: Resolving deltas: 100% (38/38), completed with 27 local objects. remote: remote: Create a pull request for 'dev/migrie/f/--inherit-env-vars' on GitHub by visiting: remote: https://github.com/microsoft/terminal/pull/new/dev/migrie/f/--inherit-env-vars remote: To https://github.com/microsoft/terminal * [new branch] dev/migrie/f/--inherit-env-vars -> dev/migrie/f/--inherit-env-vars Branch 'dev/migrie/f/--inherit-env-vars' set up to track remote branch 'dev/migrie/f/--inherit-env-vars' from 'origin'. ``` But alas, a <kbd>ctrl+shift+m</kbd>, <kbd>shift+tab</kbd> did not highlight the URL. Instead, it higlighted some text that was way up near the start of the buffer (but not like, as the same viewport-relative position or anything like that). The selected text was very much _not_ a URL: ![image](https://github.com/microsoft/terminal/assets/18356694/4ba2c9d4-e7ec-43d8-b324-d7aa43f04949)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output In-PR Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?