starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Pane movement breaks showCloseButton=never #20427

New Issue
Open
opened 2026-01-31 07:13:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 07:13:32 +00:00
Owner
Copy Link

Originally created by @regnaio on GitHub (Aug 30, 2023).

Windows Terminal version

1.17.11461.0

Windows build number

Version 10.0.19045.3324

Other Software

No response

Steps to reproduce

Add the following to settings.json (in %LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json):

"theme": "foo",
"themes": [
  {
    "name": "foo",
    "tab": {
      "showCloseButton": "never"
    }
  }
]

Run in Command Prompt:

wt -M -p "Ubuntu-20.04" ; ^
	split-pane -p "Ubuntu-20.04" ;

Observe that the first tab has an "X" on the right that you can click to close the tab. But, tab.showCloseButton: never should have hidden this "X". The split-pane line is causing this bug. If you remove it, i.e.

wt -M -p "Ubuntu-20.04" ;

then the tab no longer has the "X", as expected

For related discussion:

Expected Behavior

The "X" icon should not be present on a Windows Terminal tab if tab.showCloseButton: never

Actual Behavior

The "X" icon is present on a tab if using split-pane in wt

Edit (lhecker): Any movement between two panes makes the buttons reappear.

Originally created by @regnaio on GitHub (Aug 30, 2023). ### Windows Terminal version 1.17.11461.0 ### Windows build number Version 10.0.19045.3324 ### Other Software _No response_ ### Steps to reproduce Add the following to `settings.json` (in `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json`): ```json "theme": "foo", "themes": [ { "name": "foo", "tab": { "showCloseButton": "never" } } ] ``` Run in Command Prompt: ```shell wt -M -p "Ubuntu-20.04" ; ^ split-pane -p "Ubuntu-20.04" ; ``` Observe that the first tab has an "X" on the right that you can click to close the tab. But, `tab.showCloseButton`: `never` should have hidden this "X". The `split-pane` line is causing this bug. If you remove it, i.e. ```shell wt -M -p "Ubuntu-20.04" ; ``` then the tab no longer has the "X", as expected For related discussion: - https://github.com/microsoft/terminal/issues/3335 - https://github.com/microsoft/terminal/pull/13348 ### Expected Behavior The "X" icon should not be present on a Windows Terminal tab if `tab.showCloseButton`: `never` ### Actual Behavior The "X" icon is present on a tab if using `split-pane` in `wt` --- _Edit (lhecker)_: **Any movement between two panes makes the buttons reappear**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-UserInterface In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?