starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Adjust Opacity to 100% with Color Scheme in Unfocused Appearance that has colour other than black gives black outline #20433

New Issue
Open
opened 2026-01-31 07:13:43 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:13:43 +00:00
Owner
Copy Link

Originally created by @Jaswir on GitHub (Aug 31, 2023).

Windows Terminal version

1.18.1462.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

image
new_bug_discovered

Expected Behavior

image

Actual Behavior

actual behaviour

Originally created by @Jaswir on GitHub (Aug 31, 2023). ### Windows Terminal version 1.18.1462.0 ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce ![image](https://github.com/microsoft/terminal/assets/15957528/628e9af1-1e0b-4792-9f4d-ab149309eebe) ![new_bug_discovered](https://github.com/microsoft/terminal/assets/15957528/494d4417-6a35-450a-89f7-52085ef9b546) ### Expected Behavior ![image](https://github.com/microsoft/terminal/assets/15957528/51cafec6-2e29-4446-84e5-c3a1a9664ed2) ### Actual Behavior ![actual behaviour](https://github.com/microsoft/terminal/assets/15957528/9267f6f3-7fa7-4e71-bdf1-61f1daf37439)
claunia added the Help WantedArea-RenderingIssue-BugProduct-Terminal labels 2026-01-31 07:13:44 +00:00
claunia commented 2026-01-31 07:13:45 +00:00
Author
Owner
Copy Link

@Jaswir commented on GitHub (Sep 1, 2023):

Clue: adding retroTerminalEffect to unfocusedAppearance gives a different behaviour

image

@Jaswir commented on GitHub (Sep 1, 2023): Clue: adding retroTerminalEffect to unfocusedAppearance gives a different behaviour ![image](https://github.com/microsoft/terminal/assets/15957528/9825767c-33a7-465e-ad9e-a5711855e507)
claunia commented 2026-01-31 07:13:45 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 6, 2023):

Thanks for finding this! If you're interested in working on it, please be our guest. 😊

@carlos-zamora commented on GitHub (Sep 6, 2023): Thanks for finding this! If you're interested in working on it, please be our guest. 😊
claunia commented 2026-01-31 07:13:45 +00:00
Author
Owner
Copy Link

@Jaswir commented on GitHub (Oct 14, 2023):

@lhecker

Hi Leonard,

Are you reading this?

I would feel uncomfortable talking in the chat of 190 or 2664 cause lots of people. Feel more comfortable talking here with you.

I read you're the expertise person when it comes to DXEngine, AtlasEngine

In all honesty, the renderer code is probably not my area of expertise. The best I could likely do is point you at DxEngine and AtlasEngine, which are the two different text renderers in the Terminal.

@lhecker might be able to point you to a more specific method to look at.

-- @zadjii-msft

I was wondering if 190 and 2664 are both related to DXEngine, AtlasEngine?

@Jaswir commented on GitHub (Oct 14, 2023): @lhecker Hi Leonard, Are you reading this? I would feel uncomfortable talking in the chat of 190 or 2664 cause lots of people. Feel more comfortable talking here with you. I read you're the expertise person when it comes to DXEngine, AtlasEngine > In all honesty, the renderer code is probably not my area of expertise. The best I could likely do is point you at DxEngine and AtlasEngine, which are the two different text renderers in the Terminal. > @lhecker might be able to point you to a more specific method to look at. -- @zadjii-msft I was wondering if 190 and 2664 are both related to DXEngine, AtlasEngine?
claunia commented 2026-01-31 07:13:45 +00:00
Author
Owner
Copy Link

@Jaswir commented on GitHub (Oct 14, 2023):

@zadjii-msft

What is your expertise then?

@Jaswir commented on GitHub (Oct 14, 2023): @zadjii-msft What is your expertise then?
claunia commented 2026-01-31 07:13:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 16, 2023):

My expertise at this point is pretty much the whole project, save for the renderer code, and the UIA code. Pretty much everything else I've had my paws on. The VT code has certainly evolved dramatically since I first owned that, but it's a lot of the same shape more or less. I've at various points owned:

  • The VT parser
  • Console settings
  • ConPTY
  • the whole Windows Terminal architecture, from the core and connection layers up to the control, the settings model, the app layer, the windowing, the process model.

Rendering I've mostly kept my head out of, except a couple quick forays to help here and there. I'm honestly more familiar with OpenGL than I am directx 😄 There's a lot to mentally cache in for working with the renderer, so I try to leave that cached out of my brain most of the time.

@zadjii-msft commented on GitHub (Oct 16, 2023): My expertise at this point is pretty much the whole project, save for the renderer code, and the UIA code. Pretty much everything else I've had my paws on. The VT code has certainly evolved dramatically since I first owned that, but it's a lot of the same shape more or less. I've at various points owned: * The VT parser * Console settings * ConPTY * the whole Windows Terminal architecture, from the core and connection layers up to the control, the settings model, the app layer, the windowing, the process model. Rendering I've mostly kept my head out of, except a couple quick forays to help here and there. I'm honestly more familiar with OpenGL than I am directx 😄 There's a lot to mentally cache in for working with the renderer, so I try to leave that cached out of my brain most of the time.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?