starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

emojis don't blink #20490

New Issue
Open
opened 2026-01-31 07:15:17 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:15:17 +00:00
Owner
Copy Link

Originally created by @ClaireCJS on GitHub (Sep 18, 2023).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Use ansi codes to set blinking on

Print some ASCII characters around an emoji character

Expected Behavior

All characters will blink

Actual Behavior

The ASCII (unicode?) characters blink, but the emoji characters do not.

ADDITIONAL COMMENTS:

At the very least, the background around it could be blunk.

I did this: I simulated blinking emoji via a gentle blinking of the black background around the emoji.

I set a slightly-above-black custom RGB foreground character and then using both reverse and blink at once -- which caused the foreground to become the background and be the part that blunk. Perhaps that is a bug too, but I liked that it was still possible to simulate a blinking emoji.

But such trickery shoudln't really be needed, in my opinion?

Originally created by @ClaireCJS on GitHub (Sep 18, 2023). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce Use ansi codes to set blinking on Print some ASCII characters around an emoji character ### Expected Behavior All characters will blink ### Actual Behavior The ASCII (unicode?) characters blink, but the emoji characters do not. **ADDITIONAL COMMENTS:** At the very least, the background around it could be blunk. I did this: I simulated blinking emoji via a gentle blinking of the black background around the emoji. I set a slightly-above-black custom RGB foreground character and then using both reverse and blink at once -- which caused the foreground to become the background and be the part that blunk. Perhaps that is a bug too, but I liked that it was still possible to simulate a blinking emoji. But such trickery shoudln't really be needed, in my opinion?
claunia added the Area-RenderingIssue-BugProduct-Terminal labels 2026-01-31 07:15:17 +00:00
claunia commented 2026-01-31 07:15:18 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 18, 2023):

This is because blinking dims the foreground color:
2fa8e766bb/src/renderer/base/RenderSettings.cpp (L156)

...and emojis are unaffected by the chosen foreground color. We could consider not using the dim attribute for blinking and instead start using the alpha component of the foreground color for this (or similar).

@lhecker commented on GitHub (Sep 18, 2023): This is because blinking dims the foreground color: https://github.com/microsoft/terminal/blob/2fa8e766bb516aa02d248e2dfe46d2b3269c3c9e/src/renderer/base/RenderSettings.cpp#L156 ...and emojis are unaffected by the chosen foreground color. We could consider not using the dim attribute for blinking and instead start using the alpha component of the foreground color for this (or similar).
claunia commented 2026-01-31 07:15:18 +00:00
Author
Owner
Copy Link

@ClaireCJS commented on GitHub (Mar 13, 2024):

I simulate it by going into ansi reverse mode and blinking, which blinks the background (which was previously the foreground before ansi reverse), which, can be set to a custom rgb value to get the aesthetic blink one wants.

But yes — The fact that emojis can be italicized just makes me think other operators (underline, bold, blink) should work as well.

@ClaireCJS commented on GitHub (Mar 13, 2024): I simulate it by going into ansi reverse mode and blinking, which blinks the background (which was previously the foreground before ansi reverse), which, can be set to a custom rgb value to get the aesthetic blink one wants. But yes — The fact that emojis can be italicized just makes me think other operators (underline, bold, blink) should work as well.
claunia commented 2026-01-31 07:15:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 13, 2024):

Well, they'll blink if you turn off full-color emoji after #16871 lands!

We should also make them blink when they are full color. 😁

@DHowett commented on GitHub (Mar 13, 2024): Well, they'll blink if you turn off full-color emoji after #16871 lands! We should also make them blink when they _are_ full color. 😁
claunia commented 2026-01-31 07:15:18 +00:00
Author
Owner
Copy Link

@ClaireCJS commented on GitHub (Mar 14, 2024):

I agree!!!

@ClaireCJS commented on GitHub (Mar 14, 2024): I agree!!!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?