starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Color Scheme - Camphell]: Incorrect Name is defined for 'Foreground', 'Background' etc. #20501

New Issue
Closed
opened 2026-01-31 07:15:46 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:15:46 +00:00
Owner
Copy Link

Originally created by @Priyanka-Chauhan123 on GitHub (Sep 18, 2023).

Windows Terminal version

1.19.2481.0

Windows build number

23529.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 23529.1000)
App: Windows Terminal Preview

Steps to reproduce

**Repro Steps: **

1.Open Windows Terminal.
2.Open Settings page using 'Ctr+,'
3. Navigate to the 'Color Scheme' and Select 'Camphell'.
4. Now navigate to 'Foreground', 'Background' etc. control and observe the issue.

**User Experience: **
Screen Reader users will not be able to get the color of the background and foreground, as screen reader is not announcing the color name and only announcing it as foreground and background.

Observation:
Incorrect tooltip is also defined for the control.

MAS Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachment :
Incorrect Name is defined for for 'Foreground', 'Background' etc..zip

Expected Behavior

Correct Name should be defined for 'Foreground', 'Background' etc. Color name should be announced which is defined for foreground and background.

Actual Behavior

Incorrect Name is defined for 'Foreground', 'Background' etc. Screen reader is just announcing it as "Foreground/Background" and not announcing its color.

Originally created by @Priyanka-Chauhan123 on GitHub (Sep 18, 2023). ### Windows Terminal version 1.19.2481.0 ### Windows build number 23529.1000 ### Other Software Test Environment: OS: Windows 11 Version Dev (OS Build 23529.1000) App: Windows Terminal Preview ### Steps to reproduce **Repro Steps: ** 1.Open Windows Terminal. 2.Open Settings page using 'Ctr+,' 3. Navigate to the 'Color Scheme' and Select 'Camphell'. 4. Now navigate to 'Foreground', 'Background' etc. control and observe the issue. **User Experience: ** Screen Reader users will not be able to get the color of the background and foreground, as screen reader is not announcing the color name and only announcing it as foreground and background. **Observation:** Incorrect tooltip is also defined for the control. MAS Reference: https://www.w3.org/WAI/WCAG21/Understanding/name-role-value Attachment : [Incorrect Name is defined for for 'Foreground', 'Background' etc..zip](https://github.com/microsoft/terminal/files/12644742/Incorrect.Name.is.defined.for.for.Foreground.Background.etc.zip) ### Expected Behavior Correct Name should be defined for 'Foreground', 'Background' etc. Color name should be announced which is defined for foreground and background. ### Actual Behavior Incorrect Name is defined for 'Foreground', 'Background' etc. Screen reader is just announcing it as "Foreground/Background" and not announcing its color.
claunia commented 2026-01-31 07:15:49 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 18, 2023):

https://github.com/microsoft/terminal/issues/15983#issuecomment-1723778110

[@DHowett]: @zadjii-msft for 15985, I wonder if it would be possible to indicate "Foreground (Ochre)" or "Background (Vermillion)"?

There's two parts to this:

  1. converting the color value into readable text:
    • We could store this logic in a converter. I'm hoping there's an easy way to convert from hex to something like "ochre" or "red". Worst case, a long switch-case statement will do the trick (🤢). The easiest approach will be to reveal the hex code and iterate from there.
  2. updating the automation property (name):
    • I could be wrong, but I remember having some trouble before when the automation property would not update on an existing UI element. You can set it, but it won't update until it's regenerated. Again, I could be misremembering this, but that's definitely something to keep an eye on.

As for the design, yeah, totally agree that we should say "foreground" and the color value. That way the screen reader user knows that they're modifying the value of "foreground".

@carlos-zamora commented on GitHub (Sep 18, 2023): https://github.com/microsoft/terminal/issues/15983#issuecomment-1723778110 > [@DHowett]: @zadjii-msft for 15985, I wonder if it would be possible to indicate "Foreground (Ochre)" or "Background (Vermillion)"? There's two parts to this: 1. converting the color value into readable text: - We could store this logic in a converter. I'm hoping there's an easy way to convert from hex to something like "ochre" or "red". Worst case, a long switch-case statement will do the trick (🤢). The easiest approach will be to reveal the hex code and iterate from there. 2. updating the automation property (name): - I could be wrong, but I remember having some trouble before when the automation property would not update on an existing UI element. You can set it, but it won't update until it's regenerated. Again, I could be misremembering this, but that's definitely something to keep an eye on. As for the design, yeah, totally agree that we should say "foreground" and the color value. That way the screen reader user knows that they're modifying the value of "foreground".
claunia commented 2026-01-31 07:15:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 19, 2023):

The easiest approach will be to reveal the hex code and iterate from there.

Honestly, let's do that unless it's absolutely trivial to convert an RGB to a localized color name.

@zadjii-msft commented on GitHub (Sep 19, 2023): > The easiest approach will be to reveal the hex code and iterate from there. Honestly, let's do that unless it's absolutely trivial to convert an RGB to a _localized_ color name.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev2 A11yWCAG Area-Accessibility Disability-All HCL-E+D HCL-WindowsTerminal In-PR Issue-Bug Needs-Tag-Fix Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20501
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?