starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Latest compilers emit a ton of C4996 warnings as errors #20513

New Issue
Closed
opened 2026-01-31 07:16:10 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 07:16:10 +00:00
Owner
Copy Link

Originally created by @Dan-Albrecht on GitHub (Sep 19, 2023).

Windows Terminal version

main @ 2e91e9c

Windows build number

10.0.22621.0

Other Software

Visual Studio Version 17.8.0 Preview 3.0 [34118.359.main]

msbuild -version
MSBuild version 17.8.0-preview-23431-02+3c910ba83 for .NET Framework
17.8.0.43102

Steps to reproduce

  • Open OpenConsole solution
  • Set to x64
  • F5

Expected Behavior

No errors

Actual Behavior

1,123 C4996 warnings as errors. e.g.:

Error	C4996	'stdext::checked_array_iterator<_Ty*>': warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory functions are non-Standard extensions and will be removed in the future. 
std::span (since C++20) and gsl::span can be used instead. 
You can define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to suppress this warning.	
fmt	C:\git\terminal\oss\fmt\include\fmt\format.h	359
Originally created by @Dan-Albrecht on GitHub (Sep 19, 2023). ### Windows Terminal version main @ [2e91e9c](https://github.com/microsoft/terminal/commit/2e91e9c6debca8915e829592b90ab5c3f13224b8) ### Windows build number 10.0.22621.0 ### Other Software Visual Studio `Version 17.8.0 Preview 3.0 [34118.359.main]` ``` msbuild -version MSBuild version 17.8.0-preview-23431-02+3c910ba83 for .NET Framework 17.8.0.43102 ``` ### Steps to reproduce - Open OpenConsole solution - Set to x64 - F5 ### Expected Behavior No errors ### Actual Behavior 1,123 C4996 warnings as errors. e.g.: ``` Error C4996 'stdext::checked_array_iterator<_Ty*>': warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory functions are non-Standard extensions and will be removed in the future. std::span (since C++20) and gsl::span can be used instead. You can define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to suppress this warning. fmt C:\git\terminal\oss\fmt\include\fmt\format.h 359 ```
claunia commented 2026-01-31 07:16:12 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 19, 2023):

Related: https://github.com/fmtlib/fmt/issues/3540
We currently use 7.1.3 (2 years old? wat). In the 9 versions since then (currently 10.1.1) we've missed:

  • compile-time format string checks
  • faster format string compilation
  • "{}"_cf instead of FMT_COMPILE("{}")
  • smaller PCH
  • way faster float and hex formatting
  • way faster format_to
  • ...
@lhecker commented on GitHub (Sep 19, 2023): Related: https://github.com/fmtlib/fmt/issues/3540 We currently use 7.1.3 (2 years old? wat). In the 9 versions since then (currently 10.1.1) we've missed: * compile-time format string checks * faster format string compilation * `"{}"_cf` instead of `FMT_COMPILE("{}")` * smaller PCH * way faster float and hex formatting * way faster `format_to` * ...
claunia commented 2026-01-31 07:16:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 19, 2023):

Yep we should probably just update that. Thanks!

@zadjii-msft commented on GitHub (Sep 19, 2023): Yep we should probably just update that. Thanks!
claunia commented 2026-01-31 07:16:13 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 19, 2023):

Related: #15855

I am committing to not updating our checked-in dependencies until we have a Governance-clean pipeline for doing so :)

@DHowett commented on GitHub (Sep 19, 2023): Related: #15855 I am committing to not updating our checked-in dependencies until we have a Governance-clean pipeline for doing so :)
claunia commented 2026-01-31 07:16:13 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 20, 2023):

BTW I just noticed: Happy round-issue-number to you!

It turns out that the upgrade is a significant pain in the butt, because fmt largely removed support for wchar_t. Things that don't work anymore:

  • Passing wstring parameters to string formattings and vice versa
  • Implicitly casting hstring to wstring_view

I started working on this in https://github.com/microsoft/terminal/tree/dev/lhecker/16000-fmt-update

@lhecker commented on GitHub (Sep 20, 2023): BTW I just noticed: Happy round-issue-number to you! It turns out that the upgrade is a significant pain in the butt, because `fmt` largely removed support for `wchar_t`. Things that don't work anymore: * Passing `wstring` parameters to `string` formattings and vice versa * Implicitly casting `hstring` to `wstring_view` I started working on this in https://github.com/microsoft/terminal/tree/dev/lhecker/16000-fmt-update
claunia commented 2026-01-31 07:16:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 20, 2023):

I am uncomfortable with the premier C++ formatting library removing support for an entire platform like that. Considering that Windows predominantly uses wide strings, that makes it nearly unfit for purpose.

Do you happen to have any links to docs about them explicitly dropping support?

@DHowett commented on GitHub (Sep 20, 2023): I am uncomfortable with the premier C++ formatting library removing support for an entire platform like that. Considering that Windows predominantly uses wide strings, that makes it nearly unfit for purpose. Do you happen to have any links to docs about them explicitly dropping support?
claunia commented 2026-01-31 07:16:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 20, 2023):

Hey! I said "largely removed", not "dropped". 😄 And I meant it in the context of our project which uses char -> wchar_t conversions quite a bit. Maybe I should've worded it better, like "because fmt removed parts that we took a significant dependency on".

fmt now matches the behavior of std::format which doesn't provide a builtin implicit conversion either:

error C2338: static_assert failed: 'Cannot format an argument. To make type T formattable, provide a formatter<T> specialization. See N4950 [format.arg.store]/2 and [formatter.requirements].'

The same is true for winrt::hstring which also fails with the above message with std::format.

I don't know which commit(s) removed either of the two features, because there's no commit in fmt/xchar.h's history that has a fitting title, there's no issue with one either, and I'm not sure what to look for when reading the massive format-inl.h file.
But it fits the C++ standard behavior so I don't think we're missing out on anything.

@lhecker commented on GitHub (Sep 20, 2023): Hey! I said "largely removed", not "dropped". 😄 And I meant it in the context of our project which uses `char` -> `wchar_t` conversions quite a bit. Maybe I should've worded it better, like "because `fmt` removed parts that we took a significant dependency on". `fmt` now matches the behavior of `std::format` which doesn't provide a builtin implicit conversion either: ``` error C2338: static_assert failed: 'Cannot format an argument. To make type T formattable, provide a formatter<T> specialization. See N4950 [format.arg.store]/2 and [formatter.requirements].' ``` The same is true for `winrt::hstring` which also fails with the above message with `std::format`. I don't know which commit(s) removed either of the two features, because there's no commit in `fmt/xchar.h`'s history that has a fitting title, there's no issue with one either, and I'm not sure what to look for when reading the massive `format-inl.h` file. But it fits the C++ standard behavior so I don't think we're missing out on anything.
claunia commented 2026-01-31 07:16:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 20, 2023):

I finished fixing all issues and as it turns out, the wchar_t / char thing was fairly minor. The biggest problem was fixing all those

format(RS_(...), ...)

which now need to be

format(fmt::runtime(RS_(...)), ...)

because it now does compile time format checks even without FMT_COMPILE (great!), but that doesn't work for hstring parameters because fmt defines its own fmt::string_view class for pre-C++17 compatibility. fmt::string_view has an implicit constructor for std::string_view, but an hstring is only implicitly convertible to an std::string_view.
Me and my C++ compiler have spent a lot of time today staring out of the window, while the "door stuck" soundtrack played in the back of my head.

@lhecker commented on GitHub (Sep 20, 2023): I finished fixing all issues and as it turns out, the `wchar_t` / `char` thing was fairly minor. The biggest problem was fixing all those ```cpp format(RS_(...), ...) ``` which now need to be ```cpp format(fmt::runtime(RS_(...)), ...) ``` because it now does compile time format checks even without `FMT_COMPILE` (great!), but that doesn't work for `hstring` parameters because `fmt` defines its own `fmt::string_view` class for pre-C++17 compatibility. `fmt::string_view` has an implicit constructor for `std::string_view`, but an `hstring` is only implicitly convertible **to** an `std::string_view`. Me and my C++ compiler have spent a lot of time today staring out of the window, while the "door stuck" soundtrack played in the back of my head.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?