starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Solarized schemes shipped in Terminal Preview are incorrect #2052

New Issue
Open
opened 2026-01-30 22:45:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 22:45:34 +00:00
Owner
Copy Link

Originally created by @TBBle on GitHub (Jun 24, 2019).

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version: Windows Terminal (Preview) 0.2.1715.0

Steps to reproduce

Note: I already had PowerShell and CMD using Solarized Dark in ConHost, via cmd-colors-solarized.

  • Install Windows Terminal (Preview)
  • Hit Settings
  • In the JSON file, change the colorScheme for Powershell and CMD to Solarized Dark.

Expected behavior

The same colours as provided by cmd-colours-solarized, consistent with the main Solarized page screenshots

Actual behavior

The white is too bright. That stood out immediately, so I looked deeper at the pre-defined scheme.

Diagnosis

Comparing the default settings to upstream Solarized The Values and Usage & Development I noted the following differences.

Solarized: Role Tone HEX RGB Terminal: RGB HEX Tone
Dark Foreground base0 #839496 131_148_150 253_246_227 #FDF6E3 base3
Dark Background base03 #002b36 0 _43_54 7_54_66 #073642 base02
Light Foreground base00 #657b83 101_123_131 7_54_66 #073642 base02
Light Background base3 #fdf6e3 253_246_227 253_246_227 #FDF6E3 base3
Red red #dc322f 220_50_47 211_1_2 #D30102 Red (beta1)

The difference in Red is simply that the definition came from an older version of Solarized, and was changed in the 1.0.0beta2 release. This one shows up on the Internet a lot, if you search for #D30102.

The foreground/background differences are a little weird, my guess would be that a modified Light scheme was used (darker font text on the same background) and then some confusion or oversight caused Dark to be defined as 'Light with a swapped FG/BG', leading to an overall-higher brightness from the non-coloured text.

Originally created by @TBBle on GitHub (Jun 24, 2019). # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.175] Windows Terminal version: Windows Terminal (Preview) 0.2.1715.0 ``` # Steps to reproduce Note: I already had PowerShell and CMD using Solarized Dark in ConHost, via [cmd-colors-solarized](https://github.com/neilpa/cmd-colors-solarized). * Install Windows Terminal (Preview) * Hit Settings * In the JSON file, change the `colorScheme` for Powershell and CMD to `Solarized Dark`. # Expected behavior The same colours as provided by [cmd-colours-solarized](https://github.com/neilpa/cmd-colors-solarized), consistent with the main [Solarized page screenshots](https://ethanschoonover.com/solarized/) # Actual behavior The white is too bright. That stood out immediately, so I looked deeper at the pre-defined scheme. # Diagnosis Comparing the [default settings](https://github.com/microsoft/terminal/blob/9b92986b49bed8cc41fde4d6ef080921c41e6d9e/src/cascadia/TerminalApp/CascadiaSettings.cpp#L113) to upstream Solarized [The Values](https://ethanschoonover.com/solarized/#the-values) and [Usage & Development](https://ethanschoonover.com/solarized/#usage-development) I noted the following differences. Solarized: Role | Tone | HEX | RGB | Terminal: RGB | HEX | Tone ----------------|------|------|-----|----------------|--------|------ Dark Foreground | base0 | `#839496` | 131_148_150 | 253_246_227 | `#FDF6E3` | base3 Dark Background | base03 | `#002b36` | 0 _43_54 | 7_54_66 | `#073642` | base02 Light Foreground | base00 | `#657b83` | 101_123_131 | 7_54_66 | `#073642` | base02 Light Background | base3 | `#fdf6e3` | 253_246_227 | 253_246_227 | `#FDF6E3` | base3 Red | red | `#dc322f` | 220_50_47 | 211_1_2 | `#D30102` | Red (beta1) The difference in Red is simply that the definition came from an older version of Solarized, and was changed in the [1.0.0beta2](https://github.com/altercation/solarized/blob/master/CHANGELOG.mkd#critical-changes) release. This one shows up on the Internet a lot, if you search for `#D30102`. The foreground/background differences are a little weird, my guess would be that a modified Light scheme was used (darker font text on the same background) and then some confusion or oversight caused Dark to be defined as 'Light with a swapped FG/BG', leading to an overall-higher brightness from the non-coloured text.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2052
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?