starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some file: OSC 8 URLs show up as "Invalid URI" because punycode/idn conversion blows up (?) #20523

New Issue
Closed
opened 2026-01-31 07:16:27 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:16:27 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Sep 22, 2023).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

"`e]8;;file:D:\this\is\a\very\long\path\with\a\number\of\subdirectories\in\it\and\that\is\OKAY`e\Test URL`e]8;;`e\"

Expected Behavior

No response

Actual Behavior

Hover it! It shows up as an "invalid URI"!

Originally created by @DHowett on GitHub (Sep 22, 2023). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce ``` "`e]8;;file:D:\this\is\a\very\long\path\with\a\number\of\subdirectories\in\it\and\that\is\OKAY`e\Test URL`e]8;;`e\" ``` ### Expected Behavior _No response_ ### Actual Behavior Hover it! It shows up as an "invalid URI"!
claunia added the Issue-BugIn-PRProduct-TerminalArea-TerminalControl labels 2026-01-31 07:16:28 +00:00
claunia commented 2026-01-31 07:16:29 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Sep 22, 2023):

Hover it! It shows up as an "invalid URI"!

Perhabs file:// ?

In my environment I could not reproduce.

Screenshot 2023-09-22 111051

@237dmitry commented on GitHub (Sep 22, 2023): > Hover it! It shows up as an "invalid URI"! Perhabs `file://` ? In my environment I could not reproduce. ![Screenshot 2023-09-22 111051](https://github.com/microsoft/terminal/assets/78153320/da7d8178-0829-4251-84b1-dfb5294e4f80)
claunia commented 2026-01-31 07:16:29 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 22, 2023):

@237dmitry The issue only reproduced on a recent version off of main.

This happens because we use IdnToAscii incorrectly. It's designed for domain names, not for entire URLs, and so it fails to work for inputs >63 characters.

@lhecker commented on GitHub (Sep 22, 2023): @237dmitry The issue only reproduced on a recent version off of main. This happens because we use `IdnToAscii` incorrectly. It's designed for domain names, not for entire URLs, and so it fails to work for inputs >63 characters.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl In-PR Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?