starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Double check how we reflow for a huge height delta #20548

New Issue
Open
opened 2026-01-31 07:17:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 07:17:14 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 26, 2023).

Yes, exactly that. I did it for this test specifically:
fc4a37ee91/src/buffer/out/ut_textbuffer/ReflowTests.cpp (L294-L315)

$ is the cursor. false in each line means that it has an explicit newline (true = force wrap).
It has a lot of comments about bugs in the old implementation, which is why the entire text past the cursor fits into the new buffer. In the new, fixed implementation the false = explicit newlines are correctly handled and so it doesn't fit anymore:
6374aece11/src/buffer/out/ut_textbuffer/ReflowTests.cpp (L294-L315)

Basically I had to make a choice over whether I:

  • continue copying until all text in the old buffer has been consumed.
    If the new cursor position is now somewhere at a negative Y, we just put it at (0,0).
  • stop copying at some point to prevent the cursor from being lost.

I chose the latter. What do you think we should do?

Originally posted by @lhecker in https://github.com/microsoft/terminal/pull/15701#discussion_r1332947703

continue copying until all text in the old buffer has been consumed.
If the new cursor position is now somewhere at a negative Y, we just put it at (0,0).

Probably that one, right? Like, the priority should be to keep the newest text, right?

... this is currently a 1.19 candidate. I'm okay to say merge as is and iterate in the first hotfix since

  1. we're out of time and I'm about to log out for the day
  2. this is a RARE edge case
  3. this is more goodness than badness)

This is an interesting case. I'm honestly not sure how to handle it -- we should look at how other terminals that do reflow handle it?

Originally created by @zadjii-msft on GitHub (Sep 26, 2023). Yes, exactly that. I did it for this test specifically: https://github.com/microsoft/terminal/blob/fc4a37ee9189f2f7335ab942d50381a38a03acf2/src/buffer/out/ut_textbuffer/ReflowTests.cpp#L294-L315 `$` is the cursor. `false` in each line means that it has an explicit newline (`true` = force wrap). It has a lot of comments about bugs in the old implementation, which is why the entire text past the cursor fits into the new buffer. In the new, fixed implementation the `false` = explicit newlines are correctly handled and so it doesn't fit anymore: https://github.com/microsoft/terminal/blob/6374aece11edbf8b1329d56ab963e6ea2089f83d/src/buffer/out/ut_textbuffer/ReflowTests.cpp#L294-L315 Basically I had to make a choice over whether I: * continue copying until all text in the old buffer has been consumed. If the new cursor position is now somewhere at a negative Y, we just put it at (0,0). * stop copying at some point to prevent the cursor from being lost. I chose the latter. What do you think we should do? _Originally posted by @lhecker in https://github.com/microsoft/terminal/pull/15701#discussion_r1332947703_ > > continue copying until all text in the old buffer has been consumed. > > If the new cursor position is now somewhere at a negative Y, we just put it at (0,0). > > Probably that one, right? Like, the priority should be to keep the newest text, right? > > ... this is currently a 1.19 candidate. I'm okay to say merge as is and iterate in the first hotfix since > > 1. we're out of time and I'm about to log out for the day > 2. this is a RARE edge case > 3. this is more goodness than badness) > This is an interesting case. I'm honestly not sure how to handle it -- we should look at how other terminals that do reflow handle it?
claunia added the Product-ConhostArea-OutputIssue-Task labels 2026-01-31 07:17:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Task Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?