starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.19] Random lags on focus and unfocus #20550

New Issue
Closed
opened 2026-01-31 07:17:15 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:17:15 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Sep 26, 2023).

Windows Terminal version

1.19.2682.0

Windows build number

No response

Other Software

No response

Steps to reproduce

  • Run rainbowbench -ng
  • Focus and unfocus the application

Expected Behavior

rainbowbench should show something along the lines of

22486 fps | 83132 kcg/s

or about half that on a slower CPU.

Focusing/Unfocusing doesn't randomly lag the renderer.

Actual Behavior

7436 fps | 26605 kcg/s

and it randomly lags.

Originally created by @lhecker on GitHub (Sep 26, 2023). ### Windows Terminal version 1.19.2682.0 ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce * Run `rainbowbench -ng` * Focus and unfocus the application ### Expected Behavior `rainbowbench` should show something along the lines of ``` 22486 fps | 83132 kcg/s ``` or about half that on a slower CPU. Focusing/Unfocusing doesn't randomly lag the renderer. ### Actual Behavior ``` 7436 fps | 26605 kcg/s ``` and it randomly lags.
claunia added the Area-RenderingIssue-BugNeeds-Tag-FixProduct-TerminalPriority-1 labels 2026-01-31 07:17:15 +00:00
claunia commented 2026-01-31 07:17:17 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 27, 2023):

The throughput issue occurs because I now flush a ConPTY frame whenever DoWriteConsole returns. Previously, ConPTY would only flush it after up to 16.7ms when the next rendering iteration occurs. I think this is fine, because I'd like to move away from the asynchronous nature of ConPTY over to a direct translation.

I can't quite figure out why I had lags though. It's been gone ever since I disabled G-SYNC and it hasn't come back even after enabling G-SYNC. Weird.

@lhecker commented on GitHub (Sep 27, 2023): The throughput issue occurs because I now flush a ConPTY frame whenever `DoWriteConsole` returns. Previously, ConPTY would only flush it after up to 16.7ms when the next rendering iteration occurs. I think this is fine, because I'd like to move away from the asynchronous nature of ConPTY over to a direct translation. I can't quite figure out why I had lags though. It's been gone ever since I disabled G-SYNC and it hasn't come back even after enabling G-SYNC. Weird.
claunia commented 2026-01-31 07:17:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 27, 2023):

This seems related to #12336, but not exactly the same.

Hypothesis: we should stop WriteFileing in EndPaint, because that blocks the I/O thread until ConPtyConnection ReadFiles ((baseless assumption))

@zadjii-msft commented on GitHub (Sep 27, 2023): This seems related to #12336, but not exactly the same. Hypothesis: we should stop `WriteFile`ing in `EndPaint`, because that blocks the I/O thread until ConPtyConnection `ReadFile`s ((baseless assumption))
claunia commented 2026-01-31 07:17:17 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 9, 2025):

The lags aren't reproducible for me anymore.

@lhecker commented on GitHub (Jul 9, 2025): The lags aren't reproducible for me anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?