v1.18.2681.0 breaks Powershell/WSL2/Commandline Shell (only tested on 23H2 (10.0.22631.2361)) (error 2147942487 (0x80070057)) #20568

New Issue

@lhecker commented on GitHub (Sep 28, 2023):

Does the issue happen if you use our portable version from our release page (the .zip files)? https://github.com/microsoft/terminal/releases/tag/v1.18.2681.0

@lhecker commented on GitHub (Sep 28, 2023): Does the issue happen if you use our portable version from our release page (the .zip files)? https://github.com/microsoft/terminal/releases/tag/v1.18.2681.0

claunia commented

@sjansen1 commented on GitHub (Sep 28, 2023):

@lhecker i uninstall windows-terminal and downloaded and unpacked https://github.com/microsoft/terminal/releases/download/v1.18.2681.0/Microsoft.WindowsTerminal_1.18.2681.0_x64.zip and started WindowsTerminal.exe

Same issue:

Powershell:
Interner Windows PowerShell-Fehler. Fehler 8009001d beim Laden der verwalteten Windows PowerShell.
[Verarbeitung des Prozesses mit Code 4294901760 (0xffff0000) beendet]

WSL:
Der RPC-Aufruf enthält ein Handle, das sich vom deklarierten Handletyp unterscheidet.
Error code: Wsl/Service/0x8007072c

Commandline:
Still missing a hugh amount of environment variables in comparison to a started cmd.exe

@sjansen1 commented on GitHub (Sep 28, 2023): @lhecker i uninstall windows-terminal and downloaded and unpacked https://github.com/microsoft/terminal/releases/download/v1.18.2681.0/Microsoft.WindowsTerminal_1.18.2681.0_x64.zip and started WindowsTerminal.exe Same issue: Powershell: Interner Windows PowerShell-Fehler. Fehler 8009001d beim Laden der verwalteten Windows PowerShell. [Verarbeitung des Prozesses mit Code 4294901760 (0xffff0000) beendet] WSL: Der RPC-Aufruf enthält ein Handle, das sich vom deklarierten Handletyp unterscheidet. Error code: Wsl/Service/0x8007072c Commandline: Still missing a hugh amount of environment variables in comparison to a started cmd.exe

claunia commented

@lhecker commented on GitHub (Sep 28, 2023):

Ah I think I have an idea what's going on. Your environment variables are broken.

Can you launch regedit, navigate to HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment and make a screenshot of what you see?

@lhecker commented on GitHub (Sep 28, 2023): Ah I think I have an idea what's going on. Your environment variables are broken. Can you launch `regedit`, navigate to `HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment` and make a screenshot of what you see?

claunia commented

@sjansen1 commented on GitHub (Sep 28, 2023):

Ah I think I have an idea what's going on. Your environment variables are broken.

Can you launch regedit, navigate to HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment and make a screenshot of what you see?

Path is incomplete in the screenshot, it is: C:\Program Files\Amazon Corretto\jdk17.0.8_8\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\WindowsPowerShell\Scripts;C:\Program Files\VSCodium\bin;C:\Program Files\dotnet;C:\Program Files\Tailscale\

@sjansen1 commented on GitHub (Sep 28, 2023): > Ah I think I have an idea what's going on. Your environment variables are broken. > > Can you launch `regedit`, navigate to `HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment` and make a screenshot of what you see? <img width="1124" alt="image" src="https://github.com/microsoft/terminal/assets/8289580/73c8e9ea-0f76-4219-ac50-329833139cff"> Path is incomplete in the screenshot, it is: C:\Program Files\Amazon Corretto\jdk17.0.8_8\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\WindowsPowerShell\Scripts;C:\Program Files\VSCodium\bin;C:\Program Files\dotnet\;C:\Program Files\Tailscale\

claunia commented

@lhecker commented on GitHub (Sep 28, 2023):

And what about the contents of HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion? Does it look like this?

When you open the permissions dialog here:

and you select "Users" does it look like this?

@lhecker commented on GitHub (Sep 28, 2023): And what about the contents of `HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion`? Does it look like this? ![image](https://github.com/microsoft/terminal/assets/2256941/000440db-a9dc-474f-aff5-a87af3cd664e) When you open the permissions dialog here: ![image](https://github.com/microsoft/terminal/assets/2256941/51edb1fb-09e1-4b07-8273-7b4e02c462b2) and you select "Users" does it look like this? ![image](https://github.com/microsoft/terminal/assets/2256941/4d42d043-b539-4124-b75c-72765de53d34)

claunia commented

@sjansen1 commented on GitHub (Sep 28, 2023):

So far it looks similar to your settings.

@sjansen1 commented on GitHub (Sep 28, 2023): <img width="383" alt="image" src="https://github.com/microsoft/terminal/assets/8289580/2f92b1f5-82d7-440f-a33b-b150674257e3"> ![image](https://github.com/microsoft/terminal/assets/8289580/978590c4-e9eb-400c-92c5-dbe4053f27d7) So far it looks similar to your settings.

claunia commented

@DefectInsect commented on GitHub (Sep 28, 2023):

I have the same issues with the recent release. PATH is Null for CMD and PSCore. PowerShell 5.1 won't start with the aformentioned error. Terminal's completely unusable.

Windows 10 22H2, set to german.

@DefectInsect commented on GitHub (Sep 28, 2023): I have the same issues with the recent release. PATH is Null for CMD and PSCore. PowerShell 5.1 won't start with the aformentioned error. Terminal's completely unusable. Windows 10 22H2, set to german.

claunia commented

@lhecker commented on GitHub (Sep 28, 2023):

Does one of you feel comfortable to run a piece of C++ code under a debugger on your system?

@lhecker commented on GitHub (Sep 28, 2023): Does one of you feel comfortable to run a piece of C++ code under a debugger on your system?

claunia commented

@sjansen1 commented on GitHub (Sep 28, 2023):

Does one of you feel comfortable to run a piece of C++ code under a debugger on your system?

MDE is a bit picky with unsigned code, but i can try.

@sjansen1 commented on GitHub (Sep 28, 2023): > Does one of you feel comfortable to run a piece of C++ code under a debugger on your system? MDE is a bit picky with unsigned code, but i can try.

claunia commented

@sjansen1 commented on GitHub (Sep 28, 2023):

My private machine show the same issue after the update, another machine with 23h2.

@sjansen1 commented on GitHub (Sep 28, 2023): My private machine show the same issue after the update, another machine with 23h2.

claunia commented

@sayandipdutta commented on GitHub (Oct 2, 2023):

I am facing similar issue with preview version 1.19.2682.0, windows 25951.1010. Any idea on what's going on?

@sayandipdutta commented on GitHub (Oct 2, 2023): I am facing similar issue with preview version 1.19.2682.0, windows 25951.1010. Any idea on what's going on?

claunia commented

@zadjii-msft commented on GitHub (Oct 2, 2023):

Analyzing a bit, it seems to be that OpenConsole.exe never gets around to trying to start the exe (in procmon, there is no "pwsh" in the entire capture from OpenConsole.exe on a machine where this is broken).

Note that e.g. ./OpenConsole.exe pwsh.exe or similar works ok.

From #16087

@zadjii-msft commented on GitHub (Oct 2, 2023): > Analyzing a bit, it seems to be that OpenConsole.exe never gets around to trying to start the exe (in procmon, there is no "pwsh" in the entire capture from OpenConsole.exe on a machine where this is broken). > > Note that e.g. `./OpenConsole.exe pwsh.exe` or similar works ok. From #16087

claunia commented

@zadjii-msft commented on GitHub (Oct 2, 2023):

Here's a theory - y'all might be able to get unblocked by setting:

"profiles":
{
    "defaults": 
    {
        "compatibility.reloadEnvironmentVariables": false
    },
    "list":
    [
        // ...
    ]
}

in your settings.json. Now, why that regressed, and seemingly only in 10.0.22631.2361 sure is curious.

If you're seeing this, is your Path under HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment a REG_SZ or a REG_EXPAND_SZ?

@zadjii-msft commented on GitHub (Oct 2, 2023): Here's a theory - y'all might be able to get unblocked by setting: ```json "profiles": { "defaults": { "compatibility.reloadEnvironmentVariables": false }, "list": [ // ... ] } ``` in your settings.json. Now, why that regressed, and seemingly only in `10.0.22631.2361` sure is curious. If you're seeing this, is your `Path` under `HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment` a `REG_SZ` or a `REG_EXPAND_SZ`?

claunia commented

@sjansen1 commented on GitHub (Oct 2, 2023):

If you're seeing this, is your Path under HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment a REG_SZ or a REG_EXPAND_SZ?

@zadjii-msft Path is a REG_SZ

Setting "compatibility.reloadEnvironmentVariables": false in settings.json has no effect.

Edit: i have to correct myself, Commandshell and WSL works, Powershell still fails with 8009001d.

@sjansen1 commented on GitHub (Oct 2, 2023): > If you're seeing this, is your `Path` under `HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment` a `REG_SZ` or a `REG_EXPAND_SZ`? @zadjii-msft Path is a REG_SZ **Setting "compatibility.reloadEnvironmentVariables": false** in settings.json has no effect. Edit: i have to correct myself, Commandshell and WSL works, Powershell still fails with 8009001d.

claunia commented

@cyanite commented on GitHub (Oct 2, 2023):

@zadjii-msft, the addition of "compatibility.reloadEnvironmentVariables": false has the effect that now every new tab you open works fine, just not the initial one (which fails like before). So PowerShell also works, if you just press + after the initial one has failed. All of them do.

As for the registry, it's a REG_EXPAND_SZ key for the affected machine.

@cyanite commented on GitHub (Oct 2, 2023): @zadjii-msft, the addition of `"compatibility.reloadEnvironmentVariables": false` has the effect that now every _new_ tab you open works fine, just not the initial one (which fails like before). So PowerShell also works, if you just press + after the initial one has failed. All of them do. As for the registry, it's a REG_EXPAND_SZ key for the affected machine.

claunia commented

@sjansen1 commented on GitHub (Oct 2, 2023):

@zadjii-msft, the addition of "compatibility.reloadEnvironmentVariables": false has the effect that now every new tab you open works fine, just not the initial one (which fails like before). So PowerShell also works, if you just press + after the initial one has failed. All of them do.

you are right, opening another powershell tab works.

@sjansen1 commented on GitHub (Oct 2, 2023): > @zadjii-msft, the addition of `"compatibility.reloadEnvironmentVariables": false` has the effect that now every _new_ tab you open works fine, just not the initial one (which fails like before). So PowerShell also works, if you just press + after the initial one has failed. All of them do. you are right, opening another powershell tab works.

claunia commented

@lhecker commented on GitHub (Oct 3, 2023):

Sorry for the delay, here's the C++ code: https://gist.github.com/lhecker/f0bd197c8aa8ecf1aeb6505115bb7646
It would be very helpful if someone could try to compile and run it under a debugger. It should pause at some point during the execution. A stack trace and maybe a screenshot of the local variables would be nice. 🙂

But yesterday we realized we can also just use a WPR trace (see steps here) to get a hold of the WIL error logs, so if the above doesn't work out (because it's rather cumbersome), there's still another way to go about this.

@lhecker commented on GitHub (Oct 3, 2023): Sorry for the delay, here's the C++ code: https://gist.github.com/lhecker/f0bd197c8aa8ecf1aeb6505115bb7646 It would be very helpful if someone could try to compile and run it under a debugger. It should pause at some point during the execution. A stack trace and maybe a screenshot of the local variables would be nice. 🙂 But yesterday we realized we can also just use a WPR trace ([see steps here](https://github.com/microsoft/terminal/wiki/Toubleshooting-Tips#capturing-a-debug-etl-trace)) to get a hold of the WIL error logs, so if the above doesn't work out (because it's rather cumbersome), there's still another way to go about this.

claunia commented

6489f6b39d/src/inc/til/env.h (L226-L232)

@zadjii-msft commented on GitHub (Oct 3, 2023):

Also, squinting at the code:

That calls the string version of wil::TryGetEnvironmentVariableW

be13859134/include/wil/win32_helpers.h (L604-L609)

    string_type TryGetEnvironmentVariableW(_In_ PCWSTR key)
    {
        string_type result{};
        THROW_IF_FAILED((wil::TryGetEnvironmentVariableW<string_type, initialBufferLength>(key, result)));
        return result;
    }

So that can throw if we don't find the env var. Then in regenerate, we do:

6489f6b39d/src/inc/til/env.h (L537-L560)

Huh, looks like we get a bunch of variables. I can't help but think one of those blows up in this scenario. The aformentioned script under a debugger might tell us which. But maybe all those need to be try_get or something.

@zadjii-msft commented on GitHub (Oct 3, 2023): Also, squinting at the code: https://github.com/microsoft/terminal/blob/6489f6b39daaef634dd0e56e50afa8866f0103c7/src/inc/til/env.h#L226-L232 That calls the string version of `wil::TryGetEnvironmentVariableW` https://github.com/microsoft/wil/blob/be13859134711a1b1206da484f2f6b8b41feb883/include/wil/win32_helpers.h#L604-L609 ```c++ string_type TryGetEnvironmentVariableW(_In_ PCWSTR key) { string_type result{}; THROW_IF_FAILED((wil::TryGetEnvironmentVariableW<string_type, initialBufferLength>(key, result))); return result; } ``` So that can throw if we don't find the env var. Then in `regenerate`, we do: https://github.com/microsoft/terminal/blob/6489f6b39daaef634dd0e56e50afa8866f0103c7/src/inc/til/env.h#L537-L560 Huh, looks like we `get` a bunch of variables. I can't help but think one of those blows up in this scenario. The [aformentioned](https://github.com/microsoft/terminal/issues/16051#issuecomment-1744790570) script under a debugger might tell us which. But maybe all those need to be `try_get` or something.

claunia commented