starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Moving tabs out of terminal doesn't work properly with startupActions #20569

New Issue
Closed
opened 2026-01-31 07:17:50 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:17:50 +00:00
Owner
Copy Link

Originally created by @Jackenmen on GitHub (Sep 28, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

1.18.2681.0

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

  1. Set startupActions in the Terminal's configuration (you can set config to the below JSON, it seems that the terminal will auto-generate the rest after and it's still reproducible):
{
    "startupActions": "new-tab -p \"PowerShell\" ; new-tab -p \"Command Prompt\""
}
  1. Start a terminal.
  2. In the PowerShell tab, run some command to get some output (I use this to show whether it's still the same tab after dragging out)
  3. Try dragging out the PowerShell tab.
  4. Notice the wrong behaviour

Expected Behavior

I expected the new window to contain the dragged-out tab, without startupActions being ran.

Actual Behavior

The new window does not contain the dragged-out tab and is started as it was the first terminal window per the startupActions. The old window no longer has the dragged-out tab either.

https://github.com/microsoft/terminal/assets/6032823/64705355-6d95-44c6-9ea5-32c0fe54025d

Originally created by @Jackenmen on GitHub (Sep 28, 2023). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 1.18.2681.0 ### Windows build number 10.0.19045.3448 ### Other Software _No response_ ### Steps to reproduce 1. Set `startupActions` in the Terminal's configuration (you can set config to the below JSON, it seems that the terminal will auto-generate the rest after and it's still reproducible): ```json { "startupActions": "new-tab -p \"PowerShell\" ; new-tab -p \"Command Prompt\"" } ``` 2. Start a terminal. 3. In the PowerShell tab, run some command to get some output (I use this to show whether it's still the same tab after dragging out) 4. Try dragging out the PowerShell tab. 5. Notice the wrong behaviour ### Expected Behavior I expected the new window to contain the dragged-out tab, without `startupActions` being ran. ### Actual Behavior The new window does not contain the dragged-out tab and is started as it was the first terminal window per the `startupActions`. The old window no longer has the dragged-out tab either. https://github.com/microsoft/terminal/assets/6032823/64705355-6d95-44c6-9ea5-32c0fe54025d
claunia commented 2026-01-31 07:17:52 +00:00
Author
Owner
Copy Link

@Jackenmen commented on GitHub (Sep 30, 2023):

Do I understand correctly that the blocking severity applies only to the 1.20 release, not 1.18 or 1.19?
I'm just kind of trying to determine whether I'll have to figure out a workaround for this (maybe just a shell alias that opens all the terminal windows instead of using startup actions) or if there's any chance I can reasonably wait it out and see it resolved sooner since I have already managed to accidentally kill a shell with some long-running process in it by holding the mouse button for a bit too long and dragging the tab out 😄

@Jackenmen commented on GitHub (Sep 30, 2023): Do I understand correctly that the blocking severity applies only to the 1.20 release, not 1.18 or 1.19? I'm just kind of trying to determine whether I'll have to figure out a workaround for this (maybe just a shell alias that opens all the terminal windows instead of using startup actions) or if there's any chance I can reasonably wait it out and see it resolved sooner since I have already managed to accidentally kill a shell with some long-running process in it by holding the mouse button for a bit too long and dragging the tab out 😄
claunia commented 2026-01-31 07:17:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2023):

Oh, nah, we're planning on fixing this asap. We're experimenting with some new ways of tracking "blocking" and servicing bugs, since our old method wasn't working great. Alas, that board is private right now (because I don't want folks exposed to the WIP nature of it).

Needless to say, this is on the radar for a 1.18 servicing release (probably not the first one, but soonTM

@zadjii-msft commented on GitHub (Oct 2, 2023): Oh, nah, we're planning on fixing this asap. We're experimenting with some new ways of tracking "blocking" and servicing bugs, since our old method wasn't working great. Alas, that board is private right now (because I don't want folks exposed to the WIP nature of it). Needless to say, this is on the radar for a 1.18 servicing release (probably not the first one, but soon<sup>TM
claunia commented 2026-01-31 07:17:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2023):

Notes:

@zadjii-msft commented on GitHub (Oct 2, 2023): Notes: * `TerminalWindow::Create` doesn't check `_initialContentArgs` near the top. It just does: https://github.com/microsoft/terminal/blob/1669036e595bcc8a100e7b8b679dc8f4748f2eb7/src/cascadia/TerminalApp/TerminalWindow.cpp#L207-L210. I bet that will blow away the content args with the `startupActions`, even if it shouldn't.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing In-PR Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20569
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?