starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Git Bash bold in One Half Light runs text together #20671

New Issue
Closed
opened 2026-01-31 07:20:43 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 07:20:43 +00:00
Owner
Copy Link

Originally created by @garretwilson on GitHub (Oct 13, 2023).

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.0

Other Software

git version 2.42.0.windows.2

Steps to reproduce

I'm using Git Bash with the "One Half Light" color scheme. I want to show something in bold, like this:

echo "Uploading $(tput bold)some-really-long-filename.zip$(tput sgr0) to the server ..."

At first the bold didn't show up any differently than the regular text. Then I went to "Text Formatting" and changed "Intense text style" to "Bold font". Now bold shows up. But often it runs the text together.

Expected Behavior

I wanted bold text, without running the text together. Here is how it looks (as expected) in the terminal of VS Code.

vs-code-bold

Actual Behavior

Microsoft Terminal jams some of the words together. Note the space after ….zip completely disappeared.

microsoft-termina-bold

The point of using bold was to make certain things stand out, but this bug defeats the purpose by jumbling things together.

The output of Maven, for example, is a bit garbled, because many of the goal identifiers are shoved over, "eating" the space of the words after them.

This only seems to happen of the run of bold text is sufficiently long.

My guess off the top of my head is that the bold algorithm is calculating the space taken up based upon the non-bold text, and not taking into account that the bold text is wider. Over a few characters this per-letter error accumulates. Just a hunch.

Maybe you could just add an option to use the VS Code terminal renderer in Microsoft Terminal?

Originally created by @garretwilson on GitHub (Oct 13, 2023). ### Windows Terminal version 1.17.11461.0 ### Windows build number 10.0.19045.0 ### Other Software git version 2.42.0.windows.2 ### Steps to reproduce I'm using Git Bash with the "One Half Light" color scheme. I want to show something in bold, like this: ```bash echo "Uploading $(tput bold)some-really-long-filename.zip$(tput sgr0) to the server ..." ``` At first the bold didn't show up any differently than the regular text. Then I went to "Text Formatting" and changed "Intense text style" to "Bold font". Now bold shows up. But often it runs the text together. ### Expected Behavior I wanted bold text, without running the text together. Here is how it looks (as expected) in the terminal of VS Code. ![vs-code-bold](https://github.com/microsoft/terminal/assets/627125/5712ad73-f9c8-449c-aee3-1692236db3e3) ### Actual Behavior Microsoft Terminal jams some of the words together. Note the space after `….zip` completely disappeared. ![microsoft-termina-bold](https://github.com/microsoft/terminal/assets/627125/05312e36-d0fe-4e1a-b2b1-ed4400190e28) The point of using bold was to make certain things stand out, but this bug defeats the purpose by jumbling things together. The output of Maven, for example, is a bit garbled, because many of the goal identifiers are shoved over, "eating" the space of the words after them. This only seems to happen of the run of bold text is sufficiently long. My guess off the top of my head is that the bold algorithm is calculating the space taken up based upon the non-bold text, and not taking into account that the bold text is wider. Over a few characters this per-letter error accumulates. Just a hunch. Maybe you could just add an option to use the VS Code terminal renderer in Microsoft Terminal?
claunia added the Needs-TriageIssue-BugNeeds-Attention labels 2026-01-31 07:20:43 +00:00
claunia commented 2026-01-31 07:20:44 +00:00
Author
Owner
Copy Link

@garretwilson commented on GitHub (Oct 13, 2023):

This happens on the "Solarized Light" color scheme as well. Must be a general Microsoft Terminal rendering bug.

@garretwilson commented on GitHub (Oct 13, 2023): This happens on the "Solarized Light" color scheme as well. Must be a general Microsoft Terminal rendering bug.
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@garretwilson commented on GitHub (Oct 13, 2023):

Unfortunately rendering bold as "Bright colors" (the default" doesn't seem to make any difference at all, so it looks like I'll have to abandon Microsoft Terminal and use VS Code terminal for almost everything until this is fixed. I guess if I need two directories open I can just add more terminal tabs in VS Code.

@garretwilson commented on GitHub (Oct 13, 2023): Unfortunately rendering bold as "Bright colors" (the default" doesn't seem to make any difference at all, so it looks like I'll have to abandon Microsoft Terminal and use VS Code terminal for almost everything until this is fixed. I guess if I need two directories open I can just add more terminal tabs in VS Code.
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 13, 2023):

I think this was fixed in 1.18 or 1.19 - Can you double check in Terminal Preview/?

@zadjii-msft commented on GitHub (Oct 13, 2023): I _think_ this was fixed in 1.18 or 1.19 - Can you double check in [Terminal Preview](https://aka.ms/terminal-preview)/?
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@garretwilson commented on GitHub (Oct 13, 2023):

I think this was fixed in 1.18 or 1.19

Good news! Thanks for letting me know.

Can you double check in Terminal Preview/?

Unfortunately I just don't have the time at the moment, but I'll be happy to check and report back once those versions are released and my installation gets upgraded.

@garretwilson commented on GitHub (Oct 13, 2023): > I _think_ this was fixed in 1.18 or 1.19 Good news! Thanks for letting me know. > Can you double check in [Terminal Preview](https://aka.ms/terminal-preview)/? Unfortunately I just don't have the time at the moment, but I'll be happy to check and report back once those versions are released and my installation gets upgraded.
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 13, 2023):

Good news! You can actually just immediatly install the update by downloading the .msixbundle from our releases page:

@zadjii-msft commented on GitHub (Oct 13, 2023): Good news! You can actually just immediatly install the update by downloading the `.msixbundle` from our releases page: * Preview https://github.com/microsoft/terminal/releases/tag/v1.19.2831.0 * Stable https://github.com/microsoft/terminal/releases/tag/v1.18.2822.0
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@garretwilson commented on GitHub (Oct 20, 2023):

I think this was fixed in 1.18 or 1.19

It's not fixed in v1.18.2822.0 at least.

@garretwilson commented on GitHub (Oct 20, 2023): > I _think_ this was fixed in 1.18 or 1.19 It's not fixed in v1.18.2822.0 at least.
claunia commented 2026-01-31 07:20:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2023):

Ah shoot - can you check again and make sure that the new text renderer is enabled? I forgot that it's disabled by default in the Stable builds (but is enabled by default in preview)

image

@zadjii-msft commented on GitHub (Oct 25, 2023): Ah shoot - can you check again and make sure that the new text renderer is enabled? I forgot that it's disabled by default in the Stable builds (but is enabled by default in preview) ![image](https://github.com/microsoft/terminal/assets/18356694/49a165e6-9105-418d-af77-172a3c174e0c)
claunia commented 2026-01-31 07:20:46 +00:00
Author
Owner
Copy Link

@garretwilson commented on GitHub (Oct 25, 2023):

Woohoo! 🎉 That was it! I needed to turn on "Use the new text renderer".

Very nice to see a bug getting fixed. Thanks!

@garretwilson commented on GitHub (Oct 25, 2023): Woohoo! 🎉 That was it! I needed to turn on "Use the new text renderer". Very nice to see a bug getting fixed. Thanks!
claunia commented 2026-01-31 07:20:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 26, 2023):

Amazing, thanks for confirming! That new engine will eventually be made the default - we're currently collecting reliability (and bug fix!) data on it. Let us know if you find anything weird!

@DHowett commented on GitHub (Oct 26, 2023): Amazing, thanks for confirming! That new engine will eventually be made the default - we're currently collecting reliability (and bug fix!) data on it. Let us know if you find anything weird!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?