starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Quake mode full screen doesn't reopen with full heightwhen closing and resummoning #20675

New Issue
Open
opened 2026-01-31 07:20:54 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 07:20:54 +00:00
Owner
Copy Link

Originally created by @Lolle2000la on GitHub (Oct 15, 2023).

Windows Terminal version

1.18.2681.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

On a multi-monitor setup (primary monitor center: 2560x1400, other monitor left: 1920x1080). Does not happen with only one display (tested on Surface Pro 9)

  1. Summon quake mode window with the shortcut (bound to F10 on my machine)
    image
  2. Change to full screen with F11
    image
  3. Hide the quake mode window again
  4. Resummon the window
    image

Expected Behavior

Quake mode window reappears again in full screen mode, covering my screen in its entirety.

Actual Behavior

Quake mode window reappears covering around half of the montor. Pressing F11 once restores the normal quake window view, pressing it again puts in to full screen properly again.

Originally created by @Lolle2000la on GitHub (Oct 15, 2023). ### Windows Terminal version 1.18.2681.0 ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce On a multi-monitor setup (primary monitor center: 2560x1400, other monitor left: 1920x1080). Does not happen with only one display (tested on Surface Pro 9) 1. Summon quake mode window with the shortcut (bound to F10 on my machine) ![image](https://github.com/microsoft/terminal/assets/16977204/c6b5e6fb-5082-420d-b27f-7af4087a8244) 2. Change to full screen with F11 ![image](https://github.com/microsoft/terminal/assets/16977204/e51e88ca-b379-4e08-b74d-30749fb8820b) 3. Hide the quake mode window again 4. Resummon the window ![image](https://github.com/microsoft/terminal/assets/16977204/abc5b6b3-07d7-4f08-ba69-3383ba1a36c5) ### Expected Behavior Quake mode window reappears again in full screen mode, covering my screen in its entirety. ### Actual Behavior Quake mode window reappears covering around half of the montor. Pressing F11 once restores the normal quake window view, pressing it again puts in to full screen properly again.
claunia added the Issue-BugProduct-TerminalArea-Windowing labels 2026-01-31 07:20:54 +00:00
claunia commented 2026-01-31 07:20:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 16, 2023):

Huh. This is a bit like #12594, but definitely different. Thanks for the report!

@zadjii-msft commented on GitHub (Oct 16, 2023): Huh. This is a bit like #12594, but definitely different. Thanks for the report!
claunia commented 2026-01-31 07:20:55 +00:00
Author
Owner
Copy Link

@Lolle2000la commented on GitHub (Oct 16, 2023):

Having read this comment in the issue you referenced, I've tried whether the issue also appears on my 1080p monitor to the left of my primary monitor, and it doesn't weidly enough. Could it be that full screen remembers the position correctly but not the height? Though the fact that it doesn't restore with 1080p height on the primary 1440p monitor does speak against it fetching the false values I think.

@Lolle2000la commented on GitHub (Oct 16, 2023): Having read [this](https://github.com/microsoft/terminal/issues/12594#issuecomment-1054355346_) comment in the issue you referenced, I've tried whether the issue also appears on my 1080p monitor to the left of my primary monitor, and it doesn't weidly enough. Could it be that full screen remembers the position correctly but not the height? Though the fact that it doesn't restore with 1080p height on the primary 1440p monitor does speak against it fetching the false values I think.
claunia commented 2026-01-31 07:20:55 +00:00
Author
Owner
Copy Link

@Lolle2000la commented on GitHub (Oct 16, 2023):

Ok I've set my primary monitor to be the monitor on the left in the windows settings, and after a restart of terminal the quake mode windows full screen gets correctly restored on my primary monitor but not the 1080p monitor.

I've also added the action I use to summon quake mode below, if that helps with diagnosing issues:

{
    "command": 
    {
        "action": "globalSummon",
        "desktop": "toCurrent",
        "dropdownDuration": 0,
        "monitor": "toMouse",
        "name": "_quake",
        "toggleVisibility": true
    },
    "keys": "f10"
}
@Lolle2000la commented on GitHub (Oct 16, 2023): Ok I've set my primary monitor to be the monitor on the left in the windows settings, and after a restart of terminal the quake mode windows full screen gets correctly restored on my primary monitor but not the 1080p monitor. I've also added the action I use to summon quake mode below, if that helps with diagnosing issues: ```json { "command": { "action": "globalSummon", "desktop": "toCurrent", "dropdownDuration": 0, "monitor": "toMouse", "name": "_quake", "toggleVisibility": true }, "keys": "f10" } ```
claunia commented 2026-01-31 07:20:55 +00:00
Author
Owner
Copy Link

@Digital-gitz commented on GitHub (Feb 14, 2024):

        {
            "command": 
            {
                "action": "globalSummon",
                "desktop": "toCurrent",
                "MaximizeAfterToggle": true,
                "dropdownDuration": 0,
                "monitor": "toMouse",
                "name": "_quake",
                "toggleVisibility": true,
                "suppressApplicationTitle": true,
                "launchMode": "fullscreen"
            },
            "keys": "win+`"
        }

I have tried setting launch mode to full-screen just dose not work Docs not so helpful. this site seems to get it with max toggle but dose not work for me. link

@Digital-gitz commented on GitHub (Feb 14, 2024): ``` { "command": { "action": "globalSummon", "desktop": "toCurrent", "MaximizeAfterToggle": true, "dropdownDuration": 0, "monitor": "toMouse", "name": "_quake", "toggleVisibility": true, "suppressApplicationTitle": true, "launchMode": "fullscreen" }, "keys": "win+`" } ``` I have tried setting launch mode to full-screen just dose not work [Docs ](https://learn.microsoft.com/en-us/windows/terminal/customize-settings/actions) not so helpful. this site seems to get it with max toggle but dose not work for me. [link](https://flyingpie.github.io/windows-terminal-quake/settings/size-and-align/)
claunia commented 2026-01-31 07:20:55 +00:00
Author
Owner
Copy Link

@micmarty-deepsense commented on GitHub (May 24, 2024):

any update on this?

@micmarty-deepsense commented on GitHub (May 24, 2024): any update on this?
claunia commented 2026-01-31 07:20:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2024):

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?
image
That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺️

If someone in the community wants to take a crack at this, I'd more than welcome the help. IslandWindow.cpp is where I'd start by looking. We'd probably need to cache both size (for #12594) and fullscreen/maximized state (this thread) when the window gets dismissed, and use that size when it gets summoned.

(IIRC there's like, a WINODWPLACEMENT struct that might be what we're looking for)

@zadjii-msft commented on GitHub (May 24, 2024): Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button? ![image](https://user-images.githubusercontent.com/18356694/91237459-5cbb0c80-e700-11ea-9347-b9b1ec2813b1.png) That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺️ --- If someone in the community wants to take a crack at this, I'd more than welcome the help. `IslandWindow.cpp` is where I'd start by looking. We'd probably need to cache both size (for #12594) and fullscreen/maximized state (this thread) when the window gets dismissed, and use that size when it gets summoned. (IIRC there's like, a WINODWPLACEMENT struct that might be what we're looking for)
claunia commented 2026-01-31 07:20:56 +00:00
Author
Owner
Copy Link

@marcelbrode commented on GitHub (Jun 17, 2024):

I want to share some observations, since I suffer the same issue.

It works on my secondary monitor (on the left), which is 16:9, but doesn't work on my main monitor, why is 21:9. I dunno if the resolution or the primary/secondary monitor is a thing, but maybe this helps

@marcelbrode commented on GitHub (Jun 17, 2024): I want to share some observations, since I suffer the same issue. It works on my secondary monitor (on the left), which is 16:9, but doesn't work on my main monitor, why is 21:9. I dunno if the resolution or the primary/secondary monitor is a thing, but maybe this helps
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?