starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

About dialog changes tooltip theme from Light to Dark #20691

New Issue
Open
opened 2026-01-31 07:21:23 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:21:23 +00:00
Owner
Copy Link

Originally created by @strangebit on GitHub (Oct 18, 2023).

Windows Terminal version

1.18.2822.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Use a Dark application theme. Open a new Terminal window and take note of the tooltip theming. Open the About dialog and close it and then recheck tooltip theming.

Expected Behavior

No response

Actual Behavior

I noticed this behaviour today, and I can consistently reproduce it. When I open a new Terminal window, the tooltips for that window are Light themed up until I open the About dialog, and then they become Dark themed (but only for that window). You can see what I mean in the following video:

https://github.com/microsoft/terminal/assets/11712728/cf716feb-d02a-4017-8e56-d35d7b51d2d8

In my settings.json, I'm using this custom Dark theme (the purpose is just to allow me to hide the close buttons on the tabs):

"theme": "dark_no-close-button",
"themes": 
[
    {
        "name": "dark_no-close-button",
        "tab": 
        {
            "background": "terminalBackground",
            "showCloseButton": "never",
            "unfocusedBackground": "#00000000"
        },
        "tabRow": 
        {
            "background": "#2E2E2EFF",
            "unfocusedBackground": "#333333FF"
        },
        "window": 
        {
            "applicationTheme": "dark",
            "useMica": false
        }
    }
]

It happens when I just use "theme": "dark" or "theme": "legacyDark" as well though.

Here are my Windows colour settings:

WindowsColour

Originally created by @strangebit on GitHub (Oct 18, 2023). ### Windows Terminal version 1.18.2822.0 ### Windows build number 10.0.19045.0 ### Other Software _No response_ ### Steps to reproduce Use a Dark application theme. Open a new Terminal window and take note of the tooltip theming. Open the About dialog and close it and then recheck tooltip theming. ### Expected Behavior _No response_ ### Actual Behavior I noticed this behaviour today, and I can consistently reproduce it. When I open a new Terminal window, the tooltips for that window are Light themed up until I open the About dialog, and then they become Dark themed (but only for that window). You can see what I mean in the following video: https://github.com/microsoft/terminal/assets/11712728/cf716feb-d02a-4017-8e56-d35d7b51d2d8 In my `settings.json`, I'm using this custom Dark theme (the purpose is just to allow me to hide the close buttons on the tabs): "theme": "dark_no-close-button", "themes": [ { "name": "dark_no-close-button", "tab": { "background": "terminalBackground", "showCloseButton": "never", "unfocusedBackground": "#00000000" }, "tabRow": { "background": "#2E2E2EFF", "unfocusedBackground": "#333333FF" }, "window": { "applicationTheme": "dark", "useMica": false } } ] It happens when I just use `"theme": "dark"` or `"theme": "legacyDark"` as well though. Here are my Windows colour settings: ![WindowsColour](https://github.com/microsoft/terminal/assets/11712728/2bd75f1f-56de-4155-acf6-cc5cb4907904)
claunia added the Issue-BugProduct-TerminalArea-Theming labels 2026-01-31 07:21:23 +00:00
claunia commented 2026-01-31 07:21:24 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 18, 2023):

LMAO this is hilarious. Yep. That makes sense. We don't do the themingLambda to update the tooltip themes until the About dialog gets opened and goes and updates all "popup" things. Incredible.

I bed we could just do the theming lambda on startup? Though, I dunno if the popup XAML root exists at that time. It might not get created until the first popup is shown, and I dunno if we'll always know when a popup is opened. Hmm.

@zadjii-msft commented on GitHub (Oct 18, 2023): LMAO this is hilarious. Yep. That makes sense. We don't do the themingLambda to update the _tooltip_ themes until the About dialog gets opened and goes and updates all "popup" things. Incredible. I bed we could just do the theming lambda on startup? Though, I dunno if the popup XAML root exists at that time. It might not get created until the first popup is shown, and I dunno if we'll always know when a popup is opened. Hmm.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20691
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?