starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Font variant ignored by copyFormatting #20693

New Issue
Closed
opened 2026-01-31 07:21:25 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:21:25 +00:00
Owner
Copy Link

Originally created by @champignoom on GitHub (Oct 18, 2023).

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Add copyFormatting: "html" to config,
open a markdown document in neovim, type *asdf* **asdf** <u>asfd</u>
image
Then copy it to MS word.

Expected Behavior

Italic, bold and underline should be preserved.

Actual Behavior

The variants are ignored.

image

Originally created by @champignoom on GitHub (Oct 18, 2023). ### Windows Terminal version 1.17.11461.0 ### Windows build number 10.0.19045.0 ### Other Software _No response_ ### Steps to reproduce Add `copyFormatting: "html"` to config, open a markdown document in neovim, type `*asdf* **asdf** <u>asfd</u>` ![image](https://github.com/microsoft/terminal/assets/66909116/a0deae88-9e5c-4d0f-a756-1bd077cdf3db) Then copy it to MS word. ### Expected Behavior Italic, bold and underline should be preserved. ### Actual Behavior The variants are ignored. ![image](https://github.com/microsoft/terminal/assets/66909116/a9aa545c-0b6b-4604-aed5-489f3380b332)
claunia commented 2026-01-31 07:21:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 18, 2023):

That probably makes sense. I think GenHTML predates our support for bold and italic. Good find!

Note

Walkthrough

Just about here is where we'd need to fix this:
1745857407/src/buffer/out/textBuffer.cpp (L2124-L2141)

That'll need to account for other TextAttributes too, beyond just color.

@zadjii-msft commented on GitHub (Oct 18, 2023): That probably makes sense. I think GenHTML predates our support for bold and italic. Good find! > **Note** > ## Walkthrough Just about here is where we'd need to fix this: https://github.com/microsoft/terminal/blob/174585740759f3e473c5a4efe3207a20d2c78511/src/buffer/out/textBuffer.cpp#L2124-L2141 That'll need to account for other [`TextAttribute`](https://github.com/microsoft/terminal/blob/main/src/buffer/out/TextAttribute.hpp)s too, beyond just color.
claunia commented 2026-01-31 07:21:27 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Oct 28, 2023):

We should really be using all useful TextAttributes during formatted copy. Do note that some clients (that receives) formatting information might ignore unsupported properties.

1745857407/src/buffer/out/textBuffer.cpp (L2015-L2018)

Instead of TextAndColor, we can send the current TextAttributes and properties can be read directly from it.

Italic, bold and underline should be preserved.

I tried this for underlines, and already has something that works. Two problems though:

  • Couldn't find clients that would actually use those CSS underline properties (color/style). So, they're getting ignored anyway.
  • Doesn't make sense to do it only for underlines. All (useful) TextAttributes should be read and copied. (TextAtributes properties that cannot be represented in HTML can be ignored.)
@tusharsnx commented on GitHub (Oct 28, 2023): We should really be using all useful TextAttributes during formatted copy. Do note that some clients (that receives) formatting information might ignore unsupported properties. https://github.com/microsoft/terminal/blob/174585740759f3e473c5a4efe3207a20d2c78511/src/buffer/out/textBuffer.cpp#L2015-L2018 Instead of `TextAndColor`, we can send the current `TextAttributes` and properties can be read directly from it. > Italic, bold and underline should be preserved. I tried this for underlines, and already has something that works. Two problems though: - Couldn't find clients that would actually use those CSS underline properties (color/style). So, they're getting ignored anyway. - Doesn't make sense to do it only for underlines. All (useful) `TextAttributes` should be read and copied. (`TextAtributes` properties that cannot be represented in HTML can be ignored.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl good first issue Help Wanted In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?