starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

DOSKEY aliases work unexpectedly #20700

New Issue
Open
opened 2026-01-31 07:21:38 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 07:21:38 +00:00
Owner
Copy Link

Originally created by @o-sdn-o on GitHub (Oct 20, 2023).

Windows Terminal version

current main

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

According to https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/doskey

$T or $t Separates commands. Use either of these special characters to separate commands when you create macros or type commands on the doskey command line. These special characters are equivalent to using the ampersand (&) on a command line.

and https://ss64.com/nt/doskey.html

Advanced macro definitions:

$T If you put more than one command in a DOSKEY macro, use $T.
to separate them. Equivalent to & in a batch file.

the following commands

doskey test=echo 123 $t echo 456
test

and

echo 123 & echo 456

should give the same output.

Expected Behavior

C:\Users\sdn>doskey test=echo 123 $t echo 456

C:\Users\sdn>test
123
456

C:\Users\sdn>

Actual Behavior

C:\Users\sdn>doskey test=echo 123 $t echo 456

C:\Users\sdn>test
123

C:\Users\sdn>456

C:\Users\sdn>

Related to #14991

Originally created by @o-sdn-o on GitHub (Oct 20, 2023). ### Windows Terminal version current main ### Windows build number 10.0.19045.3448 ### Other Software _No response_ ### Steps to reproduce According to https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/doskey > $T or $t Separates commands. Use either of these special characters to separate commands when you create macros or type commands on the doskey command line. These special characters are equivalent to using the ampersand (&) on a command line. and https://ss64.com/nt/doskey.html > Advanced macro definitions: > > $T If you put more than one command in a DOSKEY macro, use $T. > to separate them. Equivalent to & in a batch file. the following commands ``` doskey test=echo 123 $t echo 456 test ``` and ``` echo 123 & echo 456 ``` should give the same output. ### Expected Behavior ``` C:\Users\sdn>doskey test=echo 123 $t echo 456 C:\Users\sdn>test 123 456 C:\Users\sdn> ``` ### Actual Behavior ``` C:\Users\sdn>doskey test=echo 123 $t echo 456 C:\Users\sdn>test 123 C:\Users\sdn>456 C:\Users\sdn> ``` Related to #14991
claunia commented 2026-01-31 07:21:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2023):

Say, does this work properly for you on 1.18?

@DHowett commented on GitHub (Oct 20, 2023): Say, does this work properly for you on 1.18?
claunia commented 2026-01-31 07:21:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2023):

From my own testing:

rs1

chop is incapable of loading conhostv2 from rs1. I can't test earlier than rs2.

rs2

image

broken

rs3

image

broken

rs5

image

broken

19h1

image

broken

@DHowett commented on GitHub (Oct 20, 2023): From my own testing: ### rs1 chop is incapable of loading `conhostv2` from rs1. I can't test earlier than rs2. ### rs2 <img width="432" alt="image" src="https://github.com/microsoft/terminal/assets/189190/44a006fc-6204-41d7-ab29-309bc32771c9"> broken ### rs3 <img width="567" alt="image" src="https://github.com/microsoft/terminal/assets/189190/53edcf5d-6084-4857-90d9-177592f983dc"> broken ### rs5 <img width="439" alt="image" src="https://github.com/microsoft/terminal/assets/189190/85a00b18-9d2f-410b-b648-ce0080aae511"> broken ### 19h1 <img width="431" alt="image" src="https://github.com/microsoft/terminal/assets/189190/e38e8299-61ed-4ebc-a5d3-21ca47ee9644"> broken
claunia commented 2026-01-31 07:21:40 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

In release-1.18 branch the same result:

C:\Users\sdn>doskey test=echo 123 $t echo 456

C:\Users\sdn>test
123

C:\Users\sdn>456

C:\Users\sdn>
@o-sdn-o commented on GitHub (Oct 21, 2023): In `release-1.18` branch the same result: ``` C:\Users\sdn>doskey test=echo 123 $t echo 456 C:\Users\sdn>test 123 C:\Users\sdn>456 C:\Users\sdn> ```
claunia commented 2026-01-31 07:21:40 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

In NT3.51/Win2K/WinXP/7/8.1 the same result as in Win10,

but in Windows 3.11 slightly different result:
image

Also, & does not work in Win311:
image

@o-sdn-o commented on GitHub (Oct 21, 2023): In NT3.51/Win2K/WinXP/7/8.1 the same result as in Win10, but in Windows 3.11 slightly different result: ![image](https://github.com/microsoft/terminal/assets/11535558/cb1512b9-011e-41ff-8f86-d265532667ef) Also, `&` does not work in Win311: ![image](https://github.com/microsoft/terminal/assets/11535558/2e84c0b8-7f38-42a6-ba3f-8d20ac5f3fd2)
claunia commented 2026-01-31 07:21:40 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

It looks like the line command split (multicommand) first appeared in doskey and later in cmd.exe itself. And now if we suddenly decide to fix this behavior, we just need to replace $T with & during parsing the cooked read and send it to cmd.exe in one line without splitting into multiline.

@o-sdn-o commented on GitHub (Oct 21, 2023): It looks like the line command split (multicommand) first appeared in doskey and later in cmd.exe itself. And now if we suddenly decide to fix this behavior, we just need to replace `$T` with `&` during parsing the cooked read and send it to cmd.exe in one line without splitting into multiline.
claunia commented 2026-01-31 07:21:40 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Oct 21, 2023):

doskey test=echo 123 ^& echo 345
@237dmitry commented on GitHub (Oct 21, 2023): ``` doskey test=echo 123 ^& echo 345 ```
claunia commented 2026-01-31 07:21:40 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

In Win 3.11:
image

In WinNT 3.51
image

In Win2K:
image

In WinXP/7/8.1/10:
image

@o-sdn-o commented on GitHub (Oct 21, 2023): In Win 3.11: ![image](https://github.com/microsoft/terminal/assets/11535558/0191f2f0-9834-431d-8113-c43bfeb22c10) In WinNT 3.51 ![image](https://github.com/microsoft/terminal/assets/11535558/3e5c3eab-5173-48a3-8124-b0151b6a2f4d) In Win2K: ![image](https://github.com/microsoft/terminal/assets/11535558/79cd9b0a-2366-48b2-97d7-f5cc75234ba0) In WinXP/7/8.1/10: ![image](https://github.com/microsoft/terminal/assets/11535558/3652391d-1c78-48f3-9833-62960247dba2)
claunia commented 2026-01-31 07:21:41 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

We can look at the use of $t and ^& tags in batch files by searching on github.

@o-sdn-o commented on GitHub (Oct 21, 2023): We can look at the use of [`$t`](https://github.com/search?q=doskey+%24t+%28path%3A*.cmd+OR+path%3A*.bat%29&type=Code&ref=advsearch&l=&l=) and [`^&`](https://github.com/search?q=doskey+%5E%26+%28path%3A*.cmd+OR+path%3A*.bat%29&type=Code&ref=advsearch&l=&l=) tags in batch files by searching on github.
claunia commented 2026-01-31 07:21:41 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 21, 2023):

So, it looks like this behavior has been going on since the beginning, when the TSR doskey was incorporated into the NT kernel.

@o-sdn-o commented on GitHub (Oct 21, 2023): So, it looks like this behavior has been going on since the beginning, when the TSR doskey was incorporated into the NT kernel.
claunia commented 2026-01-31 07:21:41 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 23, 2023):

The issue is probably related to us printing the prompt again, not anything to do with us replacing $t with the right token. :)

@DHowett commented on GitHub (Oct 23, 2023): The issue is probably related to us printing the prompt again, not anything to do with us replacing `$t` with the right token. :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CookedRead Impact-Visual Issue-Bug Needs-Tag-Fix Priority-3 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?