starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Multiple 'Settings' entries on title bar context menu. Crashes Terminal. #20709

New Issue
Closed
opened 2026-01-31 07:21:49 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:21:49 +00:00
Owner
Copy Link

Originally created by @strangebit on GitHub (Oct 22, 2023).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

1.18.2822.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Not sure what is triggering it unfortunately.

Expected Behavior

No response

Actual Behavior

I've noticed that sometimes, after using Terminal for some time, the right-click context menu on the titlebar ends up getting multiple Settings entries. When I click on one of them, Terminal crashes. When there's only one it doesn't crash; it opens the Settings panel as it should.

See the video below. Again this is after using Terminal for some time, opening and closing windows, etc. I don't know how to reproduce the bug consistently.

https://github.com/microsoft/terminal/assets/11712728/4e8e324e-8934-42c0-8d48-b73f488d32fd

I've seen it before with as many as six of these Settings entries.

The crash in the above video corresponds to this event (if it helps):

Faulting application name: WindowsTerminal.exe, version: 1.18.2310.9002, time stamp: 0x65248b0f
Faulting module name: TerminalApp.dll, version: 1.18.2310.9002, time stamp: 0x65248aa8
Exception code: 0xc0000005
Fault offset: 0x0000000000050c6a
Faulting process ID: 0x4d8c
Faulting application start time: 0x01da047ff2360b38
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe\TerminalApp.dll
Report ID: 4ed86fa0-563b-4b67-bb0e-de7b5ea21887
Faulting package full name: Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

I'm not sure if it's related to my other bug report #16100.

Originally created by @strangebit on GitHub (Oct 22, 2023). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 1.18.2822.0 ### Windows build number 10.0.19045.0 ### Other Software _No response_ ### Steps to reproduce Not sure what is triggering it unfortunately. ### Expected Behavior _No response_ ### Actual Behavior I've noticed that sometimes, after using Terminal for some time, the right-click context menu on the titlebar ends up getting multiple `Settings` entries. When I click on one of them, Terminal crashes. When there's only one it doesn't crash; it opens the Settings panel as it should. See the video below. Again this is after using Terminal for some time, opening and closing windows, etc. I don't know how to reproduce the bug consistently. https://github.com/microsoft/terminal/assets/11712728/4e8e324e-8934-42c0-8d48-b73f488d32fd I've seen it before with as many as six of these `Settings` entries. The crash in the above video corresponds to this event (if it helps): Faulting application name: WindowsTerminal.exe, version: 1.18.2310.9002, time stamp: 0x65248b0f Faulting module name: TerminalApp.dll, version: 1.18.2310.9002, time stamp: 0x65248aa8 Exception code: 0xc0000005 Fault offset: 0x0000000000050c6a Faulting process ID: 0x4d8c Faulting application start time: 0x01da047ff2360b38 Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe\TerminalApp.dll Report ID: 4ed86fa0-563b-4b67-bb0e-de7b5ea21887 Faulting package full name: Microsoft.WindowsTerminal_1.18.2822.0_x64__8wekyb3d8bbwe Faulting package-relative application ID: App I'm not sure if it's related to my other bug report #16100.
claunia added the Issue-BugIn-PRNeeds-Tag-FixProduct-TerminalArea-Windowing labels 2026-01-31 07:21:49 +00:00
claunia commented 2026-01-31 07:21:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 24, 2023):

I'm gonna guess this is also a window refrigeration bug.

I'd guess that the problem code is AppHost::_SystemMenuChangeRequested not getting called to remove the old entries before refrigeration.

Oh it definitely is. TerminalWindow only ever adds the settings entry when it gets created. AppHost however needs to clear that old entry out before we refrigerate the HWND. The old entries end up sticking around, which is why the old entries will explode the Terminal.

@zadjii-msft commented on GitHub (Oct 24, 2023): I'm gonna guess this is also a window refrigeration bug. I'd guess that the problem code is `AppHost::_SystemMenuChangeRequested` not getting called to remove the old entries before refrigeration. Oh it definitely is. `TerminalWindow` only ever adds the settings entry when it gets created. `AppHost` however needs to clear that old entry out before we refrigerate the HWND. The old entries end up sticking around, which is why the old entries will explode the Terminal.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20709
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?