starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Severe Memory Leak, Possibly Related to UIA #20710

New Issue
Closed
opened 2026-01-31 07:21:51 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:21:51 +00:00
Owner
Copy Link

Originally created by @Simon818 on GitHub (Oct 21, 2023).

Windows Terminal version

1.19.2682.0

Windows build number

10.0.19045.3570

Other Software

NVDA 2023.3

Steps to reproduce

With NVDA running, open several terminal windows and leave them running for a few hours. Occasionally check the usage of the WindowsTerminal.exe process. The terminal windows do not need to be particularly active, though they should have something more than just a command prompt window running on them--perhaps SSH sessions or WSL windows.

Expected Behavior

Windows Terminal should remain within reasonable memory usage.

Actual Behavior

On my system, Windows Terminal's memory usage grows to hundreds of megabytes over time, causing responsiveness issues in Terminal and seemingly affecting the responsiveness of NVDA's UIA access. If I leave a terminal window open overnight, it and all other Terminal windows are nearly unusable the next morning, and the responsiveness of NVDA itself is affected, leaving core OS functionality unusable until I close the process. This leads me to believe the issue is related to UIA.

CC @carlos-zamora @codeofdusk

Originally created by @Simon818 on GitHub (Oct 21, 2023). ### Windows Terminal version 1.19.2682.0 ### Windows build number 10.0.19045.3570 ### Other Software NVDA 2023.3 ### Steps to reproduce With NVDA running, open several terminal windows and leave them running for a few hours. Occasionally check the usage of the WindowsTerminal.exe process. The terminal windows do not need to be particularly active, though they should have something more than just a command prompt window running on them--perhaps SSH sessions or WSL windows. ### Expected Behavior Windows Terminal should remain within reasonable memory usage. ### Actual Behavior On my system, Windows Terminal's memory usage grows to hundreds of megabytes over time, causing responsiveness issues in Terminal and seemingly affecting the responsiveness of NVDA's UIA access. If I leave a terminal window open overnight, it and all other Terminal windows are nearly unusable the next morning, and the responsiveness of NVDA itself is affected, leaving core OS functionality unusable until I close the process. This leads me to believe the issue is related to UIA. CC @carlos-zamora @codeofdusk
claunia commented 2026-01-31 07:21:53 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 21, 2023):

Possible cause: This doesn't release any memory
https://github.com/microsoft/terminal/blob/main/src/renderer/uia/UiaRenderer.cpp#L234

If it's due to that, we could limit to either 4KiB or 2x the previous write size, whatever is larger (as an example):

if (_newOutput.capacity() >= std::max<size_t>(4096, _queuedOutput.size() * 2))
{
    _newOutput = std::wstring{};
    _newOutput.reserve(2048);
}
@lhecker commented on GitHub (Oct 21, 2023): Possible cause: This doesn't release any memory https://github.com/microsoft/terminal/blob/main/src/renderer/uia/UiaRenderer.cpp#L234 If it's due to that, we could limit to either 4KiB or 2x the previous write size, whatever is larger (as an example): ```cpp if (_newOutput.capacity() >= std::max<size_t>(4096, _queuedOutput.size() * 2)) { _newOutput = std::wstring{}; _newOutput.reserve(2048); } ```
claunia commented 2026-01-31 07:21:53 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 24, 2023):

Thanks @Simon818. Could you capture a memory dump for us? We have a guide for that right here: https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips#capturing-and-sending-dumps

@carlos-zamora commented on GitHub (Oct 24, 2023): Thanks @Simon818. Could you capture a memory dump for us? We have a guide for that right here: https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips#capturing-and-sending-dumps
claunia commented 2026-01-31 07:21:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 30, 2023):

I'm gonna give @Simon818 another week to try and get back to us here. This sounds really painful, but we need to get a dump to see where these allocations are coming from.

I suppose @carlos-zamora you might also be able to use App Verifier pointed at the Terminal with NVDA turned on. That might catch some of the more obvious mistakes 🤷

@zadjii-msft commented on GitHub (Oct 30, 2023): I'm gonna give @Simon818 another week to try and get back to us here. This sounds really painful, but we need to get a dump to see where these allocations are coming from. I suppose @carlos-zamora you might also be able to use App Verifier pointed at the Terminal with NVDA turned on. That might catch some of the more obvious mistakes 🤷
claunia commented 2026-01-31 07:21:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 1, 2023):

I'm gonna close this in favor of #16217, since that thread has more of an investigation in it. Thanks!

/dup #16217

@zadjii-msft commented on GitHub (Nov 1, 2023): I'm gonna close this in favor of #16217, since that thread has more of an investigation in it. Thanks! /dup #16217
claunia commented 2026-01-31 07:21:54 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Nov 1, 2023):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Nov 1, 2023): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Priority-2 Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20710
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?