starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Lost new line character when using ReadFile #20731

New Issue
Closed
opened 2026-01-31 07:22:28 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:22:28 +00:00
Owner
Copy Link

Originally created by @confusedsushi on GitHub (Oct 24, 2023).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.18.2822.0

Windows build number

10.0.22631.2361

Other Software

The problem was first noted in some other console application which is using ReadFile to read from the console. The problem was stripped down to a minimal program

#include <assert.h>
#include <windows.h>

int __cdecl main() {
  char buf[2];
  DWORD read;

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 2, &read, NULL);
  assert(read == 2);
  assert(buf[0] == '\r');
  assert(buf[1] == '\n');

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL);
  assert(read == 1);
  assert(buf[0] == '\r');

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL);
  assert(read == 1);
  assert(buf[0] == '\n');
}

It seems the unexpected behavior first occurred with https://github.com/microsoft/terminal/pull/14745.

Steps to reproduce

Compile the program using your favorite C compiler and run it. Hit <ENTER> until the example exits.

Expected Behavior

In the good case you have to hit <ENTER> twice and the program exits gracefully.

Actual Behavior

In the bad case you have to hit <ENTER> three times and the last assert fires an error.

Originally created by @confusedsushi on GitHub (Oct 24, 2023). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.18.2822.0 ### Windows build number 10.0.22631.2361 ### Other Software The problem was first noted in some other console application which is using ``ReadFile`` to read from the console. The problem was stripped down to a minimal program ````cpp #include <assert.h> #include <windows.h> int __cdecl main() { char buf[2]; DWORD read; ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 2, &read, NULL); assert(read == 2); assert(buf[0] == '\r'); assert(buf[1] == '\n'); ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL); assert(read == 1); assert(buf[0] == '\r'); ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL); assert(read == 1); assert(buf[0] == '\n'); } ```` It seems the unexpected behavior first occurred with https://github.com/microsoft/terminal/pull/14745. ### Steps to reproduce Compile the program using your favorite C compiler and run it. Hit ``<ENTER>`` until the example exits. ### Expected Behavior In the good case you have to hit ``<ENTER>`` twice and the program exits gracefully. ### Actual Behavior In the bad case you have to hit ``<ENTER>`` three times and the last assert fires an error.
claunia commented 2026-01-31 07:22:31 +00:00
Author
Owner
Copy Link

@codesculpture commented on GitHub (Jan 24, 2024):

Hey, is this being landed in release ? If yes, in which version

@codesculpture commented on GitHub (Jan 24, 2024): Hey, is this being landed in release ? If yes, in which version
claunia commented 2026-01-31 07:22:31 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 24, 2024):

This is staged for the next 1.18 servicing release! Sorry for the delay.

@DHowett commented on GitHub (Jan 24, 2024): This is staged for the next 1.18 servicing release! Sorry for the delay.
claunia commented 2026-01-31 07:22:31 +00:00
Author
Owner
Copy Link

@Uvaistd24 commented on GitHub (Jan 24, 2024):

@.***

On Wed, 24 Jan 2024 at 06:52 Dustin L. Howett @.***>
wrote:

This is staged for the next 1.18 servicing release! Sorry for the delay.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/16223#issuecomment-1907308152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEH2LILBOVOFP4KPCGH2SG3YQCAPZAVCNFSM6AAAAAA6NS23UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGMYDQMJVGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@Uvaistd24 commented on GitHub (Jan 24, 2024): ***@***.*** On Wed, 24 Jan 2024 at 06:52 Dustin L. Howett ***@***.***> wrote: > This is staged for the next 1.18 servicing release! Sorry for the delay. > > — > Reply to this email directly, view it on GitHub > <https://github.com/microsoft/terminal/issues/16223#issuecomment-1907308152>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BEH2LILBOVOFP4KPCGH2SG3YQCAPZAVCNFSM6AAAAAA6NS23UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGMYDQMJVGI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Blocking-Ingestion In-PR Issue-Bug Priority-1 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?