starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

dwControlKeyState behaviour changed between Windows 10/Windows 11 #20774

New Issue
Closed
opened 2026-01-31 07:23:39 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:23:39 +00:00
Owner
Copy Link

Originally created by @taviso on GitHub (Nov 6, 2023).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.19.231010001-preview

Windows build number

10.0.22621.0

Other Software

hiew 8.79 (inside wsl)

Steps to reproduce

I have a win32 console application (hiew, a powerful hex editor) that worked fine when invoked from within WSL in Windows 10, but no longer works in Windows 11. It still works okay when invoked from cmd or powershell, but I liked using it under WSL ☹️

Various keys no longer seem to register.

I wrote a quick c program to dump console input events, and I observe the following pattern:

  • Pressing F11 with a win32 console application under WSL on Windows 10 (conhost 10.0.19041.3393) (Works ✅):
Key event:
 bKeyDown:          1
 wRepeatCount:      1
 wVirtualKeyCode:   0x7a
    MAPVK_VK_TO_VSC  => 0x57
    MAPVK_VK_TO_CHAR => 00
 wVirtualScanCode:  0x57
    MAPVK_VSC_TO_VK => 0x7a
    MAPVK_VSC_TO_VK_EX => 0x7a
 uChar:
  UnicodeChar:      '' (0000)
  AsciiChar:        '' (00)
    VkKeyScanA  => 0x3c0
 dwControlKeyState: 0
  • Pressing F11 with a win32 console application under cmd on Windows 11 (I've tried release conhost, and current stable and preview OpenConsole, with same result ✅)
Key event:
 bKeyDown:          1
 wRepeatCount:      1
 wVirtualKeyCode:   0x7a
    MAPVK_VK_TO_VSC  => 0x57
    MAPVK_VK_TO_CHAR => 00
 wVirtualScanCode:  0x57
    MAPVK_VSC_TO_VK => 0x7a
    MAPVK_VSC_TO_VK_EX => 0x7a
 uChar:
  UnicodeChar:      ' ' (0000)
  AsciiChar:        ' ' (00)
    VkKeyScanA  => 0x3c0
 dwControlKeyState: 0
  • Pressing F11 with a win32 console application under WSL on Windows 11 (Also tried release conhost, stable and preview OpenConsole, with same result ❌ )
Key event:
 bKeyDown:          1
 wRepeatCount:      1
 wVirtualKeyCode:   0x7a
    MAPVK_VK_TO_VSC  => 0x57
    MAPVK_VK_TO_CHAR => 00
 wVirtualScanCode:  0x57
    MAPVK_VSC_TO_VK => 0x7a
    MAPVK_VSC_TO_VK_EX => 0x7a
 uChar:
  UnicodeChar:      '' (0000)
  AsciiChar:        '' (00)
    VkKeyScanA  => 0x3c0
 dwControlKeyState: 256
ENHANCED_KEY

I think the issue is that ENHANCED_KEY is now being set, and it wasn't before. I don't know why this changed, but it seems to have broken at least one app ☹️

Do you know what might be causing this?

Expected Behavior

Keys to register.

Actual Behavior

Keys are ignored, I suspect because dwControlKeyState changed.

Originally created by @taviso on GitHub (Nov 6, 2023). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.19.231010001-preview ### Windows build number 10.0.22621.0 ### Other Software hiew 8.79 (inside wsl) ### Steps to reproduce I have a win32 console application ([hiew](https://hiew.ru/), a powerful hex editor) that worked fine when invoked from within WSL in Windows 10, but no longer works in Windows 11. It still works okay when invoked from cmd or powershell, but I liked using it under WSL ☹️ Various keys no longer seem to register. I wrote a quick c program to dump console input events, and I observe the following pattern: - Pressing F11 with a win32 console application under WSL on Windows 10 (conhost 10.0.19041.3393) (Works ✅): ``` Key event: bKeyDown: 1 wRepeatCount: 1 wVirtualKeyCode: 0x7a MAPVK_VK_TO_VSC => 0x57 MAPVK_VK_TO_CHAR => 00 wVirtualScanCode: 0x57 MAPVK_VSC_TO_VK => 0x7a MAPVK_VSC_TO_VK_EX => 0x7a uChar: UnicodeChar: '' (0000) AsciiChar: '' (00) VkKeyScanA => 0x3c0 dwControlKeyState: 0 ``` - Pressing F11 with a win32 console application under cmd on Windows 11 (I've tried release conhost, and current stable and preview OpenConsole, with same result ✅) ``` Key event: bKeyDown: 1 wRepeatCount: 1 wVirtualKeyCode: 0x7a MAPVK_VK_TO_VSC => 0x57 MAPVK_VK_TO_CHAR => 00 wVirtualScanCode: 0x57 MAPVK_VSC_TO_VK => 0x7a MAPVK_VSC_TO_VK_EX => 0x7a uChar: UnicodeChar: ' ' (0000) AsciiChar: ' ' (00) VkKeyScanA => 0x3c0 dwControlKeyState: 0 ``` - Pressing F11 with a win32 console application under *WSL* on Windows 11 (Also tried release conhost, stable and preview OpenConsole, with same result ❌ ) ``` Key event: bKeyDown: 1 wRepeatCount: 1 wVirtualKeyCode: 0x7a MAPVK_VK_TO_VSC => 0x57 MAPVK_VK_TO_CHAR => 00 wVirtualScanCode: 0x57 MAPVK_VSC_TO_VK => 0x7a MAPVK_VSC_TO_VK_EX => 0x7a uChar: UnicodeChar: '' (0000) AsciiChar: '' (00) VkKeyScanA => 0x3c0 dwControlKeyState: 256 ENHANCED_KEY ``` I think the issue is that [ENHANCED_KEY](https://learn.microsoft.com/en-us/windows/console/key-event-record-str#) is now being set, and it wasn't before. I don't know why this changed, but it seems to have broken at least one app ☹️ Do you know what might be causing this? ### Expected Behavior Keys to register. ### Actual Behavior Keys are ignored, I suspect because dwControlKeyState changed.
claunia commented 2026-01-31 07:23:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 6, 2023):

I'm almost certain this is probably due to #5021, though, there's probably a complicated relationship here between the fact that there's a different ConPTY that's used for Terminal (and is shipped with the Terminal), vs the one that WSL uses for interop (and is shipped with the OS)

@zadjii-msft commented on GitHub (Nov 6, 2023): I'm almost certain this is probably due to #5021, though, there's probably a complicated relationship here between the fact that there's a different ConPTY that's used for Terminal (and is shipped with the Terminal), vs the one that WSL uses for interop (and is shipped with the OS)
claunia commented 2026-01-31 07:23:41 +00:00
Author
Owner
Copy Link

@taviso commented on GitHub (Nov 6, 2023):

If I replace conhost.exe with OpenConsole, will WSL automatically pick it up interop as well? (I don't know how all the pieces fit together sorry!)

I'm willing to give it a shot and see if it's already been fixed somewhere...? (I assume I'll have to takeown/icacl/etc.., I don't mind voiding my warranty 😄)

@taviso commented on GitHub (Nov 6, 2023): If I replace conhost.exe with OpenConsole, will WSL automatically pick it up interop as well? (I don't know how all the pieces fit together sorry!) I'm willing to give it a shot and see if it's already been fixed somewhere...? (I assume I'll have to `takeown`/`icacl`/etc.., I don't mind voiding my warranty 😄)
claunia commented 2026-01-31 07:23:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 6, 2023):

It absolutely will! No warranty, etc, but you know the drill. 😄

Thanks for being so down to test things with us.

@DHowett commented on GitHub (Nov 6, 2023): It absolutely will! No warranty, etc, but you know the drill. :smile: Thanks for being so down to test things with us.
claunia commented 2026-01-31 07:23:42 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Nov 6, 2023):

To do it "correctly", you'd use a tool called sfpcopy.exe but it'll also work without it. Putting the original conhost.exe back will not restore Windows to its original state because conhost.exe is actually hardlinked to

C:\Windows\WinSxS\amd64_microsoft-onecore-console-host-core_31bf3856ad364e35_10.0.22621.2483_none_4d83bf9b9fc4fb79\conhost.exe

(...with a possibly different version number on your machine.)

You can probably (90% sure?) restore the original conhost.exe to its original state by running sfc /scannow. I've been running OpenConsole.exe as my conhost for about a year now and it's been fine, but I'm also running internal dev version of Windows anyways, so... 😅

@lhecker commented on GitHub (Nov 6, 2023): To do it "correctly", you'd use a tool called `sfpcopy.exe` but it'll also work without it. Putting the original `conhost.exe` back will not restore Windows to its original state because `conhost.exe` is actually hardlinked to ``` C:\Windows\WinSxS\amd64_microsoft-onecore-console-host-core_31bf3856ad364e35_10.0.22621.2483_none_4d83bf9b9fc4fb79\conhost.exe ``` (...with a possibly different version number on your machine.) You can probably (90% sure?) restore the original `conhost.exe` to its original state by running `sfc /scannow`. I've been running OpenConsole.exe as my conhost for about a year now and it's been fine, but I'm also running internal dev version of Windows anyways, so... 😅
claunia commented 2026-01-31 07:23:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 6, 2023):

Do note that if you damage the version in the component store (...\WinSxS) you become ineligible for future servicing updates. Replacing just the hardlink is much better in that regard. 😁

@DHowett commented on GitHub (Nov 6, 2023): Do note that if you damage the version in the component store (`...\WinSxS`) you become ineligible for future servicing updates. Replacing just the hardlink is _much better_ in that regard. 😁
claunia commented 2026-01-31 07:23:42 +00:00
Author
Owner
Copy Link

@taviso commented on GitHub (Nov 7, 2023):

I did get the system booted with 1.19.2310.10001, but sadly my console bug is still there!

I listened to your warning and didn't bother trying to mess with the links, I assume some future update will clobber it with a link, that's okay with me 😄

I guess there are probably not many people trying to use win32 console apps in WSL, maybe I can try to bisect it at least, even if I don't know what the solution is.

@taviso commented on GitHub (Nov 7, 2023): I did get the system booted with 1.19.2310.10001, but sadly my console bug is still there! I listened to your warning and didn't bother trying to mess with the links, I assume some future update will clobber it with a link, that's okay with me 😄 I guess there are probably not many people trying to use win32 console apps in WSL, maybe I can try to bisect it at least, even if I don't know what the solution is.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Impact-Correctness In-PR Issue-Bug Needs-Tag-Fix Priority-1 Product-Conpty zInbox-Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?