starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Use default page transition for settings pages instead of drill-in transition #20789

New Issue
Open
opened 2026-01-31 07:24:11 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:24:11 +00:00
Owner
Copy Link

Originally created by @chausner on GitHub (Nov 11, 2023).

Description of the new feature/enhancement

The settings content frame currently specifies DrillInNavigationTransitionInfo as content transition mode: d14524cd4c/src/cascadia/TerminalSettingsEditor/MainPage.xaml (L179)

The drill-in effect, as its name suggests, is in my opinion suitable when navigating further down in a hierarchy (e.g. viewing a list of folders and navigating into a subfolder) but less appropriate when switching between settings pages which are on the same logical level.

Instead, I suggest to use the default page transition mode "slide from bottom", which is also used in the Windows Settings, and whose UI is very similar to the settings in Windows Terminal. By using the same transitions, Windows Terminal will feel more consistent with the inbuilt OS apps.

Proposed technical implementation details (optional)

Replace lines d14524cd4c/src/cascadia/TerminalSettingsEditor/MainPage.xaml (L177-L181) with

<NavigationThemeTransition />

(There is a difference between specifying <NavigationThemeTransition /> and not setting Frame.ContentTransitions at all. If it is not set at all, the Frame will still use the "slide from bottom" transition between page transitions as a default but it will not show the animation on initial displaying of the page. Since the Windows Settings app does show an animation on initial loading of the page, my suggestion is to do it here, as well.)

Originally created by @chausner on GitHub (Nov 11, 2023). # Description of the new feature/enhancement The settings content frame currently specifies `DrillInNavigationTransitionInfo` as content transition mode: https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L179 The drill-in effect, as its name suggests, is in my opinion suitable when navigating further down in a hierarchy (e.g. viewing a list of folders and navigating into a subfolder) but less appropriate when switching between settings pages which are on the same logical level. Instead, I suggest to use the default page transition mode "slide from bottom", which is also used in the Windows Settings, and whose UI is very similar to the settings in Windows Terminal. By using the same transitions, Windows Terminal will feel more consistent with the inbuilt OS apps. # Proposed technical implementation details (optional) Replace lines https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L177-L181 with ```xaml <NavigationThemeTransition /> ``` (There is a difference between specifying `<NavigationThemeTransition />` and not setting `Frame.ContentTransitions` at all. If it is not set at all, the Frame will still use the "slide from bottom" transition between page transitions as a default but it will not show the animation on initial displaying of the page. Since the Windows Settings app does show an animation on initial loading of the page, my suggestion is to do it here, as well.)
claunia added the Help WantedIssue-TaskProduct-TerminalArea-SettingsUI labels 2026-01-31 07:24:11 +00:00
claunia commented 2026-01-31 07:24:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2023):

This seems reasonable to me. We'd maybe want the SlideNavigationTransitionEffect.FromRight / FromLeft transitions when moving between the various different Profile subpages (same with the colorscheme ones), but this seems sensible to me

@zadjii-msft commented on GitHub (Nov 13, 2023): This seems reasonable to me. We'd maybe want the `SlideNavigationTransitionEffect.FromRight` / `FromLeft` transitions when moving between the various different Profile subpages (same with the colorscheme ones), but this seems sensible to me
claunia commented 2026-01-31 07:24:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2023):

Oh wait I remember this!

#10632

We should try to Suppress this when the tab is getting switched to.

@zadjii-msft commented on GitHub (Nov 13, 2023): Oh wait I remember this! #10632 We should try to Suppress this when the tab is getting switched to.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?